<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style='--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;'>
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px;
}
body {
font-family: var(--default-regular-font, "GitLab Sans"),-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style='font-size: inherit; -webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px; font-family: var(--default-regular-font, "GitLab Sans"),-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";'>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.rtems.org/joel">Joel Sherrill</a>
commented on a
<a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/80#note_108565">discussion</a>:
</p>
<div class="md" style="color: #333238; word-wrap: break-word;">
<p dir="auto" style="color: #333238; margin: 0 0 16px;" align="initial">That's a long list of challenges. Let's see if we can narrow them down. Sorry this changes the order but hopefully this is easy to follow.</p>
<p dir="auto" style="color: #333238; margin: 0 0 16px;" align="initial">These are probably just a matter of changing the error return code that is used by dosfs and should be one line changes:</p>
<ul dir="auto" style="text-align: initial; list-style-type: disc; margin: 0 0 16px; padding: 0;">
<li style="margin-top: 0; line-height: 1.6em; margin-left: 25px; padding-left: 3px;">Rename file with directory fails (wrong errno)</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">Rename directory with file fails (wrong errno)</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">Rename directory with ancestor directory fails (wrong errno)</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">Testing empty filepath fails (wrong errno)</li>
</ul>
<p dir="auto" style="color: #333238; margin: 0 0 16px;" align="initial">The following test cases should be split out to a separate executable or moved if there is another test where they could go that is already not run on the dosfs. Somehow they just get included in an executable that makes sense.</p>
<ul dir="auto" style="text-align: initial; list-style-type: disc; margin: 0 0 16px; padding: 0;">
<li style="margin-top: 0; line-height: 1.6em; margin-left: 25px; padding-left: 3px;">Symlinks tests fail, but this is expected because FAT does not handle them</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">The tests that deal with permissions (I guess also these are expected failures)</li>
</ul>
<p dir="auto" style="color: #333238; margin: 0 0 16px;" align="initial">That leaves these which "feel" harder to fix.</p>
<ul dir="auto" style="text-align: initial; list-style-type: disc; margin: 0 0 16px; padding: 0;">
<li style="margin-top: 0; line-height: 1.6em; margin-left: 25px; padding-left: 3px;">Rename same file fails</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">Rename empty directory with another empty directory fails</li>
</ul>
<p dir="auto" style="color: #333238; margin: 0 0 16px;" align="initial">If you can address the first two groups which seems manageable, that leaves the two last rename ones. Any idea what these two need to be checking for? It just seems like these are missing a check.</p>
<p dir="auto" style="color: #333238; margin: 0;" align="initial">Disclaimer: I haven't worked on the dosfs.</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #737278;">
—
<br>
<a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/80#note_108565">View it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.rtems.org">gitlab.rtems.org</a>. <a href="https://gitlab.rtems.org/-/sent_notifications/ee8530b903dd99cbeb02c5d162186148/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.rtems.org/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.rtems.org/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/80#note_108565"}}</script>
</p>
</div>
</body>
</html>