<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style='--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;'>
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px;
}
body {
font-family: var(--default-regular-font, "GitLab Sans"),-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style='font-size: inherit; -webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px; font-family: var(--default-regular-font, "GitLab Sans"),-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";'>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.rtems.org/gedare">Gedare Bloom</a>
<a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/issues/5057#note_108974">commented</a>:
</p>
<div class="md" style="color: #333238; word-wrap: break-word;">
<p dir="auto" style="color: #333238; margin: 0 0 16px;" align="initial">As this is a protocol, it would help to describe it in terms of a grammar and/or a state machine. In addition, the rationale for the field sizes should be explained, and what that means. The reasoning for using variable versus fixed framing would be helpful. The simplicity of this protocol seems to lend itself well to having a few well-defined packet formats. Here there are 6 different kinds of messages, with 5 different formats. It seems this could be made more regular to simplify processing.</p>
<p dir="auto" style="color: #333238; margin: 0 0 16px;" align="initial">It's not intuitive to me what a 12-bit base64url encoded value even is, are you truncating/compressing them somehow? Or, is it the 12-bit number gets base64url encoded (into 3 UTF-8 characters ==> 24 bits in the bitstream)? It would be helpful to see the description of the packets in terms of their actual contents (e.g., 3 ASCII characters in base64url encoded, 11 ASCII characters, etc.) instead of their underlying data types (12-bit number, 64-bit signal value).</p>
<p dir="auto" style="color: #333238; margin: 0;" align="initial">Do signals and channels have semantic meaning in the protocol? If so, please explain what those are. If not, why not just define a generic way of passing data?</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #737278;">
—
<br>
<a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/issues/5057#note_108974">View it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.rtems.org">gitlab.rtems.org</a>. <a href="https://gitlab.rtems.org/-/sent_notifications/83520abec0fe330ee4c37e70abda4655/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.rtems.org/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.rtems.org/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Issue","url":"https://gitlab.rtems.org/rtems/rtos/rtems/-/issues/5057#note_108974"}}</script>
</p>
</div>
</body>
</html>