<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style='--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;'>
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px;
}
body {
font-family: var(--default-regular-font, "GitLab Sans"),-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style='font-size: inherit; -webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px; font-family: var(--default-regular-font, "GitLab Sans"),-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";'>
<div class="content">
<p class="details" style="font-style: italic; color: #737278;">
<a href="https://gitlab.rtems.org/c-mauderer">Christian Mauderer</a> created an issue: <a href="https://gitlab.rtems.org/rtems/tools/rtems-source-builder/-/issues/32">#32</a>
</p>
<p>
Assignee: Christian Mauderer
</p>
<div class="md" style="color: #333238; word-wrap: break-word;">
<h2 dir="auto" style="font-size: 1.5em; font-weight: 600; padding-bottom: .3em; border-bottom-width: 1px; border-bottom-color: #bfbfc3; border-bottom-style: solid; color: #333238; margin: 0 0 16px;" align="initial">
<a href="#summary" aria-hidden="true" class="anchor" id="user-content-summary" style="margin-top: 0; float: left; margin-left: -20px; text-decoration: none; outline: none;"></a>Summary</h2>
<p dir="auto" style="color: #333238; margin: 0 0 16px;" align="initial">I wanted to build the <code style='font-size: 90%; color: #1f1e24; word-wrap: break-word; background-color: #ececef; border-radius: .25rem; margin-top: 0; font-weight: inherit; font-family: var(--default-mono-font, "GitLab Mono"),"JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; vertical-align: bottom; white-space: pre-wrap; overflow-wrap: break-word; word-break: keep-all; padding: 2px 4px;'>qemu-xilinx</code> on an Archlinux System with a German language setting. With that, downloading the sources for qemu-xilinx-v2023.2-1 failed. It seems that the <code style='font-size: 90%; color: #1f1e24; word-wrap: break-word; background-color: #ececef; border-radius: .25rem; font-weight: inherit; font-family: var(--default-mono-font, "GitLab Mono"),"JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; vertical-align: bottom; white-space: pre-wrap; overflow-wrap: break-word; word-break: keep-all; padding: 2px 4px;'>source-builder/sb/git.py</code> module tries to parse some language specific strings. My problem is at that line:</p>
<p dir="auto" style="color: #333238; margin: 0 0 16px;" align="initial"><a href="https://gitlab.rtems.org/rtems/tools/rtems-source-builder/-/blob/8488d28da6bfa233a90c2e80898696fd8de15534/source-builder/sb/git.py#L241" style="margin-top: 0;">https://gitlab.rtems.org/rtems/tools/rtems-source-builder/-/blob/8488d28da6bfa233a90c2e80898696fd8de15534/source-builder/sb/git.py#L241</a></p>
<p dir="auto" style="color: #333238; margin: 0 0 16px;" align="initial">With a LANG='C' or LANG='en_US' setting, the output of <code style='font-size: 90%; color: #1f1e24; word-wrap: break-word; background-color: #ececef; border-radius: .25rem; margin-top: 0; font-weight: inherit; font-family: var(--default-mono-font, "GitLab Mono"),"JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; vertical-align: bottom; white-space: pre-wrap; overflow-wrap: break-word; word-break: keep-all; padding: 2px 4px;'>git remote show origin</code> has a line</p>
<p dir="auto" style="color: #333238; margin: 0 0 16px;" align="initial">HEAD branch: main</p>
<p dir="auto" style="color: #333238; margin: 0 0 16px;" align="initial">that is parsed by that module. With a LANG='de_DE', I instead get a</p>
<p dir="auto" style="color: #333238; margin: 0 0 16px;" align="initial">Hauptbranch: main</p>
<p dir="auto" style="color: #333238; margin: 0 0 16px;" align="initial">With that output, no default branch can be found and the source builder crashes at <code style='font-size: 90%; color: #1f1e24; word-wrap: break-word; background-color: #ececef; border-radius: .25rem; margin-top: 0; font-weight: inherit; font-family: var(--default-mono-font, "GitLab Mono"),"JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; vertical-align: bottom; white-space: pre-wrap; overflow-wrap: break-word; word-break: keep-all; padding: 2px 4px;'>source-builder/sb/download.py</code> in line 511:</p>
<p dir="auto" style="color: #333238; margin: 0 0 16px;" align="initial">repo.checkout(default_branch)</p>
<p dir="auto" style="color: #333238; margin: 0 0 16px;" align="initial">I'm not sure whether that's the only place where a language specific string is parsed.</p>
<h2 dir="auto" style="font-size: 1.5em; font-weight: 600; padding-bottom: .3em; border-bottom-width: 1px; border-bottom-color: #bfbfc3; border-bottom-style: solid; color: #333238; margin: 24px 0 16px;" align="initial">
<a href="#steps-to-reproduce" aria-hidden="true" class="anchor" id="user-content-steps-to-reproduce" style="margin-top: 0; float: left; margin-left: -20px; text-decoration: none; outline: none;"></a>Steps to reproduce</h2>
<p dir="auto" style="color: #333238; margin: 0 0 16px;" align="initial">On a system with a German locale, try</p>
<p dir="auto" style="color: #333238; margin: 0 0 16px;" align="initial">../source-builder/sb-set-builder <br style="margin-top: 0;">
--source-only-download <br>
devel/qemu-xilinx</p>
<h2 dir="auto" style="font-size: 1.5em; font-weight: 600; padding-bottom: .3em; border-bottom-width: 1px; border-bottom-color: #bfbfc3; border-bottom-style: solid; color: #333238; margin: 24px 0 16px;" align="initial">
<a href="#possible-solutions" aria-hidden="true" class="anchor" id="user-content-possible-solutions" style="margin-top: 0; float: left; margin-left: -20px; text-decoration: none; outline: none;"></a>Possible solutions</h2>
<p dir="auto" style="color: #333238; margin: 0 0 16px;" align="initial">I can think of multiple solutions:</p>
<ul dir="auto" style="text-align: initial; list-style-type: disc; margin: 0 0 16px; padding: 0;">
<li style="margin-top: 0; line-height: 1.6em; margin-left: 25px; padding-left: 3px;">Setting the locale to 'C' for all RSB applications using the python <code style='font-size: 90%; color: #1f1e24; word-wrap: break-word; background-color: #ececef; border-radius: .25rem; margin-top: 0; font-family: var(--default-mono-font, "GitLab Mono"),"JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; vertical-align: bottom; white-space: pre-wrap; overflow-wrap: break-word; word-break: keep-all; padding: 2px 4px;'>locale.setlocale(...)</code>. Problem is: I'm not sure whether that works on Windows. I didn't find any clear cross-platform solution.</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">Replacing the current git.py with the python git module. Most likely difficult due to dependencies.</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">Handle strings of all languages.</li>
</ul>
<p dir="auto" style="color: #333238; margin: 0;" align="initial">Any better ideas?</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #737278;">
—
<br>
<a href="https://gitlab.rtems.org/rtems/tools/rtems-source-builder/-/issues/32">View it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.rtems.org">gitlab.rtems.org</a>. <a href="https://gitlab.rtems.org/-/sent_notifications/4f5272625b19953aa33a5bb793f06f19/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.rtems.org/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.rtems.org/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Issue","url":"https://gitlab.rtems.org/rtems/tools/rtems-source-builder/-/issues/32"}}</script>
</p>
</div>
</body>
</html>