<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style='--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;'>
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px;
}
body {
font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style='font-size: inherit; -webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";'>
<div class="content">
<p class="details" style="font-style: italic; color: #737278;">
<a href="https://gitlab.rtems.org/AlessandroNardin">Alessandro Nardin</a> created an issue: <a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/issues/5132">#5132</a>
</p>
<div class="md" style="position: relative; z-index: 1; color: #28272d; word-wrap: break-word;">
<h2 dir="auto" style="font-size: 1.5em; font-weight: 600; padding-bottom: .3em; border-bottom-width: 1px; border-bottom-color: #bfbfc3; border-bottom-style: solid; color: #28272d; margin: 0 0 16px;" align="initial">
<a href="#summary" aria-hidden="true" class="anchor" id="user-content-summary" style="margin-top: 0; float: left; margin-left: -20px; text-decoration: none; outline: none;"></a>Summary</h2>
<p dir="auto" style="color: #28272d; margin: 0 0 16px;" align="initial">Coverity CID 1619695</p>
<p dir="auto" style="color: #28272d; margin: 0 0 16px;" align="initial">When an error occurs during lock initialization in rtems_aio_init(), the error is not handled and the code ends up accessing uninitialized memory.</p>
<div class="gl-relative markdown-code-block js-markdown-code" style="margin-bottom: 0;">
<pre class="code highlight js-syntax-highlight language-plaintext" v-pre="true" style='display: block; font-size: 14px; color: #28272d; line-height: 1.6em; overflow-x: auto; border-radius: .25rem; position: relative; font-family: "GitLab Mono","JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; margin: 0 0 16px; padding: 12px; border: 1px solid #dcdcde;'><code style='font-size: inherit; color: inherit; word-wrap: normal; word-break: keep-all; background-color: inherit; border-radius: .25rem; white-space: pre; margin-top: 0; font-family: "GitLab Mono","JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; vertical-align: bottom; overflow-wrap: normal; padding: unset;'><span id="LC1" class="line" lang="plaintext" style="margin-top: 0;">** CID 1619695: API usage errors (LOCK)</span>
<span id="LC2" class="line" lang="plaintext">/cpukit/posix/src/aio_misc.c: 153 in rtems_aio_init()</span>
<span id="LC3" class="line" lang="plaintext"></span>
<span id="LC4" class="line" lang="plaintext"></span>
<span id="LC5" class="line" lang="plaintext">________________________________________________________________________________________________________</span>
<span id="LC6" class="line" lang="plaintext">*** CID 1619695: API usage errors (LOCK)</span>
<span id="LC7" class="line" lang="plaintext">/cpukit/posix/src/aio_misc.c: 153 in rtems_aio_init()</span>
<span id="LC8" class="line" lang="plaintext">147 </span>
<span id="LC9" class="line" lang="plaintext">148 aio_request_queue.active_threads = 0;</span>
<span id="LC10" class="line" lang="plaintext">149 aio_request_queue.idle_threads = 0;</span>
<span id="LC11" class="line" lang="plaintext">150 atomic_init( &aio_request_queue.queued_requests, 0 );</span>
<span id="LC12" class="line" lang="plaintext">151 aio_request_queue.initialized = AIO_QUEUE_INITIALIZED;</span>
<span id="LC13" class="line" lang="plaintext">152 </span>
<span id="LC14" class="line" lang="plaintext">>>> CID 1619695: API usage errors (LOCK)</span>
<span id="LC15" class="line" lang="plaintext">>>> "pthread_mutex_unlock" uses "aio_request_queue.mutex" in an uninitialized state. [Note: The source code implementation of the function has been overridden by a builtin model.]</span>
<span id="LC16" class="line" lang="plaintext">153 pthread_mutex_unlock( &aio_request_queue.mutex );</span>
<span id="LC17" class="line" lang="plaintext">154 </span>
<span id="LC18" class="line" lang="plaintext">155 return result;</span>
<span id="LC19" class="line" lang="plaintext">156 }</span>
<span id="LC20" class="line" lang="plaintext">157 </span>
<span id="LC21" class="line" lang="plaintext">158 rtems_aio_request *init_write_req( struct aiocb* aiocbp )</span></code></pre>
<copy-code></copy-code>
</div>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #737278;">
—
<br>
<a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/issues/5132">View it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.rtems.org">gitlab.rtems.org</a>. <a href="https://gitlab.rtems.org/-/sent_notifications/cd8fd1d51415b75ac0fb24ea2fb7d0f6/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.rtems.org/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.rtems.org/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Issue","url":"https://gitlab.rtems.org/rtems/rtos/rtems/-/issues/5132"}}</script>
</p>
</div>
</body>
</html>