<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style='--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;'>
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px;
}
body {
font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style='font-size: inherit; -webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";'>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.rtems.org/ppisa">Pavel Pisa</a>
<a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/issues/5144#note_114603">commented</a>:
</p>
<div class="md" style="position: relative; z-index: 1; color: #28272d; word-wrap: break-word;">
<p dir="auto" style="color: #28272d; margin: 0 0 16px;" align="initial">I have tried to add RISCV into libdl build, see patch <a href="https://gitlab.rtems.org/-/project/26/uploads/63d605e3d813fb1adff20b2452c544fd/libdl-riscv.diff" data-canonical-src="/uploads/63d605e3d813fb1adff20b2452c544fd/libdl-riscv.diff" data-link="true" class="gfm" style="margin-top: 0;">libdl-riscv.diff</a>, but there are more warnings</p>
<div class="gl-relative markdown-code-block js-markdown-code">
<pre class="code highlight js-syntax-highlight language-plaintext" v-pre="true" style='display: block; font-size: 14px; color: #28272d; line-height: 1.6em; overflow-x: auto; border-radius: .25rem; position: relative; font-family: "GitLab Mono","JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; margin: 0 0 16px; padding: 12px; border: 1px solid #dcdcde;'><code style='font-size: inherit; color: inherit; word-wrap: normal; word-break: keep-all; background-color: inherit; border-radius: .25rem; white-space: pre; margin-top: 0; font-family: "GitLab Mono","JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; vertical-align: bottom; overflow-wrap: normal; padding: unset;'><span id="LC1" class="line" lang="plaintext" style="margin-top: 0;">../../../../../git/rtems/cpukit/libdl/rtl-mdreloc-riscv.c: In function 'rtems_rtl_elf_reloc_rela':</span>
<span id="LC2" class="line" lang="plaintext">../../../../../git/rtems/cpukit/libdl/rtl-mdreloc-riscv.c:169:9: warning: assignment to 'Elf64_Word *' {aka 'unsigned int *'} from incompatible pointer type 'Elf64_Addr *' {aka 'long unsigned int *'} [-Wincompatible-pointer-types]</span>
<span id="LC3" class="line" lang="plaintext"> 169 | where = (Elf_Addr *)(sect->base + rela->r_offset);</span>
<span id="LC4" class="line" lang="plaintext"> | ^</span>
<span id="LC5" class="line" lang="plaintext">../../../../../git/rtems/cpukit/libdl/rtl-mdreloc-riscv.c:172:36: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]</span>
<span id="LC6" class="line" lang="plaintext"> 172 | Elf_Word pcrel_val = symvalue - ((Elf_Word) where);</span>
<span id="LC7" class="line" lang="plaintext"> | ^</span>
<span id="LC8" class="line" lang="plaintext">../../../../../git/rtems/cpukit/libdl/rtl-mdreloc-riscv.c:307:15: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]</span>
<span id="LC9" class="line" lang="plaintext"> 307 | (void *) * (where), where, rtems_rtl_obj_oname (obj));</span>
<span id="LC10" class="line" lang="plaintext"> | ^</span>
<span id="LC11" class="line" lang="plaintext">../../../../../git/rtems/cpukit/libdl/rtl-mdreloc-riscv.c:374:61: warning: format '%ld' expects argument of type 'long int', but argument 4 has type 'unsigned int' [-Wformat=]</span>
<span id="LC12" class="line" lang="plaintext"> 374 | "%s: Unsupported relocation type %ld "</span>
<span id="LC13" class="line" lang="plaintext"> | ~~^</span>
<span id="LC14" class="line" lang="plaintext"> | |</span>
<span id="LC15" class="line" lang="plaintext"> | long int</span>
<span id="LC16" class="line" lang="plaintext"> | %d</span>
<span id="LC17" class="line" lang="plaintext">../../../../../git/rtems/cpukit/libdl/rtl-mdreloc-riscv.c:166:12: warning: variable 'local' set but not used [-Wunused-but-set-variable]</span>
<span id="LC18" class="line" lang="plaintext"> 166 | Elf_Word local = 0;</span>
<span id="LC19" class="line" lang="plaintext"> | ^~~~~</span>
<span id="LC20" class="line" lang="plaintext">../../../../../git/rtems/cpukit/libdl/rtl-mdreloc-riscv.c:165:12: warning: unused variable 'addend' [-Wunused-variable]</span>
<span id="LC21" class="line" lang="plaintext"> 165 | Elf_Word addend = (Elf_Word) rela->r_addend;</span>
<span id="LC22" class="line" lang="plaintext"> | ^~~~~~</span>
<span id="LC23" class="line" lang="plaintext">../../../../../git/rtems/cpukit/libdl/rtl-mdreloc-riscv.c:164:13: warning: unused variable 'tmp' [-Wunused-variable]</span>
<span id="LC24" class="line" lang="plaintext"> 164 | Elf_Word tmp;</span>
<span id="LC25" class="line" lang="plaintext"> | ^~~</span></code></pre>
<copy-code></copy-code><insert-code-snippet></insert-code-snippet>
</div>
<p dir="auto" style="color: #28272d; margin: 0 0 16px;" align="initial">I try to analyze what is right, but it would need real testing to be sure that there is not something missed.</p>
<p dir="auto" style="color: #28272d; margin: 0 0 16px;" align="initial">I am curious even about <code style='font-size: 90%; color: #18171d; word-wrap: break-word; background-color: #ececef; border-radius: .25rem; margin-top: 0; font-weight: inherit; font-family: "GitLab Mono","JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; vertical-align: bottom; white-space: pre-wrap; overflow-wrap: break-word; word-break: keep-all; padding: 2px 4px;'>libdl</code> for x86_64, because that architecture is missing in <code style='font-size: 90%; color: #18171d; word-wrap: break-word; background-color: #ececef; border-radius: .25rem; font-weight: inherit; font-family: "GitLab Mono","JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; vertical-align: bottom; white-space: pre-wrap; overflow-wrap: break-word; word-break: keep-all; padding: 2px 4px;'>cpukit/libdl/rtl-elf.h</code> to select 64-bit <code style='font-size: 90%; color: #18171d; word-wrap: break-word; background-color: #ececef; border-radius: .25rem; font-weight: inherit; font-family: "GitLab Mono","JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; vertical-align: bottom; white-space: pre-wrap; overflow-wrap: break-word; word-break: keep-all; padding: 2px 4px;'>ELFSIZE</code></p>
<div class="gl-relative markdown-code-block js-markdown-code" style="margin-bottom: 0;">
<pre class="code highlight js-syntax-highlight language-plaintext" v-pre="true" style='display: block; font-size: 14px; color: #28272d; line-height: 1.6em; overflow-x: auto; border-radius: .25rem; position: relative; font-family: "GitLab Mono","JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; margin: 0 0 16px; padding: 12px; border: 1px solid #dcdcde;'><code style='font-size: inherit; color: inherit; word-wrap: normal; word-break: keep-all; background-color: inherit; border-radius: .25rem; white-space: pre; margin-top: 0; font-family: "GitLab Mono","JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; vertical-align: bottom; overflow-wrap: normal; padding: unset;'><span id="LC1" class="line" lang="plaintext" style="margin-top: 0;">#if defined(__powerpc64__) || defined(__aarch64__) || (__riscv_xlen == 64)</span>
<span id="LC2" class="line" lang="plaintext">#define ELFSIZE 64</span>
<span id="LC3" class="line" lang="plaintext">#else</span>
<span id="LC4" class="line" lang="plaintext">#define ELFSIZE 32</span>
<span id="LC5" class="line" lang="plaintext">#endif</span></code></pre>
<copy-code></copy-code><insert-code-snippet></insert-code-snippet>
</div>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #737278;">
—
<br>
<a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/issues/5144#note_114603">View it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.rtems.org">gitlab.rtems.org</a>. <a href="https://gitlab.rtems.org/-/sent_notifications/fb22d0fb14e0cab57f6346e94c3c28b8/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.rtems.org/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.rtems.org/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Issue","url":"https://gitlab.rtems.org/rtems/rtos/rtems/-/issues/5144#note_114603"}}</script>
</p>
</div>
</body>
</html>