<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style='--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;'>
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px;
}
body {
font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style='font-size: inherit; -webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";'>
<div class="content">
<p class="details" style="font-style: italic; color: #737278;">
<a href="https://gitlab.rtems.org/joel">Joel Sherrill</a> created an issue: <a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/issues/5239">#5239</a>
</p>
<p>
Assignee: Joel Sherrill
</p>
<div class="md" style="position: relative; z-index: 1; color: #28272d; word-wrap: break-word;">
<h2 dir="auto" style="font-size: 1.5em; font-weight: 600; padding-bottom: .3em; border-bottom-width: 1px; border-bottom-color: #bfbfc3; border-bottom-style: solid; color: #28272d; margin: 0 0 16px;" align="initial">
<a href="#summary" aria-hidden="true" class="anchor" id="user-content-summary" style="margin-top: 0; float: left; margin-left: -20px; text-decoration: none; outline: none;"></a>Summary</h2>
<p dir="auto" style="color: #28272d; margin: 0 0 16px;" align="initial">When building many/most/all BSPs, the following warning is present. <a href="https://gitlab.rtems.org/opticron" data-reference-type="user" data-user="4" data-container="body" data-placement="top" class="gfm gfm-project_member js-user-link" title="Kinsey Moore" style="color: #0b5cad; background-color: #cbe2f9; border-radius: .25rem; margin-top: 0; padding: 0 2px;">@opticron</a> and I have investigated this before and assumed that it was an artefact of an inline helper not initialising all fields when not debug. GCC 14 gives a more thorough diagnostic and <a href="https://gitlab.rtems.org/opticron" data-reference-type="user" data-user="4" data-container="body" data-placement="top" class="gfm gfm-project_member js-user-link" title="Kinsey Moore" style="color: #0b5cad; background-color: #cbe2f9; border-radius: .25rem; padding: 0 2px;">@opticron</a> had the insight that the function in psignalclearsignals.c includes a test of a boolean argument indicating whether the signal clearing logic is executed inside a critical section or not. For some reason, GCC sees a path where the unlock could be called without the lock being called. Using the source on the 6 branch as a reference, this is the <a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/blame/6/cpukit/posix/src/psignalclearsignals.c?ref_type=heads#L87">locking conditional</a> and this is the <a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/blame/6/cpukit/posix/src/psignalclearsignals.c?ref_type=heads#L122">unlocking conditional</a>.</p>
<p dir="auto" style="color: #28272d; margin: 0 0 16px;" align="initial">The solution was to refactor the code inside the lock/unlock into a helper method so the expression checking if locking was needed is only tested once.</p>
<div class="gl-relative markdown-code-block js-markdown-code">
<pre class="code highlight js-syntax-highlight language-plaintext" v-pre="true" style='display: block; font-size: 14px; color: #28272d; line-height: 1.6em; overflow-x: auto; border-radius: .25rem; position: relative; font-family: "GitLab Mono","JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; margin: 0 0 16px; padding: 12px; border: 1px solid #dcdcde;'><code style='font-size: inherit; color: inherit; word-wrap: normal; word-break: keep-all; background-color: inherit; border-radius: .25rem; white-space: pre; margin-top: 0; font-family: "GitLab Mono","JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; vertical-align: bottom; overflow-wrap: normal; padding: unset;'><span id="LC1" class="line" lang="plaintext" style="margin-top: 0;">In file included from ../../../cpukit/include/rtems/score/isrlevel.h:43,</span>
<span id="LC2" class="line" lang="plaintext"> from ../../../cpukit/include/rtems/score/isr.h:41,</span>
<span id="LC3" class="line" lang="plaintext"> from ../../../cpukit/posix/src/psignalclearsignals.c:45:</span>
<span id="LC4" class="line" lang="plaintext">In function 'arm_interrupt_enable',</span>
<span id="LC5" class="line" lang="plaintext"> inlined from '_Thread_queue_Release' at ../../../cpukit/include/rtems/score/threadqimpl.h:829:3,</span>
<span id="LC6" class="line" lang="plaintext"> inlined from '_POSIX_signals_Release' at ../../../cpukit/include/rtems/posix/psignalimpl.h:106:3,</span>
<span id="LC7" class="line" lang="plaintext"> inlined from '_POSIX_signals_Clear_signals' at ../../../cpukit/posix/src/psignalclearsignals.c:123:5:</span>
<span id="LC8" class="line" lang="plaintext">../../../cpukit/score/cpu/arm/include/rtems/score/cpu.h:357:3: warning: 'queue_context.Lock_context.Lock_context.isr_level' may be used uninitialized [-Wmaybe-uninitialized]</span>
<span id="LC9" class="line" lang="plaintext"> 357 | __asm__ volatile (</span>
<span id="LC10" class="line" lang="plaintext"> | ^~~~~~~</span>
<span id="LC11" class="line" lang="plaintext">../../../cpukit/posix/src/psignalclearsignals.c: In function '_POSIX_signals_Clear_signals':</span>
<span id="LC12" class="line" lang="plaintext">../../../cpukit/posix/src/psignalclearsignals.c:67:31: note: 'queue_context.Lock_context.Lock_context.isr_level' was declared here</span>
<span id="LC13" class="line" lang="plaintext"> 67 | Thread_queue_Context queue_context;</span>
<span id="LC14" class="line" lang="plaintext"> | ^~~~~~~~~~~~~</span></code></pre>
<copy-code></copy-code><insert-code-snippet></insert-code-snippet>
</div>
<p dir="auto" style="color: #28272d; margin: 0 0 16px;" align="initial">NOTE: This may indicate that GCC was doing some of the path analysis incorrectly. A gcc ticket will be filed also.</p>
<h2 dir="auto" style="font-size: 1.5em; font-weight: 600; padding-bottom: .3em; border-bottom-width: 1px; border-bottom-color: #bfbfc3; border-bottom-style: solid; color: #28272d; margin: 24px 0 16px;" align="initial">
<a href="#steps-to-reproduce" aria-hidden="true" class="anchor" id="user-content-steps-to-reproduce" style="margin-top: 0; float: left; margin-left: -20px; text-decoration: none; outline: none;"></a>Steps to reproduce</h2>
<h3 dir="auto" style="font-size: 1.3em; margin: 24px 0 0;" align="initial">
<a href="#pre-set-options" aria-hidden="true" class="anchor" id="user-content-pre-set-options" style="margin-top: 0; float: left; margin-left: -20px; text-decoration: none; outline: none;"></a>Pre-set options</h3>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #737278;">
—
<br>
<a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/issues/5239">View it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.rtems.org">gitlab.rtems.org</a>. <a href="https://gitlab.rtems.org/-/sent_notifications/066782c316af6464b630dc0091e150cc/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.rtems.org/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.rtems.org/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Issue","url":"https://gitlab.rtems.org/rtems/rtos/rtems/-/issues/5239"}}</script>
</p>
</div>
</body>
</html>