<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style='--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;'>
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px;
}
body {
font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style='font-size: inherit; -webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";'>
<div class="content">
<p class="details" style="font-style: italic; color: #737278;">
<a href="https://gitlab.rtems.org/joel">Joel Sherrill</a> created an issue: <a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/issues/5267">#5267</a>
</p>
<p>
Assignee: Joel Sherrill
</p>
<div class="md" style="position: relative; z-index: 1; color: #28272d; word-wrap: break-word;">
<h2 dir="auto" style="font-size: 1.5em; font-weight: 600; padding-bottom: .3em; border-bottom-width: 1px; border-bottom-color: #bfbfc3; border-bottom-style: solid; color: #28272d; margin: 0 0 16px;" align="initial">
<a href="#summary" aria-hidden="true" class="anchor" id="user-content-summary" style="margin-top: 0; float: left; margin-left: -20px; text-decoration: none; outline: none;"></a>Summary</h2>
<p dir="auto" style="color: #28272d; margin: 0 0 16px;" align="initial">With GCC 14, it is not explicitly clear that GCC does not have the required atomics helper for older cores without atomic instructions. I first spotted this on the <a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/issues/5230" data-reference-type="issue" data-original="uC5282" data-link="true" data-link-reference="true" data-issue="29002" data-project="26" data-iid="5230" data-namespace-path="rtems/rtos/rtems" data-project-path="rtems/rtos/rtems" data-issue-type="issue" data-container="body" data-placement="top" title="Add support for std::atomic on Coldfire ISA A (uC5282 std::atomic_flag link error)" class="gfm gfm-issue" style="margin-top: 0;">uC5282</a> but we did not realise this was a pervasive problem with over 30 BSPs across 7 target architectures. The error generated is when linking <code style='font-size: 90%; color: #18171d; word-wrap: break-word; background-color: #ececef; border-radius: .25rem; font-weight: inherit; font-family: "GitLab Mono","JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; vertical-align: bottom; white-space: pre-wrap; overflow-wrap: break-word; word-break: keep-all; padding: 2px 4px;'>spcxx01</code>:</p>
<div class="gl-relative markdown-code-block js-markdown-code">
<pre class="code highlight js-syntax-highlight language-plaintext" v-pre="true" style='display: block; font-size: 14px; color: #28272d; line-height: 1.6em; overflow-x: auto; border-radius: .25rem; position: relative; font-family: "GitLab Mono","JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; margin: 0 0 16px; padding: 12px; border: 1px solid #dcdcde;'><code style='font-size: inherit; color: inherit; word-wrap: normal; word-break: keep-all; background-color: inherit; border-radius: .25rem; white-space: pre; margin-top: 0; font-family: "GitLab Mono","JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; vertical-align: bottom; overflow-wrap: normal; padding: unset;'><span id="LC1" class="line" lang="plaintext" style="margin-top: 0;">[4381/4381] Linking build/arm/rtl22xx/testsuites/samples/paranoia.exe</span>
<span id="LC2" class="line" lang="plaintext">/home/joel/rtems-work/tools/next-gcc14/bin/../lib/gcc/arm-rtems7/14.3.0/../../../../arm-rtems7/bin/ld: testsuites/sptests/spcxx01/init.cc.707.o: in function `std::atomic_flag::test_and_set(std::memory_order)':</span>
<span id="LC3" class="line" lang="plaintext">/home/joel/rtems-work/tools/next-gcc14/lib/gcc/arm-rtems7/14.3.0/include/c++/bits/atomic_base.h:226:(.text.Init+0x1b0): undefined reference to `__atomic_test_and_set' </span></code></pre>
<copy-code></copy-code><insert-code-snippet></insert-code-snippet>
</div>
<p dir="auto" style="color: #28272d; margin: 0 0 16px;" align="initial"><a href="https://gitlab.rtems.org/opticron" data-reference-type="user" data-user="4" data-container="body" data-placement="top" class="gfm gfm-project_member js-user-link" title="Kinsey Moore" style="color: #0b5cad; background-color: #cbe2f9; border-radius: .25rem; margin-top: 0; padding: 0 2px;">@opticron</a> suggested that it did not matter where this routine was implemented, only that it was available when compiling for that BSP. This undefined function (__<em>atomic_test_and_set</em>) has a well defined <a href="https://gcc.gnu.org/onlinedocs/gcc/_005f_005fatomic-Builtins.html" rel="nofollow noreferrer noopener" target="_blank">interface</a>. Providing this for the impacted BSPs is straightforward. The function is small and it only needs to be added to the YAML files for the BSP variants impacted.</p>
<p dir="auto" style="color: #28272d; margin: 0 0 16px;" align="initial">This is the list of BSPs impacted:</p>
<ul dir="auto" style="text-align: initial; list-style-type: disc; margin: 0 0 16px; padding: 0;">
<li style="margin-top: 0; line-height: 1.6em; margin-left: 25px; padding-left: 3px;">arm - csb336, csb337, csb637, edb7312, gumstix, kit637_v6, lpc24xx_ea, lpc24xx_ncs_ram, lpc24xx_ncs_rom_ext, lpc24xx_ncs_rom_int, lpc24xx_plx800_ram, lpc24xx_plx800_rom_int, lpc32xx_mzx, lpc32xx_mzx_stage_1, lpc32xx_mzx_stage_2, lpc32xx_phycore, rtl22xx, rtl22xx_t, smdk2410</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">m68k - av5282, mcf5329</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">mips - jmr3904</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">moxie - moxiesim</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">nios2 - nios2_iss</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">riscv - grv32i, grv32im, niosvc10lp, noel32im, rv32i, rv32im,</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">sparc - ut699</li>
</ul>
<p dir="auto" style="color: #28272d; margin: 0 0 16px;" align="initial">Some of these are likely candidates for deprecation in 7. But this issue should not be the only factor in that decision. It seems obvious that the RISC-V and SPARC BSPs listed are unlikely candidates for removal.</p>
<p dir="auto" style="color: #28272d; margin: 0 0 16px;" align="initial"><a href="https://gitlab.rtems.org/opticron" data-reference-type="user" data-user="4" data-container="body" data-placement="top" class="gfm gfm-project_member js-user-link" title="Kinsey Moore" style="color: #0b5cad; background-color: #cbe2f9; border-radius: .25rem; margin-top: 0; padding: 0 2px;">@opticron</a> and I compiled this list of impacted cores/ISAs found in the above BSPs:</p>
<ul dir="auto" style="text-align: initial; list-style-type: disc; margin: 0 0 16px; padding: 0;">
<li style="margin-top: 0; line-height: 1.6em; margin-left: 25px; padding-left: 3px;">ARM: arm920, arm920t, arm7tdmi, arm7tdmi-s, xscale, arm926ej-s</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">m68k: Coldfire ISA A</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">MIPS: arch=3900</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">Moxie: only one</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">NIOS2: only one</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">RISC-V: multiple single core (non-SMP)</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">SPARC: ut699</li>
</ul>
<h3 dir="auto" style="font-size: 1.3em; margin: 24px 0 0;" align="initial">
<a href="#pre-set-options" aria-hidden="true" class="anchor" id="user-content-pre-set-options" style="margin-top: 0; float: left; margin-left: -20px; text-decoration: none; outline: none;"></a>Pre-set options</h3>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #737278;">
—
<br>
<a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/issues/5267">View it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.rtems.org">gitlab.rtems.org</a>. <a href="https://gitlab.rtems.org/-/sent_notifications/c24fd33d44acbe024614c3fc7057ac15/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.rtems.org/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.rtems.org/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Issue","url":"https://gitlab.rtems.org/rtems/rtos/rtems/-/issues/5267"}}</script>
</p>
</div>
</body>
</html>