<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style='--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;'>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px;
}
body {
font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style='font-size: inherit; -webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";'>
<div class="content">
<div style="color: #333333; border-bottom-width: 8px; border-bottom-color: #ededed; border-bottom-style: solid; font-weight: bold; line-height: 1.4; padding: 20px 0;">
Merge request <a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/371">!371</a> was reviewed by <a href="https://gitlab.rtems.org/chris">Chris Johns</a>
</div>
<p style="color: #777777;">
<a href="https://gitlab.rtems.org/chris">Chris Johns</a>
commented on a
<a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/371#note_127191">discussion</a>:
</p>
<div class="md" style="border-bottom-width: 4px; border-bottom-color: #ededed; border-bottom-style: solid; padding-bottom: 1em; position: relative; z-index: 1; color: #3a383f; word-wrap: break-word;">
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">Please check <a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/619" data-reference-type="merge_request" data-original="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/619" data-link="false" data-link-reference="true" data-merge-request="1466" data-project="26" data-project-path="rtems/rtos/rtems" data-iid="619" data-container="body" data-placement="top" title="libcsupport/termios: Wake receiver when ICANON settings change" class="gfm gfm-merge_request" style="margin-top: 0;">!619</a> and what I found here. Termios will block and stay blocked in the reader with the shell termios settings we have. I found there is little you can without With this change you can alter the telnet pty code with something like:</p>
<div class="gl-relative markdown-code-block js-markdown-code">
<pre data-canonical-lang="cpp" class="code highlight js-syntax-highlight language-cpp" v-pre="true" style='display: block; font-size: 14px; color: #3a383f; line-height: 1.6em; overflow-x: auto; border-radius: .25rem; position: relative; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; margin: 0 0 1rem; padding: 12px; border: 1px solid #dcdcde;'><code style='font-size: inherit; color: inherit; word-wrap: normal; word-break: keep-all; border-radius: .25rem; background-color: inherit; white-space: pre; margin-top: 0; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; overflow-wrap: normal; padding: unset;'><span id="LC1" class="line" lang="cpp" style="margin-top: 0;"><span class="kt" style="margin-top: 0;">void</span> <span class="nf">wake_console</span><span class="p">()</span> <span class="p">{</span></span>
<span id="LC2" class="line" lang="cpp"> <span class="k" style="margin-top: 0;">struct</span> <span class="nc">termios</span> <span class="n">term</span><span class="p">;</span></span>
<span id="LC3" class="line" lang="cpp"> <span class="k" style="margin-top: 0;">if</span> <span class="p">(</span><span class="n">tcgetattr</span><span class="p">(</span><span class="n">console_fd</span><span class="p">,</span> <span class="o">&</span><span class="n">term</span><span class="p">)</span> <span class="o">==</span> <span class="mi">0</span><span class="p">)</span> <span class="p">{</span></span>
<span id="LC4" class="line" lang="cpp"> <span class="n" style="margin-top: 0;">term</span><span class="p">.</span><span class="n">c_cc</span><span class="p">[</span><span class="n">VMIN</span><span class="p">]</span> <span class="o">=</span> <span class="mi">0</span><span class="p">;</span></span>
<span id="LC5" class="line" lang="cpp"> <span class="n" style="margin-top: 0;">term</span><span class="p">.</span><span class="n">c_cc</span><span class="p">[</span><span class="n">VTIME</span><span class="p">]</span> <span class="o">=</span> <span class="mi">0</span><span class="p">;</span></span>
<span id="LC6" class="line" lang="cpp"> <span class="k" style="margin-top: 0;">if</span> <span class="p">(</span><span class="n">tcsetattr</span><span class="p">(</span><span class="n">console_fd</span><span class="p">,</span> <span class="n">TCSANOW</span><span class="p">,</span> <span class="o">&</span><span class="n">term</span><span class="p">)</span> <span class="o">!=</span> <span class="mi">0</span><span class="p">)</span> <span class="p">{</span></span>
<span id="LC7" class="line" lang="cpp"> <span class="n" style="margin-top: 0;">std</span><span class="o">::</span><span class="n">cout</span> <span class="o"><<</span> <span class="s">"shell: wake-console: stdin: cannot set cterm"</span></span>
<span id="LC8" class="line" lang="cpp"> <span class="o" style="margin-top: 0;"><<</span> <span class="n">std</span><span class="o">::</span><span class="n">endl</span><span class="p">;</span></span>
<span id="LC9" class="line" lang="cpp"> <span class="p" style="margin-top: 0;">}</span></span>
<span id="LC10" class="line" lang="cpp"> <span class="p" style="margin-top: 0;">}</span> <span class="k">else</span> <span class="p">{</span></span>
<span id="LC11" class="line" lang="cpp"> <span class="n" style="margin-top: 0;">std</span><span class="o">::</span><span class="n">cout</span> <span class="o"><<</span> <span class="s">"shell: wake-console: stdin: cannot get cterm"</span></span>
<span id="LC12" class="line" lang="cpp"> <span class="o" style="margin-top: 0;"><<</span> <span class="n">std</span><span class="o">::</span><span class="n">endl</span><span class="p">;</span></span>
<span id="LC13" class="line" lang="cpp"> <span class="p" style="margin-top: 0;">}</span></span>
<span id="LC14" class="line" lang="cpp"><span class="p" style="margin-top: 0;">}</span></span></code></pre>
<copy-code></copy-code><insert-code-snippet></insert-code-snippet>
</div>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">I have have this code when rebooting from a websocket shell session.</p>
<p dir="auto" style="color: #3a383f; margin: 0;" align="initial">I think this change breaks the shell functionality.</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #626168;">
—
<br>
<a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/371">View it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.rtems.org">gitlab.rtems.org</a>. <a href="https://gitlab.rtems.org/-/sent_notifications/f6919093454b900b791552e2fb9088ea/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.rtems.org/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.rtems.org/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<span style="color: transparent; font-size: 0; display: none; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0;">
Notification message regarding https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/371 at 1753383843
</span>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/371"}}</script>
</p>
</div>
</body>
</html>