<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style='--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;'>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px;
}
body {
font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style='font-size: inherit; -webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";'>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.rtems.org/wmthornton-dev">Wayne Thornton</a>
commented on a
<a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/674#note_128958">discussion</a>:
</p>
<div class="md" style="position: relative; z-index: 1; color: #3a383f; word-wrap: break-word;">
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">Thank you for the insight. I was able to review issue <a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/issues/33" data-reference-type="issue" data-original="rtems#33" data-link="false" data-link-reference="false" data-issue="25728" data-project="26" data-iid="33" data-namespace-path="rtems/rtos/rtems" data-project-path="rtems/rtos/rtems" data-issue-type="issue" data-container="body" data-placement="top" title="--disable-inlines fails on snapshots" class="gfm gfm-issue" style="margin-top: 0;">#33 (closed)</a> and now have a handle on what exactly is being discussed. I'd agree with <a href="https://gitlab.rtems.org/joel" data-reference-type="user" data-user="7" data-container="body" data-placement="top" class="gfm gfm-project_member js-user-link" title="Joel Sherrill" style="color: #284779; background-color: #cbe2f9; border-radius: .25rem; padding: 0 2px;">@joel</a> that it may be simpler to pull down the code from the FreeBSD repositories, although the updated FreeBSD files contain a lot of code not utilized here. It would make more sense (to me, as the outsider) to own the code as RTEMS' codebase and to make the modifications necessary to remove FreeBSD-specific references and defines in the file. My understanding vis-a-vis the issue regarding modification of 3rd-party code is that it is allowed by virtue of the BSD-2-Clause license being employed so long as the original copyright notice is retained and the file is not re-licensed under a different license. As the documentation for licensing found here: <a href="https://docs.rtems.org/docs/main/eng/license-requirements.html" rel="nofollow noreferrer noopener" target="_blank">https://docs.rtems.org/docs/main/eng/license-requirements.html</a> states, this license is preferred by the project so modifying shouldn't be an issue.</p>
<p dir="auto" style="color: #3a383f; margin: 0;" align="initial">On a more direct note, should the project decide to own the code, I would be willing to become the codeowner for telnetd subsystem and take responsibility for these changes moving forward. Although this MR constitutes my first contribution to the project, and they are relatively minor contributions, that is the result of my seeking to find a project to join and start with simple, easy to digest commits as I learn the intricacies of how the project works and the processes in place for developers.</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #626168;">
—
<br>
<a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/674#note_128958">View it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.rtems.org">gitlab.rtems.org</a>. <a href="https://gitlab.rtems.org/-/sent_notifications/eb20678d8a5e3568db073aafcffa61fe/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.rtems.org/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.rtems.org/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<span style="color: transparent; font-size: 0; display: none; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0;">
Notification message regarding https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/674#note_128958 at 1755552794
</span>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/674#note_128958"}}</script>
</p>
</div>
</body>
</html>