<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style='--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;'>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px;
}
body {
font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style='font-size: inherit; -webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";'>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.rtems.org/joel">Joel Sherrill</a>
commented on a
<a href="https://gitlab.rtems.org/rtems/prequal/rtems-central/-/merge_requests/12#note_134889">discussion</a>:
</p>
<div class="md" style="position: relative; z-index: 1; color: #3a383f; word-wrap: break-word;">
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">Thanks for implying my time is being wasted.</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">Fixing warnings and being able to turn on -Werror is a conscious effort to improve code quality and catch issues in newly submitted code before it gets to us.</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">I saved this summary count from September 3:</p>
<blockquote dir="auto" style="font-size: inherit; color: #626168; padding-top: 0.5rem; padding-bottom: 0.5rem; padding-left: 1rem; border-left-style: solid; margin: 0.5rem 0; border-color: #bfbfc3; border-width: 0 0 0 4px;" align="initial">
<div class="gl-relative markdown-code-block js-markdown-code" style="margin-top: 0;">
<pre class="code highlight js-syntax-highlight language-plaintext" v-pre="true" style='display: block; font-size: 14px; color: #3a383f; line-height: 1.6em; overflow-x: auto; border-radius: .25rem; position: relative; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; margin: 0 0 1rem; padding: 12px; border: 1px solid #dcdcde;'><code style='font-size: inherit; color: inherit; word-wrap: normal; word-break: keep-all; border-radius: .25rem; background-color: inherit; white-space: pre; margin-top: 0; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; overflow-wrap: normal; padding: unset;'><span id="LC1" class="line" lang="plaintext" style="margin-top: 0;"> 1 -Wexpansion-to-defined</span>
<span id="LC2" class="line" lang="plaintext"> 3 -Wcalloc-transposed-args</span>
<span id="LC3" class="line" lang="plaintext"> 3 -Wempty-body</span>
<span id="LC4" class="line" lang="plaintext"> 4 -Wabsolute-value</span>
<span id="LC5" class="line" lang="plaintext"> 4 -Wshift-negative-value</span>
<span id="LC6" class="line" lang="plaintext"> 7 -Wenum-conversion</span>
<span id="LC7" class="line" lang="plaintext"> 8 -Wignored-qualifiers</span>
<span id="LC8" class="line" lang="plaintext"> 13 -Wclobbered</span>
<span id="LC9" class="line" lang="plaintext"> 23 -Wcast-function-type</span>
<span id="LC10" class="line" lang="plaintext"> 32 -Wold-style-declaration</span>
<span id="LC11" class="line" lang="plaintext"> 66 -Wimplicit-fallthrough=</span>
<span id="LC12" class="line" lang="plaintext"> 70 -Wtype-limits</span>
<span id="LC13" class="line" lang="plaintext">139 -Wmissing-field-initializers</span>
<span id="LC14" class="line" lang="plaintext">273 -Wunterminated-string-initialization</span>
<span id="LC15" class="line" lang="plaintext">842 -Wsign-compare</span></code></pre>
<copy-code></copy-code><insert-code-snippet></insert-code-snippet>
</div>
<p style="color: inherit; line-height: 1.5; margin: 0;">3679 -Wunused-parameter</p>
</blockquote>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">Most of those warning classes have been eliminated. I expect the remaining to be harder and more likely to be real issues. Currently, I am working on <em style="margin-top: 0;">-Wmissing-field-initializers</em> but have disabled the following until me or someone else can look at them. I suspect most of these are going to be fixes that are specific to the code cited rather than application of a pattern.</p>
<ul dir="auto" style="text-align: initial; list-style-type: disc; margin: 0 0 1rem; padding: 0;">
<li style="margin-top: 0; line-height: 1.6em; margin-left: 25px; padding-left: 3px;">
<ul style="list-style-type: circle; margin: 0; padding: 0;">
<li style="margin-top: 0; line-height: 1.6em; margin-left: 25px; padding-left: 3px;">-Wno-cast-function-type</li>
</ul>
</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">
<ul style="list-style-type: circle; margin: 0; padding: 0;">
<li style="margin-top: 0; line-height: 1.6em; margin-left: 25px; padding-left: 3px;">-Wno-enum-conversion</li>
</ul>
</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">
<ul style="list-style-type: circle; margin: 0; padding: 0;">
<li style="margin-top: 0; line-height: 1.6em; margin-left: 25px; padding-left: 3px;">-Wno-shift-negative-value</li>
</ul>
</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">
<ul style="list-style-type: circle; margin: 0; padding: 0;">
<li style="margin-top: 0; line-height: 1.6em; margin-left: 25px; padding-left: 3px;">-Wno-type-limits</li>
</ul>
</li>
</ul>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">Along the way of fixing the warnings, about 30 Coverity issues have disappeared. This is important and fixing issues, use of undefined code sequence, etc..</p>
<p dir="auto" style="color: #3a383f; margin: 0;" align="initial">And this will leave us in a good position for -Werror to catch questionable submissions.</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #626168;">
—
<br>
<a href="https://gitlab.rtems.org/rtems/prequal/rtems-central/-/merge_requests/12#note_134889">View it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.rtems.org">gitlab.rtems.org</a>. <a href="https://gitlab.rtems.org/-/sent_notifications/6876372370a837b5848a9cce96762746/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.rtems.org/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.rtems.org/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<span style="color: transparent; font-size: 0; display: none; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0;">
Notification message regarding https://gitlab.rtems.org/rtems/prequal/rtems-central/-/merge_requests/12#note_134889 at 1760363899
</span>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.rtems.org/rtems/prequal/rtems-central/-/merge_requests/12#note_134889"}}</script>
</p>
</div>
</body>
</html>