<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style='--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;'>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px;
}
body {
font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style='font-size: inherit; -webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";'>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.rtems.org/joel">Joel Sherrill</a>
commented on a
<a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/867#note_137069">discussion</a>:
</p>
<div class="md" style="position: relative; z-index: 1; color: #3a383f; word-wrap: break-word;">
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial"><a href="https://gitlab.rtems.org/gedare" data-reference-type="user" data-user="8" data-container="body" data-placement="top" class="gfm gfm-project_member js-user-link" title="Gedare Bloom" style="color: #284779; background-color: #cbe2f9; border-radius: .25rem; margin-top: 0; padding: 0 2px;">@gedare</a> It was introduced by this <a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/commit/ff63275812938aa7b4bda1f9197079de9522cc5b" data-reference-type="commit" data-original="change" data-link="true" data-link-reference="true" data-commit="ff63275812938aa7b4bda1f9197079de9522cc5b" data-project="26" data-container="body" data-placement="top" title="cpukit/posix: Add timespec_get() support to RTEMS" class="gfm gfm-commit has-tooltip" style='font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; font-size: 95%;'>change</a> which was committed three days ago. Before that I think it was OK.</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">Also <em style="margin-top: 0;">rtems-bsp-builder</em> does not build tests and would have missed this. It cycles cpukit/ and bsps/ through lots of configurations.</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">The problem is ultimately that we do not build any RTEMS code in the CI. Any build of any configuration of a BSP with tests would have caught this.</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">Personally, I might have caught this like <a href="https://gitlab.rtems.org/yang.zhang" data-reference-type="user" data-user="105" data-container="body" data-placement="top" class="gfm gfm-project_member js-user-link" title="yang zhang" style="color: #284779; background-color: #cbe2f9; border-radius: .25rem; margin-top: 0; padding: 0 2px;">@yang.zhang</a> did but I had not updated my source tree and done a build sweep yet this week.</p>
<p dir="auto" style="color: #3a383f; margin: 0;" align="initial">I am not trying to put blame on anyone. It just happened. Unfortunately, our "CI" currently depends on users building and finding errors. :(</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #626168;">
—
<br>
<a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/867#note_137069">View it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.rtems.org">gitlab.rtems.org</a>. <a href="https://gitlab.rtems.org/-/sent_notifications/1-7oskakf3mzsnubtxmyk36kr06/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.rtems.org/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.rtems.org/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<span style="color: transparent; font-size: 0; display: none; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0;">
Notification message regarding https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/867#note_137069 at 1765315416
</span>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/867#note_137069"}}</script>
</p>
</div>
</body>
</html>