<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style='--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;'>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px;
}
body {
font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style='font-size: inherit; -webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";'>
<div class="content">
<p class="details" style="font-style: italic; color: #626168;">
<a href="https://gitlab.rtems.org/TheSamPrice">Sam Price</a> created a merge request: <a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/981">!981</a>
</p>
<div class="branch">
Project:Branches: TheSamPrice/rtems:fix/microblaze-stdout-path to rtems/rtos/rtems:main
</div>
<div class="author">
Author: Sam Price
</div>
<div class="assignee">
Assignees:
</div>
<div class="reviewer">
Reviewers:
</div>
<div class="approvers">
</div>
<div class="md gl-mt-5" style="position: relative; z-index: 1; color: #3a383f; word-wrap: break-word; margin-top: 1rem;">
<h2 dir="auto" style="margin-top: 0; margin-bottom: 10px;" align="initial">
<a href="#summary" aria-hidden="true" class="anchor" id="user-content-summary" style="margin-top: 0; margin-left: -20px; text-decoration: none; outline: none; position: absolute; width: 20px;"></a>Summary</h2>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">microblaze: harden stdout-path parsing for console</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">Details:</p>
<ul dir="auto" style="text-align: initial; list-style-type: disc; margin: 0 0 1rem; padding: 0;">
<li style="margin-top: 0; line-height: 1.6em; margin-left: 25px; padding-left: 3px;">
<p style="color: #3a383f; margin: 0 0 1rem;">Top test could crash early when /chosen/stdout-path used an alias (e.g. serial0:115200n8); the previous code passed a non NUL-terminated substring into libfdt, leading to corrupt reads and an illegal opcode before Init ran.</p>
</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">
<p style="color: #3a383f; margin: 0 0 1rem;">Parse stdout-path into a bounded, NUL-terminated buffer, strip the baud/format suffix, and resolve aliases via fdt_get_alias_namelen().</p>
</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">
<p style="color: #3a383f; margin: 0 0 1rem;">Use fdt_path_offset() on the resolved path so the console device node is found without libfdt walking past the string, allowing top.exe to boot and run normally under QEMU.</p>
</li>
</ul>
<h2 dir="auto" style="margin-top: 20px; margin-bottom: 10px;" align="initial">
<a href="#ai-details" aria-hidden="true" class="anchor" id="user-content-ai-details" style="margin-top: 0; margin-left: -20px; text-decoration: none; outline: none; position: absolute; width: 20px;"></a>AI Details</h2>
<h3 dir="auto" style="margin-top: 1.5rem; margin-bottom: 1rem; font-weight: 600; font-size: 1.125rem; letter-spacing: inherit; line-height: 1.25; color: #18171d;" align="initial">
<a href="#prompt-used" aria-hidden="true" class="anchor" id="user-content-prompt-used" style="margin-top: 0; margin-left: -20px; text-decoration: none; outline: none; position: absolute; width: 20px;"></a>Prompt used</h3>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">Lots of debugging to track down crash.</p>
<h3 dir="auto" style="margin-top: 1.5rem; margin-bottom: 1rem; font-weight: 600; font-size: 1.125rem; letter-spacing: inherit; line-height: 1.25; color: #18171d;" align="initial">
<a href="#ai-model-used" aria-hidden="true" class="anchor" id="user-content-ai-model-used" style="margin-top: 0; margin-left: -20px; text-decoration: none; outline: none; position: absolute; width: 20px;"></a>AI model used</h3>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">Codex 5.2</p>
<h3 dir="auto" style="margin-top: 1.5rem; margin-bottom: 1rem; font-weight: 600; font-size: 1.125rem; letter-spacing: inherit; line-height: 1.25; color: #18171d;" align="initial">
<a href="#how-ai-was-used-for-the-contribution" aria-hidden="true" class="anchor" id="user-content-how-ai-was-used-for-the-contribution" style="margin-top: 0; margin-left: -20px; text-decoration: none; outline: none; position: absolute; width: 20px;"></a>How AI was used for the contribution</h3>
<ul class="task-list" dir="auto" style="text-align: initial; list-style-type: disc; margin: 0 0 1rem; padding: 0;">
<li class="task-list-item" style="margin-top: 0; line-height: 1.6em; margin-left: 25px; padding-left: 3px; list-style-type: none; position: relative; min-height: 22px; padding-inline-start: 32px; margin-inline-start: 0 !important;">
<task-button style="margin-top: 0;"></task-button><input type="checkbox" class="task-list-item-checkbox" aria-label="Check option: Formatting" checked disabled style="position: absolute; inset-inline-start: 8px; inset-block-start: 3px; all: unset; box-sizing: border-box; height: 1rem; width: 1rem; cursor: pointer; border-radius: .25rem; background-color: #ffffff; border: 1px solid #89888d;"> Formatting</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">[N/A] Test creation.</li>
<li class="task-list-item" style="line-height: 1.6em; margin-left: 25px; padding-left: 3px; list-style-type: none; position: relative; min-height: 22px; padding-inline-start: 32px; margin-inline-start: 0 !important;">
<task-button style="margin-top: 0;"></task-button><input type="checkbox" class="task-list-item-checkbox" aria-label="Check option: Code comments." checked disabled style="position: absolute; inset-inline-start: 8px; inset-block-start: 3px; all: unset; box-sizing: border-box; height: 1rem; width: 1rem; cursor: pointer; border-radius: .25rem; background-color: #ffffff; border: 1px solid #89888d;"> Code comments.</li>
<li class="task-list-item" style="line-height: 1.6em; margin-left: 25px; padding-left: 3px; list-style-type: none; position: relative; min-height: 22px; padding-inline-start: 32px; margin-inline-start: 0 !important;">
<task-button style="margin-top: 0;"></task-button><input type="checkbox" class="task-list-item-checkbox" aria-label="Check option: The entire contribution was generated using AI" checked disabled style="position: absolute; inset-inline-start: 8px; inset-block-start: 3px; all: unset; box-sizing: border-box; height: 1rem; width: 1rem; cursor: pointer; border-radius: .25rem; background-color: #ffffff; border: 1px solid #89888d;"> The entire contribution was generated using AI</li>
<li class="task-list-item" style="line-height: 1.6em; margin-left: 25px; padding-left: 3px; list-style-type: none; position: relative; min-height: 22px; padding-inline-start: 32px; margin-inline-start: 0 !important;">
<task-button style="margin-top: 0;"></task-button><input type="checkbox" class="task-list-item-checkbox" aria-label="Check option: AI code completion such as Copilot in VSCode." disabled style="position: absolute; inset-inline-start: 8px; inset-block-start: 3px; all: unset; box-sizing: border-box; height: 1rem; width: 1rem; cursor: pointer; border-radius: .25rem; background-color: #ffffff; border: 1px solid #89888d;"> AI code completion such as Copilot in VSCode.</li>
</ul>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">I am not great with the device tree calls.
If a better way exists to catch null pointers out of this let me know via comments.</p>
<h3 dir="auto" style="margin-top: 1.5rem; margin-bottom: 0; font-weight: 600; font-size: 1.125rem; letter-spacing: inherit; line-height: 1.25; color: #18171d;" align="initial">
<a href="#access" aria-hidden="true" class="anchor" id="user-content-access" style="margin-top: 0; margin-left: -20px; text-decoration: none; outline: none; position: absolute; width: 20px;"></a>Access</h3>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #626168;">
—
<br>
<a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/981">View it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.rtems.org">gitlab.rtems.org</a>. <a href="https://gitlab.rtems.org/-/sent_notifications/1-eaghjgrdvk6z4y9kgzjotmn6c/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.rtems.org/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.rtems.org/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<span style="color: transparent; font-size: 0; display: none; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0;">
Notification message regarding https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/981 at 1770010716
</span>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/981"}}</script>
</p>
</div>
</body>
</html>