<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style="--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;">
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px;
}
body {
font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style="font-size: inherit; -webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";">
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.rtems.org/hongran86">Ran Hong</a>
<a href="https://gitlab.rtems.org/rtems/pkg/rtems-libbsd/-/issues/75#note_144013">commented</a>:
</p>
<div class="md" style="position: relative; z-index: 1; color: #3a383f; word-wrap: break-word;">
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">Just let you know, after fixing the error above, you may see two more errors. As guided by AI, I applied the following patch to correct them.</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">diff --git a/freebsd/sys/dev/ofw/ofw_pcib.c b/freebsd/sys/dev/ofw/ofw_pcib.c
index f786f9e8..9e71dcfe 100644
--- a/freebsd/sys/dev/ofw/ofw_pcib.c
+++ b/freebsd/sys/dev/ofw/ofw_pcib.c
@@ -85,9 +85,11 @@ static int ofw_pcib_unmap_resource(device_t, device_t, int, struct resource *,
static int ofw_pcib_translate_resource(device_t bus, int type,
rman_res_t start, rman_res_t *newstart);</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">+#ifndef <strong style="font-weight: 600; margin-top: 0;">rtems</strong>
#ifdef <strong style="font-weight: 600;">powerpc</strong>
static bus_space_tag_t ofw_pcib_bus_get_bus_tag(device_t, device_t);
#endif
+#endif /* <strong style="font-weight: 600;">rtems</strong> */</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">/*</p>
<ul dir="auto" style="text-align: initial; list-style-type: disc; margin: 0 0 1rem; padding: 0;">
<li style="margin-top: 0; line-height: 1.6em; margin-left: 25px; padding-left: 3px;">
<p style="color: #3a383f; margin: 0 0 1rem;">pcib interface
@@ -126,9 +128,11 @@ static device_method_t ofw_pcib_methods[] = {
DEVMETHOD(bus_map_resource, ofw_pcib_map_resource),
DEVMETHOD(bus_unmap_resource, ofw_pcib_unmap_resource),
DEVMETHOD(bus_translate_resource, ofw_pcib_translate_resource),
+#ifndef <strong style="font-weight: 600; margin-top: 0;">rtems</strong>
#ifdef <strong style="font-weight: 600;">powerpc</strong>
DEVMETHOD(bus_get_bus_tag, ofw_pcib_bus_get_bus_tag),
#endif
+#endif /* <strong style="font-weight: 600;">rtems</strong> */</p>
<div class="gl-relative markdown-code-block js-markdown-code">
<pre class="code highlight js-syntax-highlight language-plaintext" v-pre="true" style="display: block; font-size: 14px; color: #3a383f; line-height: 1.6em; overflow-x: auto; border-radius: .25rem; position: relative; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; margin: 0 0 1rem; padding: 12px; border: 1px solid #dcdcde;"><code style="font-size: inherit; color: inherit; word-wrap: normal; word-break: keep-all; background-color: inherit; border-radius: .25rem; white-space: pre; margin-top: 0; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; overflow-wrap: normal; padding: unset;"><span id="LC1" class="line" lang="plaintext" style="margin-top: 0;">/* pcib interface */</span>
<span id="LC2" class="line" lang="plaintext">DEVMETHOD(pcib_maxslots, ofw_pcib_maxslots),</span></code></pre>
<copy-code></copy-code><insert-code-snippet></insert-code-snippet>
</div>
</li>
</ul>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">diff --git a/freebsd/sys/powerpc/mpc85xx/mpc85xx.h b/freebsd/sys/powerpc/mpc85xx/mpc85xx.h
index 669e8be4..9368c5f6 100644
--- a/freebsd/sys/powerpc/mpc85xx/mpc85xx.h
+++ b/freebsd/sys/powerpc/mpc85xx/mpc85xx.h
@@ -77,6 +77,8 @@ extern vm_size_t ccsrbar_size;
#define OCP85XX_LAWSR_85XX(n) (CCSRBAR_VA + 0xc10 + 0x10 * (n))
#define OCP85XX_LAWSR(n) (mpc85xx_is_qoriq() ? OCP85XX_LAWSR_QORIQ(n) : <br style="margin-top: 0;">
OCP85XX_LAWSR_85XX(n))
+#define OCP85XX_LAWBAR_P20XX(n) (CCSRBAR_VA + 0xc08 + 0x20 * (n))
+#define OCP85XX_LAWAR(n) (CCSRBAR_VA + 0xc10 + 0x20 * (n))</p>
<p dir="auto" style="color: #3a383f; margin: 0;" align="initial">/* Attribute register */
#define OCP85XX_ENA_MASK 0x80000000</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #626168;">
—
<br>
<a href="https://gitlab.rtems.org/rtems/pkg/rtems-libbsd/-/issues/75#note_144013">View it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.rtems.org">gitlab.rtems.org</a>. <a href="https://gitlab.rtems.org/-/sent_notifications/2-d0gpxvg037o65zwy3l83n0cgf/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.rtems.org/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.rtems.org/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<span style="color: transparent; font-size: 0; display: none; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0;">
Notification message regarding https://gitlab.rtems.org/rtems/pkg/rtems-libbsd/-/issues/75#note_144013 at 1772474515
</span>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Issue","url":"https://gitlab.rtems.org/rtems/pkg/rtems-libbsd/-/issues/75#note_144013"}}</script>
</p>
</div>
</body>
</html>