<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style="--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;">
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px;
}
body {
font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style="font-size: inherit; -webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";">
<div class="content">
<p class="details" style="font-style: italic; color: #626168;">
<a href="https://gitlab.rtems.org/DonutAnees">Mohammed Anees</a> created an issue: <a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/issues/5518">#5518</a>
</p>
<div class="md" style="position: relative; z-index: 1; color: #3a383f; word-wrap: break-word;">
<h2 id="user-content-summary" dir="auto" style="margin-top: 0; margin-bottom: 10px;" align="initial">Summary<a href="#summary" aria-label="Link to heading 'Summary'" data-heading-content="Summary" class="anchor" style="margin-top: 0;"></a>
</h2>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">**Related to: **<strong style="font-weight: 600; margin-top: 0;"><a href="https://gitlab.rtems.org/rtems/programs/gsoc/-/issues/8" title="Improve PC386 BSP" class="gfm gfm-issue" data-original="https://gitlab.rtems.org/rtems/programs/gsoc/-/issues/8" data-link="false" data-link-reference="true" data-issue="28123" data-project="20" data-iid="8" data-namespace-path="rtems/programs/gsoc" data-project-path="rtems/programs/gsoc" data-issue-type="issue" data-container="body" data-placement="top" data-reference-type="issue" style="margin-top: 0;">rtems/programs/gsoc#8</a></strong></p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">This is groundwork for the GSoC issue linked above. The i386 BSP has all its APIC code mixed into <code style="font-size: 90%; color: #18171d; word-wrap: break-word; background-color: #ececef; border-radius: .25rem; margin-top: 0; font-weight: inherit; overflow-wrap: break-word; white-space: break-spaces; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; word-break: keep-all; padding: 0.125rem 0.25rem;">smp-imps.c</code> which is supposed to be just the MP table parser. Before we can do anything else from that issue, the APIC code currently needs to be decoupled of this driver, this is required to later on support APIC instead of PIC for non legacy systems.</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">Key changes done:</p>
<ul dir="auto" style="text-align: initial; list-style-type: disc; margin: 0; padding: 0;">
<li style="margin-top: 0; line-height: 1.6em; margin-left: 25px; padding-left: 3px;">Got rid of the dummy variable hack that was being used as the LAPIC base pointer and replaced it with a pointer that is NULL until the LAPIC is initialized.</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">Cleaned up how LAPIC registers are accessed to match how the x86_64 BSP already does it (array based)</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">Renamed the CPU/APIC mapping arrays to have consistent i386_ prefixed names</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">Pulled the AP startup signaling out of boot_cpu() into its own functions so the APIC code and the MP table code are no longer mixed together</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">Removed unwanted externs and other clean ups</li>
</ul>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #626168;">
—
<br>
<a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/issues/5518">View it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.rtems.org">gitlab.rtems.org</a>. <a href="https://gitlab.rtems.org/-/sent_notifications/2-6fa46yxjtsxjz8d61xk4tpoze/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.rtems.org/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.rtems.org/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<span style="color: transparent; font-size: 0; display: none; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0;">
Notification message regarding https://gitlab.rtems.org/rtems/rtos/rtems/-/issues/5518 at 1773258874
</span>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Issue","url":"https://gitlab.rtems.org/rtems/rtos/rtems/-/issues/5518"}}</script>
</p>
</div>
</body>
</html>