<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style="--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;">
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px;
}
body {
font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style="font-size: inherit; -webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";">
<div class="content">
<p class="details" style="font-style: italic; color: #626168;">
<a href="https://gitlab.rtems.org/mohamedayman23">Mohamed Ayman</a> created a merge request: <a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1144">!1144</a>
</p>
<div class="branch">
Project:Branches: mohamedayman23/rtems:fix-issue-stm32h7-bspstart to rtems/rtos/rtems:main
</div>
<div class="author">
Author: Mohamed Ayman
</div>
<div class="assignee">
Assignees:
</div>
<div class="reviewer">
Reviewers:
</div>
<div class="md gl-mt-5" style="position: relative; z-index: 1; color: #3a383f; word-wrap: break-word; margin-top: 1rem;">
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">stm32h7/bspstart: avoid overflow in HAL_GetTick calculation</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">Potential Integer Overflow in HAL_GetTick():</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">Original code multiplies ticks since boot by milliseconds per tick using 32-bit arithmetic:</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">uint32_t HAL_GetTick(void) { return rtems_clock_get_ticks_since_boot() * rtems_configuration_get_milliseconds_per_tick(); }</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">Context: STM32 HAL expects HAL_GetTick() to return a millisecond counter for timeouts and delays. A 32-bit millisecond counter overflows every <span data-escaped-char style="margin-top: 0;">~</span>49.7 days at 1ms tick.</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">Potential Bug: If the system tick is larger than 1ms (e.g., 10ms/tick), the multiplication can overflow faster, roughly every 4.97 days, causing HAL drivers (UART, I2C, SPI) to see incorrect time values.</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">And the fix is to Cast to 64-bit before multiplication to avoid intermediate overflow, then return as uint32_t. Ensures correct millisecond count regardless of tick size.</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">AI usage: yes</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">Prompt used: what is i used more than one millisecond and less than i know that the reference manual say the initial is one milli</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">AI model: GPT-5 mini</p>
<p dir="auto" style="color: #3a383f; margin: 0;" align="initial">How AI was used: just predicting unusual behavior</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #626168;">
—
<br>
<a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1144">View it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.rtems.org">gitlab.rtems.org</a>. <a href="https://gitlab.rtems.org/-/sent_notifications/2-1ymenf2ejeef8ufgsaav0alm1/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.rtems.org/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.rtems.org/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<span style="color: transparent; font-size: 0; display: none; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0;">
Notification message regarding https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1144 at 1773754468
</span>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1144"}}</script>
</p>
</div>
</body>
</html>