<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style="--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;">
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px;
}
body {
font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style="font-size: inherit; -webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";">
<div class="content">
<p class="details" style="font-style: italic; color: #626168;">
<a href="https://gitlab.rtems.org/mohamedayman23">Mohamed Ayman</a> created a merge request: <a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1162">!1162</a>
</p>
<div class="branch">
Project:Branches: mohamedayman23/rtems:fix-stm32h7-spi-support-bugs to rtems/rtos/rtems:main
</div>
<div class="author">
Author: Mohamed Ayman
</div>
<div class="assignee">
Assignees:
</div>
<div class="reviewer">
Reviewers:
</div>
<div class="md gl-mt-5" style="position: relative; z-index: 1; color: #3a383f; word-wrap: break-word; margin-top: 1rem;">
<h2 id="user-content-summary" dir="auto" style="margin-top: 0; margin-bottom: 10px;" align="initial">Summary<a href="#summary" aria-label="Link to heading 'Summary'" data-heading-content="Summary" class="anchor" style="margin-top: 0;"></a>
</h2>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">stm32h7/spi-support: correct bugs and improve safety in SPI HAL</p>
<ul dir="auto" style="text-align: initial; list-style-type: disc; margin: 0 0 1rem; padding: 0;">
<li style="margin-top: 0; line-height: 1.6em; margin-left: 25px; padding-left: 3px;">Fix transfer loop “final” condition in stm32h7_spi_apply_postmessage_settings: previous code used i == msg_count, which is never true. Now correctly uses i == (msg_count - 1).</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">Reset ctx->error before starting transfers in stm32h7_spi_txrx, stm32h7_spi_tx, and stm32h7_spi_rx. Prevents old errors from persisting when using interrupts.</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">Prevent division by zero in prescaler calculation: return early if speed_hz == 0.</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">Guard against unsafe usage of _Bitfield_Leading_zeros: return early if divider == 0 to avoid undefined logic.</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">Correct return type in stm32h7_register_spi_device: previously returned false in int function, now returns -1.</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">DMA alignment check now guards against NULL pointers: check if pRxData != NULL before evaluating alignment.</li>
</ul>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">AI Usage: yes</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">AI prompt: how the developer struct this very long file what is the best milestones he do and the baddest ideas and give me the flow to write one for a different family.</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">AI Model: GPT-5 mini</p>
<p dir="auto" style="color: #3a383f; margin: 0;" align="initial">How AI Used: to struct and understanding big file.</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #626168;">
—
<br>
<a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1162">View it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.rtems.org">gitlab.rtems.org</a>. <a href="https://gitlab.rtems.org/-/sent_notifications/2-clxcst7ah0y8pev8ewzwpalsl/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.rtems.org/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.rtems.org/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<span style="color: transparent; font-size: 0; display: none; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0;">
Notification message regarding https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1162 at 1774424685
</span>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1162"}}</script>
</p>
</div>
</body>
</html>