<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style="--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;">
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px;
}
body {
font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style="font-size: inherit; -webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";">
<div class="content">
<p class="details" style="font-style: italic; color: #626168;">
<a href="https://gitlab.rtems.org/ppisa">Pavel Pisa</a> created an issue: <a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/issues/5539">#5539</a>
</p>
<div class="md" style="position: relative; z-index: 1; color: #3a383f; word-wrap: break-word;">
<h2 id="user-content-summary" dir="auto" style="margin-top: 0; margin-bottom: 10px;" align="initial">Summary<a href="#summary" aria-label="Link to heading 'Summary'" data-heading-content="Summary" class="anchor" style="margin-top: 0;"></a>
</h2>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">The internal SRAM build are useful for testing of TMS570 modifications and builds. If the system is not reconfigured by some loader or application then it is necessary to enable TMS570_USE_HWINIT_STARTUP even for internal ram builds (i.e. <code style="font-size: 90%; color: #18171d; word-wrap: break-word; background-color: #ececef; border-radius: .25rem; margin-top: 0; font-weight: inherit; overflow-wrap: break-word; white-space: break-spaces; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; word-break: keep-all; padding: 0.125rem 0.25rem;">tms570ls3137_hdk_intram</code>). But the code in bsp_start_hook_0 resolves test for running from SRAM incorrectly which leads to less critical problem that internal SRAM could be left uninitialized when application is placed in Flash and it has fatal consequence for SRAM builds when it results in application clearing itself.</p>
<h2 id="user-content-steps-to-reproduce" dir="auto" style="margin-top: 20px; margin-bottom: 10px;" align="initial">Steps to reproduce<a href="#steps-to-reproduce" aria-label="Link to heading 'Steps to reproduce'" data-heading-content="Steps to reproduce" class="anchor" style="margin-top: 0;"></a>
</h2>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">When build configuration is modified to allow test TMS570 BSP hardware initialization code even for internal SRAM builds, then application clears/zeroes itself and cannot continue.</p>
<div class="gl-relative markdown-code-block js-markdown-code">
<pre class="code highlight js-syntax-highlight language-plaintext" v-pre="true" style="display: block; font-size: 14px; color: #3a383f; line-height: 1.6em; overflow-x: auto; border-radius: .25rem; position: relative; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; margin: 0 0 1rem; padding: 12px; border: 1px solid #dcdcde;"><code style="font-size: inherit; color: inherit; word-wrap: normal; word-break: keep-all; background-color: inherit; border-radius: .25rem; white-space: pre; margin-top: 0; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; overflow-wrap: normal; padding: unset;"><span id="LC1" class="line" lang="plaintext" style="margin-top: 0;">diff --git a/spec/build/bsps/arm/tms570/objhwinitlc4357hdk.yml b/spec/build/bsps/arm/tms570/objhwinitlc4357hdk.yml</span>
<span id="LC2" class="line" lang="plaintext">index 1b91475804..71ca6b8b47 100644</span>
<span id="LC3" class="line" lang="plaintext">--- a/spec/build/bsps/arm/tms570/objhwinitlc4357hdk.yml</span>
<span id="LC4" class="line" lang="plaintext">+++ b/spec/build/bsps/arm/tms570/objhwinitlc4357hdk.yml</span>
<span id="LC5" class="line" lang="plaintext">@@ -5,7 +5,9 @@ copyrights:</span>
<span id="LC6" class="line" lang="plaintext"> - Copyright (C) 2023 embedded brains GmbH & Co. KG</span>
<span id="LC7" class="line" lang="plaintext"> cppflags: []</span>
<span id="LC8" class="line" lang="plaintext"> cxxflags: []</span>
<span id="LC9" class="line" lang="plaintext">-enabled-by: arm/tms570lc4357_hdk</span>
<span id="LC10" class="line" lang="plaintext">+enabled-by:</span>
<span id="LC11" class="line" lang="plaintext">+ - arm/tms570lc4357_hdk</span>
<span id="LC12" class="line" lang="plaintext">+ - arm/tms570lc4357_hdk_intram</span>
<span id="LC13" class="line" lang="plaintext"> includes: []</span>
<span id="LC14" class="line" lang="plaintext"> install: []</span>
<span id="LC15" class="line" lang="plaintext"> links: []</span>
<span id="LC16" class="line" lang="plaintext">diff --git a/spec/build/bsps/arm/tms570/optlowinit.yml b/spec/build/bsps/arm/tms570/optlowinit.yml</span>
<span id="LC17" class="line" lang="plaintext">index 32b84aa08c..7bfd42202b 100644</span>
<span id="LC18" class="line" lang="plaintext">--- a/spec/build/bsps/arm/tms570/optlowinit.yml</span>
<span id="LC19" class="line" lang="plaintext">+++ b/spec/build/bsps/arm/tms570/optlowinit.yml</span>
<span id="LC20" class="line" lang="plaintext">@@ -10,6 +10,7 @@ default:</span>
<span id="LC21" class="line" lang="plaintext"> - enabled-by:</span>
<span id="LC22" class="line" lang="plaintext"> - arm/tms570ls3137_hdk</span>
<span id="LC23" class="line" lang="plaintext"> - arm/tms570lc4357_hdk</span>
<span id="LC24" class="line" lang="plaintext">+ - arm/tms570lc4357_hdk_intram</span>
<span id="LC25" class="line" lang="plaintext"> value: true</span>
<span id="LC26" class="line" lang="plaintext"> - enabled-by: true</span>
<span id="LC27" class="line" lang="plaintext"> value: false</span></code></pre>
<copy-code></copy-code><insert-code-snippet></insert-code-snippet>
</div>
<h2 id="user-content-expected-behaviour" dir="auto" style="margin-top: 20px; margin-bottom: 10px;" align="initial">Expected behaviour<a href="#expected-behaviour" aria-label="Link to heading 'Expected behaviour'" data-heading-content="Expected behaviour" class="anchor" style="margin-top: 0;"></a>
</h2>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">Expected behavior is working <code style="font-size: 90%; color: #18171d; word-wrap: break-word; background-color: #ececef; border-radius: .25rem; margin-top: 0; font-weight: inherit; overflow-wrap: break-word; white-space: break-spaces; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; word-break: keep-all; padding: 0.125rem 0.25rem;">ticker.exe</code> and other applications.</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">The correction is simple</p>
<div class="gl-relative markdown-code-block js-markdown-code" style="margin-bottom: 0;">
<pre class="code highlight js-syntax-highlight language-plaintext" v-pre="true" style="display: block; font-size: 14px; color: #3a383f; line-height: 1.6em; overflow-x: auto; border-radius: .25rem; position: relative; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; margin: 0 0 1rem; padding: 12px; border: 1px solid #dcdcde;"><code style="font-size: inherit; color: inherit; word-wrap: normal; word-break: keep-all; background-color: inherit; border-radius: .25rem; white-space: pre; margin-top: 0; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; overflow-wrap: normal; padding: unset;"><span id="LC1" class="line" lang="plaintext" style="margin-top: 0;">diff --git a/bsps/arm/tms570/start/bspstarthooks-hwinit.c b/bsps/arm/tms570/start/bspstarthooks-hwinit.c</span>
<span id="LC2" class="line" lang="plaintext">index 6407cc4a45..980f90cd20 100644</span>
<span id="LC3" class="line" lang="plaintext">--- a/bsps/arm/tms570/start/bspstarthooks-hwinit.c</span>
<span id="LC4" class="line" lang="plaintext">+++ b/bsps/arm/tms570/start/bspstarthooks-hwinit.c</span>
<span id="LC5" class="line" lang="plaintext">@@ -60,7 +60,7 @@ __attribute__((__naked__)) void bsp_start_hook_0( void )</span>
<span id="LC6" class="line" lang="plaintext"> "ldr r1, =#" RTEMS_XSTRING( TMS570_MEMORY_SRAM_SIZE ) "\n"</span>
<span id="LC7" class="line" lang="plaintext"> "sub r0, lr, r0\n"</span>
<span id="LC8" class="line" lang="plaintext"> "cmp r1, r0\n"</span>
<span id="LC9" class="line" lang="plaintext">- "blt 1f\n"</span>
<span id="LC10" class="line" lang="plaintext">+ "bhi 1f\n"</span>
<span id="LC11" class="line" lang="plaintext"></span>
<span id="LC12" class="line" lang="plaintext"> /*</span>
<span id="LC13" class="line" lang="plaintext"> * Initialize the SRAM if we are not running in SRAM. While we are called,</span></code></pre>
<copy-code></copy-code><insert-code-snippet></insert-code-snippet>
</div>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #626168;">
—
<br>
<a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/issues/5539">View it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.rtems.org">gitlab.rtems.org</a>. <a href="https://gitlab.rtems.org/-/sent_notifications/2-9pvk0hq4ui7xg6k6kjffiacx0/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.rtems.org/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.rtems.org/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<span style="color: transparent; font-size: 0; display: none; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0;">
Notification message regarding https://gitlab.rtems.org/rtems/rtos/rtems/-/issues/5539 at 1774996384
</span>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Issue","url":"https://gitlab.rtems.org/rtems/rtos/rtems/-/issues/5539"}}</script>
</p>
</div>
</body>
</html>