<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style="--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;">
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px;
}
body {
font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style="font-size: inherit; -webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";">
<div class="content">
<p class="details" style="font-style: italic; color: #626168;">
<a href="https://gitlab.rtems.org/ppisa">Pavel Pisa</a> created a merge request: <a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1187">!1187</a>
</p>
<div class="branch">
Project:Branches: ppisa/rtems:tms570-fix-sram-pbist to rtems/rtos/rtems:main
</div>
<div class="author">
Author: Pavel Pisa
</div>
<div class="assignee">
Assignees:
</div>
<div class="reviewer">
Reviewers:
</div>
<div class="md gl-mt-5" style="position: relative; z-index: 1; color: #3a383f; word-wrap: break-word; margin-top: 1rem;">
<h2 id="user-content-summary" dir="auto" style="margin-top: 0; margin-bottom: 10px;" align="initial">Summary<a href="#summary" aria-label="Link to heading 'Summary'" data-heading-content="Summary" class="anchor" style="margin-top: 0;"></a>
</h2>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">bsps/arm/tms570: fix self-test to work when internal SRAM is tested</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">The previous fix has exposed more breakage if internal
SRAM self-tests is run when code starts from Flash
or external memory. The previous negated option has
disabled SRAM self-test in these cases and enabled
it for code running from SRAM which lead to code
self-clear.</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">But when code is running from Flash and full safety
should be achieved then then SRAM test run through
nested function</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">/* ESRAM Single Port PBIST */
tms570_pbist_run_and_check( 0x08300020U,
(uint32_t) PBIST_March13N_SP )</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">lead to situation when lr and r3 could not be
restored in return from this function.
Memory content has been overwritten by tests.</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">When this problem has been solved then next
problem is that memory with enabled ECC has
been unsynchronized and attempt to load already
overwritten lr and r3 in tms570_start_hook_0
has led to data-abort and fatal error with error
pin set till next power cycle.</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">The solution is to synchronize, reinitialize
internal SRAM after PBIST test.</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">Yer another problem is run of ECC failure detection</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">tms570_check_tcram_ecc</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">It fails with unrecoverable data abort as well
because for proper function it requires special
support in data-abort exception handler which
is not present on RTEMS.</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">Closes <a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/issues/5547" title="TMS570 BSP has long term broken initial SRAM tests which has been unmasked by my previous fix" class="gfm gfm-issue" data-original="rtems/rtos/rtems#5547" data-link="false" data-link-reference="false" data-issue="29616" data-project="26" data-iid="5547" data-namespace-path="rtems/rtos/rtems" data-project-path="rtems/rtos/rtems" data-issue-type="issue" data-container="body" data-placement="top" data-reference-type="issue" style="margin-top: 0;">#5547</a></p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">Signed-off-by: Pavel Pisa <a href="mailto:ppisa@pikron.com" style="margin-top: 0;">ppisa@pikron.com</a></p>
<h2 id="user-content-generative-ai" dir="auto" style="margin-top: 20px; margin-bottom: 0;" align="initial">Generative AI<a href="#generative-ai" aria-label="Link to heading 'Generative AI'" data-heading-content="Generative AI" class="anchor" style="margin-top: 0;"></a>
</h2>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #626168;">
—
<br>
<a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1187">View it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.rtems.org">gitlab.rtems.org</a>. <a href="https://gitlab.rtems.org/-/sent_notifications/3-8i3sm38w27di7kgnow3babyer/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.rtems.org/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.rtems.org/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<span style="color: transparent; font-size: 0; display: none; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0;">
Notification message regarding https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1187 at 1775440559
</span>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1187"}}</script>
</p>
</div>
</body>
</html>