<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style="--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;">
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px;
}
body {
font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style="font-size: inherit; -webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";">
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.rtems.org/joel">Joel Sherrill</a>
<a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1216#note_149013">commented</a>:
</p>
<div class="md" style="position: relative; z-index: 1; color: #3a383f; word-wrap: break-word;">
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">The changes look OK but a baud rate of 0 is valid per POSIX <a href="https://pubs.opengroup.org/onlinepubs/009696799/functions/tcsetattr.html" rel="nofollow noreferrer noopener" target="_blank" style="margin-top: 0;">tcsetattr()</a>. B0 is very old school UNIX and setting the baud rate to that indicates that the "the modem control lines shall no longer be asserted. Normally, this shall disconnect the line." AFAIK no RTEMS UART drivers have support for modem control lines so this is a NA.</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">I got caught by this while trying out <a href="https://flightsoftware.jhuapl.edu/files/_site/workshops/old_archive/2014/" rel="nofollow noreferrer noopener" target="_blank" style="margin-top: 0;">CodeSonar on RTEMS</a>. It was flagged as a missed divide by zero but is actually a feature not supported by the driver.</p>
<p dir="auto" style="color: #3a383f; margin: 0;" align="initial">I added <a href="https://gitlab.rtems.org/rtems/docs/rtems-docs/-/issues/144" title="BSP Guide 6.8 Console Set Attributes Should Discuss B0" class="gfm gfm-issue" data-original="https://gitlab.rtems.org/rtems/docs/rtems-docs/-/issues/144" data-link="false" data-link-reference="true" data-issue="29638" data-project="12" data-iid="144" data-namespace-path="rtems/docs/rtems-docs" data-project-path="rtems/docs/rtems-docs" data-issue-type="issue" data-container="body" data-placement="top" data-reference-type="issue" style="margin-top: 0;">rtems/docs/rtems-docs#144</a> to ensure this gets documented and <a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/issues/5558" title="Review all uart/console driver set_attributes() for B0 handling" class="gfm gfm-issue" data-original="#5558" data-link="false" data-link-reference="false" data-issue="29639" data-project="26" data-iid="5558" data-namespace-path="rtems/rtos/rtems" data-project-path="rtems/rtos/rtems" data-issue-type="issue" data-container="body" data-placement="top" data-reference-type="issue">#5558</a> for reviewing all the UART/console drivers to discuss this.</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #626168;">
—
<br>
<a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1216#note_149013">View it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.rtems.org">gitlab.rtems.org</a>. <a href="https://gitlab.rtems.org/-/sent_notifications/3-0v4aleqrc51f19bi9aq6xb08h/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.rtems.org/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.rtems.org/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<span style="color: transparent; font-size: 0; display: none; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0;">
Notification message regarding https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1216#note_149013 at 1777041088
</span>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1216#note_149013"}}</script>
</p>
</div>
</body>
</html>