<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style="--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;">
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px;
}
body {
font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style="font-size: inherit; -webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";">
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.rtems.org/mohamedayman23">Mohamed Ayman</a>
commented on a
<a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1227#note_149422">discussion</a>:
</p>
<div class="md" style="position: relative; z-index: 1; color: #3a383f; word-wrap: break-word;">
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">Ok, the previous check was iincorrect because fdt_getprop() returns the length in bytes, while the code compared it with the number of address cells. This could allow truncated properties to pass the check and lead to invalid memory access.</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">I fixed it by checcking against ac * sizeof(uint32_t), which matches the actual data size.</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">I tested this change by running the RTEMS hello world on QEMU (qemu-system-riscv64 -M virt with #address-cells = <2>), and it worked <strong style="font-weight: 600; margin-top: 0;">without any regression Nothing Breaks</strong>.</p>
<p dir="auto" style="color: #3a383f; margin: 0;" align="initial"><a class="no-attachment-icon gfm" href="https://gitlab.rtems.org/-/project/26/uploads/f76c7a97a49bc4805fc99334d59a894e/Screenshot_from_2026-05-03_05-53-58.png" target="_blank" rel="noopener noreferrer" data-canonical-src="/uploads/f76c7a97a49bc4805fc99334d59a894e/Screenshot_from_2026-05-03_05-53-58.png" data-link="true" style="margin-top: 0;"><img src="https://gitlab.rtems.org/-/project/26/uploads/f76c7a97a49bc4805fc99334d59a894e/Screenshot_from_2026-05-03_05-53-58.png" alt="Screenshot from 2026-05-03 05-53-58.png" width="900" height="365" data-canonical-src="/uploads/f76c7a97a49bc4805fc99334d59a894e/Screenshot_from_2026-05-03_05-53-58.png" class="gfm" style="max-width: 100%; height: auto; margin-top: 0; vertical-align: baseline; object-fit: contain; object-position: top;"></a></p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #626168;">
—
<br>
<a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1227#note_149422">View it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.rtems.org">gitlab.rtems.org</a>. <a href="https://gitlab.rtems.org/-/sent_notifications/3-2ohjjag3t821a18x82aqu7qyp/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.rtems.org/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.rtems.org/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<span style="color: transparent; font-size: 0; display: none; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0;">
Notification message regarding https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1227#note_149422 at 1777776854
</span>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1227#note_149422"}}</script>
</p>
</div>
</body>
</html>