<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style="--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;">
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px;
}
body {
font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style="font-size: inherit; -webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";">
<div class="content">
<p class="details" style="font-style: italic; color: #626168;">
<a href="https://gitlab.rtems.org/av-vedanth">A V Vedanth</a> created a merge request: <a href="https://gitlab.rtems.org/rtems/pkg/rtems-net-services/-/merge_requests/36">!36</a>
</p>
<div class="branch">
Project:Branches: av-vedanth/rtems-net-services:ntp-fix-parsing-state-reset to rtems/pkg/rtems-net-services:main
</div>
<div class="author">
Author: A V Vedanth
</div>
<div class="assignee">
Assignees:
</div>
<div class="reviewer">
Reviewers:
</div>
<div class="md gl-mt-5" style="position: relative; z-index: 1; color: #3a383f; word-wrap: break-word; margin-top: 1rem;">
<h2 id="user-content-summary" dir="auto" style="margin-top: 0; margin-bottom: 10px;" align="initial">Summary<a href="#summary" aria-label="Link to heading 'Summary'" data-heading-content="Summary" class="anchor" style="margin-top: 0;"></a>
</h2>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">Changed scope of parsed and optct from inside parse_cmdline_opts() to global in ntpd.c .</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">Because parsed static local stays 1 even after first ntp run therefore skipping option processing on restart</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">Created :</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">rtems_ntp_opts_globals_fini() to reset ntpdOptions runtime fields.</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">parsed and optct reset to 0 and rtems_ntp_opts_globals_fini() is called in rtems_ntpd_run()</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">Verification test done on QEMU leon3 with <code style="font-size: 90%; color: #18171d; word-wrap: break-word; background-color: #ececef; border-radius: .25rem; margin-top: 0; font-weight: inherit; overflow-wrap: break-word; white-space: break-spaces; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; word-break: keep-all; padding: 0.125rem 0.25rem;">ntp01</code> test.</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">FIX : second NTP start no longer skips option processing</p>
<div class="gl-relative markdown-code-block js-markdown-code">
<pre class="code highlight js-syntax-highlight language-plaintext" v-pre="true" style="display: block; font-size: 14px; color: #3a383f; line-height: 1.6em; overflow-x: auto; border-radius: .25rem; position: relative; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; margin: 0 0 1rem; padding: 12px; border: 1px solid #dcdcde;"><code style="font-size: inherit; color: inherit; word-wrap: normal; word-break: keep-all; background-color: inherit; border-radius: .25rem; white-space: pre; margin-top: 0; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; overflow-wrap: normal; padding: unset;"><span id="LC1" class="line" lang="plaintext" style="margin-top: 0;">vedanth@vedanth-Legion-Pro-5-16IRX10:~/rtems_proj/rtems-net-services$ qemu-system-sparc -no-reboot -serial mon:stdio \</span>
<span id="LC2" class="line" lang="plaintext"> -m 256M \</span>
<span id="LC3" class="line" lang="plaintext"> -M leon3_generic \</span>
<span id="LC4" class="line" lang="plaintext"> -kernel ~/rtems_proj/rtems-net-services/build/sparc-rtems7-leon3/ntp01.exe</span>
<span id="LC5" class="line" lang="plaintext"></span>
<span id="LC6" class="line" lang="plaintext"></span>
<span id="LC7" class="line" lang="plaintext">*** BEGIN OF TEST NTP 1 ***</span>
<span id="LC8" class="line" lang="plaintext">*** TEST VERSION: 7.0.0.108b17f882a298746228e878f50442684cac6a6e</span>
<span id="LC9" class="line" lang="plaintext">*** TEST STATE: EXPECTED_PASS</span>
<span id="LC10" class="line" lang="plaintext">*** TEST BUILD: RTEMS_POSIX_API</span>
<span id="LC11" class="line" lang="plaintext">*** TEST TOOLS: 15.2.0 20250808 (RTEMS 7, Build 2026.03.04, RSB 00a71896204f95cb583e6271cad4c192b62cce6d, Newlib a7c61498)</span>
<span id="LC12" class="line" lang="plaintext">nexus0: <RTEMS Nexus device></span>
<span id="LC13" class="line" lang="plaintext">info: lo0: link state changed to UP</span>
<span id="LC14" class="line" lang="plaintext">info: version 6.2.1 starting</span>
<span id="LC15" class="line" lang="plaintext">err: no valid interfaces found</span>
<span id="LC16" class="line" lang="plaintext">warning: no interfaces have a carrier</span>
<span id="LC17" class="line" lang="plaintext">info: telnetd: started successfully on port 23</span>
<span id="LC18" class="line" lang="plaintext"></span>
<span id="LC19" class="line" lang="plaintext">RTEMS Shell on /dev/console. Use 'help' to list commands.</span>
<span id="LC20" class="line" lang="plaintext">SHLL [/] # ntpd starting</span>
<span id="LC21" class="line" lang="plaintext">ntpd forced stop</span>
<span id="LC22" class="line" lang="plaintext">ntpd finished: 0</span>
<span id="LC23" class="line" lang="plaintext">ntpd starting</span></code></pre>
<copy-code></copy-code><insert-code-snippet></insert-code-snippet>
</div>
<h2 id="user-content-generative-ai" dir="auto" style="margin-top: 20px; margin-bottom: 10px;" align="initial">Generative AI<a href="#generative-ai" aria-label="Link to heading 'Generative AI'" data-heading-content="Generative AI" class="anchor" style="margin-top: 0;"></a>
</h2>
<p dir="auto" style="color: #3a383f; margin: 0;" align="initial">Used claude code and gemini to better understand the code base.</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #626168;">
—
<br>
<a href="https://gitlab.rtems.org/rtems/pkg/rtems-net-services/-/merge_requests/36">View it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.rtems.org">gitlab.rtems.org</a>. <a href="https://gitlab.rtems.org/-/sent_notifications/3-e4pjrhqhr2pp97zajtu20mgee/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.rtems.org/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.rtems.org/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<span style="color: transparent; font-size: 0; display: none; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0;">
Notification message regarding https://gitlab.rtems.org/rtems/pkg/rtems-net-services/-/merge_requests/36 at 1777929694
</span>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.rtems.org/rtems/pkg/rtems-net-services/-/merge_requests/36"}}</script>
</p>
</div>
</body>
</html>