<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style="--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;">
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: hsla(0,0%,100%,.01) 0 0 1px;
}
body {
font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style="font-size: inherit; -webkit-text-shadow: hsla(0,0%,100%,.01) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";">
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.rtems.org/ppisa">Pavel Pisa</a>
<a href="https://gitlab.rtems.org/rtems/pkg/rtems-lwip/-/merge_requests/48#note_154990">commented</a>:
</p>
<div class="md" style="position: relative; z-index: 1; color: #3a383f; word-wrap: break-word;">
<p dir="auto" style="color: #3a383f; margin: 0px 0px 1rem;" align="initial">Hello <a href="https://gitlab.rtems.org/ar-in0" title="Armaan Chowfin" class="gfm gfm-project_member js-user-link" data-user="2058" data-original="@ar-in0" data-container="body" data-placement="top" data-reference-type="user" style="color: #284779; background-color: #cbe2f9; border-radius: .25rem; margin-top: 0px; padding: 0 2px;">@ar-in0</a> and others, I have checked all provided commits and all changes seems to me as logical and correct. It would worth to test that even on other targets which have LwIP functional.</p>
<p dir="auto" style="color: #3a383f; margin: 0px 0px 1rem;" align="initial">I have tested the build only for TMS570LS3137 now and when I find time I do more testing.</p>
<p dir="auto" style="color: #3a383f; margin: 0px 0px 1rem;" align="initial">I have found problem with <code style="font-size: 90%; color: #18171d; word-wrap: break-word; background-color: #ececef; border-radius: .25rem; margin-top: 0px; font-weight: inherit; overflow-wrap: break-word; white-space: break-spaces; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; word-break: keep-all; padding: 0.125rem 0.25rem;">TMS570_MMR_SELECT_GMII_SEL</code> which has been renamed to <code style="font-size: 90%; color: #18171d; word-wrap: break-word; background-color: #ececef; border-radius: .25rem; font-weight: inherit; overflow-wrap: break-word; white-space: break-spaces; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; word-break: keep-all; padding: 0.125rem 0.25rem;">TMS570_MMR_SELECT_MII_MODE</code> long time ago in the commit <a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/commit/3a0dcd5ee97dd150cdea9d1d2ca06e81f58436fc" title="bsp/tms570: Replace TMS570_MMR_SELECT_GMII_SEL" class="gfm gfm-commit has-tooltip" data-original="https://gitlab.rtems.org/rtems/rtos/rtems/-/commit/3a0dcd5ee97dd150cdea9d1d2ca06e81f58436fc" data-link="false" data-link-reference="true" data-commit="3a0dcd5ee97dd150cdea9d1d2ca06e81f58436fc" data-project="26" data-container="body" data-placement="top" data-reference-type="commit" style="font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; font-size: 95%;">rtems/rtos/rtems@3a0dcd5e</a> and has not propagated into LwIP. But that is not <a href="https://gitlab.rtems.org/ar-in0" title="Armaan Chowfin" class="gfm gfm-project_member js-user-link" data-user="2058" data-original="@ar-in0" data-container="body" data-placement="top" data-reference-type="user" style="color: #284779; background-color: #cbe2f9; border-radius: .25rem; padding: 0 2px;">@ar-in0</a> fault and needs to be updated anyway.</p>
<p dir="auto" style="color: #3a383f; margin: 0px 0px 1rem;" align="initial">As for the pins setup, I would suggest to use symbolic pins/balls defines if they are found in <a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/blob/main/bsps/arm/tms570/include/bsp/tms570lc4357-pins.h" style="margin-top: 0px;">bsps/arm/tms570/include/bsp/tms570lc4357-pins.h</a>. But that is not as critical for now.</p>
<p dir="auto" style="color: #3a383f; margin: 0px 0px 1rem;" align="initial">So generally this series represents lot of hard work and I will be happy if it reaches mainline.</p>
<p dir="auto" style="color: #3a383f; margin: 0px 0px 1rem;" align="initial">As for the errors indications, it can be related to some access to initialized Flash or RAM or elsewhere and it would wort to attempt to find it. It is possible that some RAM area does not have initialized parity bits or something similar. Clear by loop or memset could help or the initial memory tests can help.</p>
<p dir="auto" style="color: #3a383f; margin: 0px;" align="initial">As for endianness errata on TMS570LC4357, I am curious if the problem is the same if the descriptors are placed in regular SRAM, but there would be problem with caching which are much harder to solve for descriptors then for data. I expect that EMAC's CPPI RAM is uncached. But I can be wrong. I think that we have tested use of other RAM for buffer descriptors during initial TMS570 bringup, but I am not sure about that. But generally it seems that solution is correct and in conformance with HalCoGen solution.</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #626168;">
—
<br>
<a href="https://gitlab.rtems.org/rtems/pkg/rtems-lwip/-/merge_requests/48#note_154990">View it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.rtems.org">gitlab.rtems.org</a>. <a href="https://gitlab.rtems.org/-/sent_notifications/4-cfj57yq0pnn9paua0sv9daw1x-m/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.rtems.org/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.rtems.org/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<span style="color: transparent; font-size: 0; display: none; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0;">
Notification message regarding https://gitlab.rtems.org/rtems/pkg/rtems-lwip/-/merge_requests/48#note_154990 at 1784680488
</span>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.rtems.org/rtems/pkg/rtems-lwip/-/merge_requests/48#note_154990"}}</script>
</p>
</div>
</body>
</html>