<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style="--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;">
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: hsla(0,0%,100%,.01) 0 0 1px;
}
body {
font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style="font-size: inherit; -webkit-text-shadow: hsla(0,0%,100%,.01) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";">
<div class="content">
<p class="details" style="font-style: italic; color: #626168;">
Issue created by <a href="https://gitlab.rtems.org/joel">Joel Sherrill</a>: <a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/work_items/5736">#5736</a>
</p>
<p>
Assignee: Sebastian Huber
</p>
<div class="md" style="position: relative; z-index: 1; color: #3a383f; word-wrap: break-word;">
<h2 id="user-content-summary" dir="auto" style="margin-top: 0px; margin-bottom: 10px;" align="initial">Summary<a href="#summary" aria-label="Link to heading 'Summary'" data-heading-content="Summary" class="anchor" style="margin-top: 0px;"></a>
</h2>
<h2 id="user-content-summary-1" dir="auto" style="margin-top: 20px; margin-bottom: 10px;" align="initial">Summary<a href="#summary-1" aria-label="Link to heading 'Summary'" data-heading-content="Summary" class="anchor" style="margin-top: 0px;"></a>
</h2>
<p dir="auto" style="color: #3a383f; margin: 0px 0px 1rem;" align="initial">CID #1399703</p>
<p dir="auto" style="color: #3a383f; margin: 0px 0px 1rem;" align="initial">Coverity Scan detected taking the address of the <em style="margin-top: 0px;">uint32_t</em> <em>active_posix_keys</em> and treating it as an array.</p>
<div class="gl-relative markdown-code-block js-markdown-code" style="margin-bottom: 0px;">
<pre class="code highlight js-syntax-highlight language-plaintext" v-pre="true" style="display: block; font-size: 14px; color: #3a383f; line-height: 1.6em; overflow-x: auto; border-radius: .25rem; position: relative; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; margin: 0px 0 1rem; padding: 12px; border: 1px solid #dcdcde;"><code style="font-size: inherit; color: inherit; word-wrap: normal; word-break: keep-all; background-color: inherit; border-radius: .25rem; white-space: pre; margin-top: 0px; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; overflow-wrap: normal; padding: unset;"><span id="LC1" class="line" lang="plaintext" style="margin-top: 0px;">125 get_heap_info( RTEMS_Malloc_Heap, &snapshot->heap_info );</span>
<span id="LC2" class="line" lang="plaintext">126 get_heap_info( &_Workspace_Area, &snapshot->workspace_info );</span>
<span id="LC3" class="line" lang="plaintext">127</span>
<span id="LC4" class="line" lang="plaintext"> 1. address_of: Taking address with &snapshot->active_posix_keys yields a singleton pointer.</span>
<span id="LC5" class="line" lang="plaintext"> 2. assign: Assigning: active = &snapshot->active_posix_keys.</span>
<span id="LC6" class="line" lang="plaintext">128 active = &snapshot->active_posix_keys;</span>
<span id="LC7" class="line" lang="plaintext">/cpukit/include/rtems/libcsupport.h</span>
<span id="LC8" class="line" lang="plaintext">153 uint32_t active_posix_keys;</span>
<span id="LC9" class="line" lang="plaintext">129</span>
<span id="LC10" class="line" lang="plaintext"> 3. Condition i < 15U /* sizeof (objects_info_table) / sizeof (objects_info_table[0]) */, taking true branch.</span>
<span id="LC11" class="line" lang="plaintext">130 for ( i = 0; i < RTEMS_ARRAY_SIZE( objects_info_table ); ++i ) {</span>
<span id="LC12" class="line" lang="plaintext">131 const Objects_Information *information;</span>
<span id="LC13" class="line" lang="plaintext">132</span>
<span id="LC14" class="line" lang="plaintext">133 information = _Objects_Get_information(</span>
<span id="LC15" class="line" lang="plaintext">134 objects_info_table[ i ].api,</span>
<span id="LC16" class="line" lang="plaintext">135 objects_info_table[ i ].cls</span>
<span id="LC17" class="line" lang="plaintext">136 );</span>
<span id="LC18" class="line" lang="plaintext">137</span>
<span id="LC19" class="line" lang="plaintext"> 4. Condition information != NULL, taking true branch.</span>
<span id="LC20" class="line" lang="plaintext">138 if ( information != NULL ) {</span>
<span id="LC21" class="line" lang="plaintext"> </span>
<span id="LC22" class="line" lang="plaintext">CID 1399703: (#1 of 1): Out-of-bounds access (ARRAY_VS_SINGLETON)</span>
<span id="LC23" class="line" lang="plaintext">5. ptr_arith: Using active as an array. This might corrupt or misinterpret adjacent memory locations.</span>
<span id="LC24" class="line" lang="plaintext">139 active[ i ] = _Objects_Active_count( information );</span>
<span id="LC25" class="line" lang="plaintext">140 }</span>
<span id="LC26" class="line" lang="plaintext">141 }</span></code></pre>
<copy-code></copy-code><insert-code-snippet></insert-code-snippet>
</div>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #626168;">
—
<br>
<a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/work_items/5736">View it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.rtems.org">gitlab.rtems.org</a>. <a href="https://gitlab.rtems.org/-/sent_notifications/5-79byky9qyjeu7yoozgdxztguj-1d/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.rtems.org/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.rtems.org/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<span style="color: transparent; font-size: 0; display: none; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0;">
Notification message regarding https://gitlab.rtems.org/rtems/rtos/rtems/-/work_items/5736 at 1788193107
</span>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Work item","url":"https://gitlab.rtems.org/rtems/rtos/rtems/-/work_items/5736"}}</script>
</p>
</div>
</body>
</html>