<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style="--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;">
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: hsla(0,0%,100%,.01) 0 0 1px;
}
body {
font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style="font-size: inherit; -webkit-text-shadow: hsla(0,0%,100%,.01) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";">
<div class="content">
<div style="color: #333333; border-bottom-width: 8px; border-bottom-color: #ededed; border-bottom-style: solid; font-weight: bold; line-height: 1.4; padding: 20px 0;">
Merge request <a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1466">!1466</a> was reviewed by <a href="https://gitlab.rtems.org/chris">Chris Johns</a>
</div>
<p style="color: #777777;">
<a href="https://gitlab.rtems.org/chris">Chris Johns</a>
started a new
<a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1466#note_158630">discussion</a>:
</p>
<div class="md" style="border-bottom-width: 4px; border-bottom-color: #ededed; border-bottom-style: solid; padding-bottom: 1em; position: relative; z-index: 1; color: #3a383f; word-wrap: break-word;">
<p dir="auto" style="color: #3a383f; margin: 0px 0px 1rem;" align="initial">Can this please be included:</p>
<div class="gl-relative markdown-code-block js-markdown-code" style="margin-bottom: 0px;">
<pre data-canonical-lang="diff" class="code highlight js-syntax-highlight language-diff" v-pre="true" style="display: block; font-size: 14px; color: #3a383f; line-height: 1.6em; overflow-x: auto; border-radius: .25rem; position: relative; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; margin: 0px 0 1rem; padding: 12px; border: 1px solid #dcdcde;"><code style="font-size: inherit; color: inherit; word-wrap: normal; word-break: keep-all; background-color: inherit; border-radius: .25rem; white-space: pre; margin-top: 0px; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; overflow-wrap: normal; padding: unset;"><span id="LC1" class="line" lang="diff" style="margin-top: 0px;"><span class="gh" style="margin-top: 0px;">diff --git a/testsuites/libtests/tar01/init.c b/testsuites/libtests/tar01/init.c</span></span>
<span id="LC2" class="line" lang="diff"><span class="gh" style="margin-top: 0px;">index 8e2b1c1325..ba2e655301 100644</span></span>
<span id="LC3" class="line" lang="diff"><span class="gd" style="margin-top: 0px;">--- a/testsuites/libtests/tar01/init.c</span></span>
<span id="LC4" class="line" lang="diff"><span class="gi" style="margin-top: 0px;">+++ b/testsuites/libtests/tar01/init.c</span></span>
<span id="LC5" class="line" lang="diff"><span class="p" style="margin-top: 0px;">@@ -69,6 +69,7 @@</span></span>
<span id="LC6" class="line" lang="diff"> #include <fcntl.h></span>
<span id="LC7" class="line" lang="diff"> #include <unistd.h></span>
<span id="LC8" class="line" lang="diff"></span>
<span id="LC9" class="line" lang="diff"><span class="gi" style="margin-top: 0px;">+#include "test_support.h"</span></span>
<span id="LC10" class="line" lang="diff"> #include "tar01-tar.h"</span>
<span id="LC11" class="line" lang="diff"> #include "tar01-tar-gz.h"</span>
<span id="LC12" class="line" lang="diff"> #if HAVE_XZ</span>
<span id="LC13" class="line" lang="diff"><span class="p" style="margin-top: 0px;">@@ -94,8 +95,6 @@</span> void test_untar_unzip_txz( void );</span>
<span id="LC14" class="line" lang="diff"> #define TARFILE_XZ_SIZE tar01_tar_xz_size</span>
<span id="LC15" class="line" lang="diff"> #endif</span>
<span id="LC16" class="line" lang="diff"></span>
<span id="LC17" class="line" lang="diff"><span class="gd" style="margin-top: 0px;">-void test_cat( char *file, int offset_arg, int length );</span></span>
<span id="LC18" class="line" lang="diff"><span class="gd" style="margin-top: 0px;">-</span></span>
<span id="LC19" class="line" lang="diff"> static void test_untar_check_mode( const char *file, int mode )</span>
<span id="LC20" class="line" lang="diff"> {</span>
<span id="LC21" class="line" lang="diff"> struct stat sb;</span></code></pre>
<copy-code></copy-code><insert-code-snippet></insert-code-snippet>
</div>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #626168;">
—
<br>
<a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1466">View it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.rtems.org">gitlab.rtems.org</a>. <a href="https://gitlab.rtems.org/-/sent_notifications/5-dzhckwyb4otp0iny7tqr6dphx-1d/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.rtems.org/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.rtems.org/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<span style="color: transparent; font-size: 0; display: none; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0;">
Notification message regarding https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1466 at 1788410224
</span>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1466"}}</script>
</p>
</div>
</body>
</html>