<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style="--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;">
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<title>
GitLab
</title>

<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>


<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: hsla(0,0%,100%,.01) 0 0 1px;
}
body {
font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style="font-size: inherit; -webkit-text-shadow: hsla(0,0%,100%,.01) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";">
<div class="content">

<p style="color: #777777;">
<a href="https://gitlab.rtems.org/matteo.concas">Matteo Concas</a>
commented on a
discussion on <a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1498#note_159744">bsps/sparc/leon3/start/amba.c</a>:
</p>
<table class="code gl-mb-5" style="border-spacing: 0; margin-bottom: 1rem; border-collapse: collapse; width: auto; font-family: monospace; font-size: 90%;" bgcolor="#ffffff" width="100%" cellpadding="0" cellspacing="0">
<tr class="line_holder" style="line-height: 1.6;">
<td class="old_line diff-line-num" data-linenumber="127" style="width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-color: #ececef; border-right-style: solid; padding: inherit;" align="right" bgcolor="#fbfafd">
127
</td>
<td class="new_line diff-line-num" data-linenumber="127" style="width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-color: #ececef; border-right-style: solid; padding: inherit;" align="right" bgcolor="#fbfafd">
127
</td>
<td class="line_content" style="padding: inherit;"><pre style="display: block; font-size: 14px; color: #3a383f; position: relative; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; word-break: break-all; word-wrap: break-word; background-color: inherit; border-radius: 2px; margin: 0; padding: 0; border: inherit solid #dcdcde;"> <span class="line" data-lang="c">  <span class="n" style="color: #333333;">ambapp_grlib_root_register</span><span class="p">(</span> <span class="o" style="font-weight: 600;">&</span><span class="n" style="color: #333333;">grlib_bus_config</span> <span class="p">);</span></span>
</pre></td>
</tr>
<tr class="line_holder" style="line-height: 1.6;">
<td class="old_line diff-line-num" data-linenumber="128" style="width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-color: #ececef; border-right-style: solid; padding: inherit;" align="right" bgcolor="#fbfafd">
128
</td>
<td class="new_line diff-line-num" data-linenumber="128" style="width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-color: #ececef; border-right-style: solid; padding: inherit;" align="right" bgcolor="#fbfafd">
128
</td>
<td class="line_content" style="padding: inherit;"><pre style="display: block; font-size: 14px; color: #3a383f; position: relative; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; word-break: break-all; word-wrap: break-word; background-color: inherit; border-radius: 2px; margin: 0; padding: 0; border: inherit solid #dcdcde;"> <span class="line" data-lang="c"><span class="p">}</span></span>
</pre></td>
</tr>
<tr class="line_holder" style="line-height: 1.6;">
<td class="old_line diff-line-num" data-linenumber="129" style="width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-color: #ececef; border-right-style: solid; padding: inherit;" align="right" bgcolor="#fbfafd">
129
</td>
<td class="new_line diff-line-num" data-linenumber="129" style="width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-color: #ececef; border-right-style: solid; padding: inherit;" align="right" bgcolor="#fbfafd">
129
</td>
<td class="line_content" style="padding: inherit;"><pre style="display: block; font-size: 14px; color: #3a383f; position: relative; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; word-break: break-all; word-wrap: break-word; background-color: inherit; border-radius: 2px; margin: 0; padding: 0; border: inherit solid #dcdcde;"> <span class="line" data-lang="c"></span>
</pre></td>
</tr>
<tr class="line_holder old" style="line-height: 1.6;">
<td class="old_line diff-line-num old" data-linenumber="130" style="width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: inherit;" align="right" bgcolor="#f9d7dc">
130
</td>
<td class="new_line diff-line-num old" data-linenumber="130" style="width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: inherit;" align="right" bgcolor="#f9d7dc">
 
</td>
<td class="line_content old" style="padding: inherit;" bgcolor="#fbe9eb"><pre style="display: block; font-size: 14px; color: #3a383f; position: relative; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; word-break: break-all; word-wrap: break-word; background-color: inherit; border-radius: 2px; margin: 0; padding: 0; border: inherit solid #dcdcde;">-<span class="line" data-lang="c"><span class="n" style="color: #333333;">RTEMS_SYSINIT_ITEM</span><span class="p">(</span></span>
</pre></td>
</tr>

</table>
<div class="md" style="position: relative; z-index: 1; color: #3a383f; word-wrap: break-word;">
<p dir="auto" style="color: #3a383f; margin: 0px 0px 1rem;" align="initial">Reverting the change with this diff:</p>
<div class="gl-relative markdown-code-block js-markdown-code">
<pre data-canonical-lang="diff" class="code highlight js-syntax-highlight language-diff" v-pre="true" style="display: block; font-size: 90%; color: #3a383f; line-height: 1.6em; overflow-x: auto; border-radius: .25rem; position: relative; font-family: monospace; font-variant-ligatures: none; word-break: break-all; word-wrap: break-word; background-color: #ffffff; -premailer-cellpadding: 0; -premailer-cellspacing: 0; -premailer-width: 100%; margin: 0px 0 1rem; padding: 12px; border: 1px solid #dcdcde;"><code style="font-size: inherit; color: inherit; word-wrap: normal; word-break: keep-all; background-color: inherit; border-radius: .25rem; white-space: pre; margin-top: 0px; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; overflow-wrap: normal; padding: unset;"><span id="LC1" class="line" data-lang="diff" style="margin-top: 0px;"><span class="gh" style="margin-top: 0px; color: #800080; font-weight: 600;">diff --git a/bsps/include/grlib/ambapp_bus_grlib.h b/bsps/include/grlib/ambapp_bus_grlib.h</span></span>
<span id="LC2" class="line" data-lang="diff"><span class="gh" style="margin-top: 0px; color: #800080; font-weight: 600;">index e942ecb05c..dc9ed27cd0 100644</span></span>
<span id="LC3" class="line" data-lang="diff"><span class="gd" style="margin-top: 0px; color: #000000; background-color: #ffdddd;">--- a/bsps/include/grlib/ambapp_bus_grlib.h</span></span>
<span id="LC4" class="line" data-lang="diff"><span class="gi" style="margin-top: 0px; color: #000000; background-color: #ddffdd;">+++ b/bsps/include/grlib/ambapp_bus_grlib.h</span></span>
<span id="LC5" class="line" data-lang="diff"><span class="p" style="margin-top: 0px;">@@ -48,11 +48,6 @@</span> extern int ambapp_grlib_root_register( struct grlib_config *config );</span>
<span id="LC6" class="line" data-lang="diff"> /* Register bus driver to Driver Manager */</span>
<span id="LC7" class="line" data-lang="diff"> void ambapp_grlib_register( void );</span>
<span id="LC8" class="line" data-lang="diff"> </span>
<span id="LC9" class="line" data-lang="diff"><span class="gd" style="margin-top: 0px; color: #000000; background-color: #ffdddd;">-/* Initialize GRLIB AMBA PnP root bus for Driver Manager.</span></span>
<span id="LC10" class="line" data-lang="diff"><span class="gd" style="margin-top: 0px; color: #000000; background-color: #ffdddd;">- * This is called during system initialization to register the root bus.</span></span>
<span id="LC11" class="line" data-lang="diff"><span class="gd" style="margin-top: 0px; color: #000000; background-color: #ffdddd;">- */</span></span>
<span id="LC12" class="line" data-lang="diff"><span class="gd" style="margin-top: 0px; color: #000000; background-color: #ffdddd;">-void ambapp_grlib_root_initialize( void );</span></span>
<span id="LC13" class="line" data-lang="diff"><span class="gd" style="margin-top: 0px; color: #000000; background-color: #ffdddd;">-</span></span>
<span id="LC14" class="line" data-lang="diff"> #ifdef __cplusplus</span>
<span id="LC15" class="line" data-lang="diff"> }</span>
<span id="LC16" class="line" data-lang="diff"> #endif</span>
<span id="LC17" class="line" data-lang="diff"><span class="gh" style="margin-top: 0px; color: #800080; font-weight: 600;">diff --git a/bsps/sparc/leon3/start/amba.c b/bsps/sparc/leon3/start/amba.c</span></span>
<span id="LC18" class="line" data-lang="diff"><span class="gh" style="margin-top: 0px; color: #800080; font-weight: 600;">index a0c1dc7520..ec87417bc6 100644</span></span>
<span id="LC19" class="line" data-lang="diff"><span class="gd" style="margin-top: 0px; color: #000000; background-color: #ffdddd;">--- a/bsps/sparc/leon3/start/amba.c</span></span>
<span id="LC20" class="line" data-lang="diff"><span class="gi" style="margin-top: 0px; color: #000000; background-color: #ddffdd;">+++ b/bsps/sparc/leon3/start/amba.c</span></span>
<span id="LC21" class="line" data-lang="diff"><span class="p" style="margin-top: 0px;">@@ -119,7 +119,7 @@</span> struct drvmgr_bus_res grlib_drv_resources __attribute__(( weak )) = {</span>
<span id="LC22" class="line" data-lang="diff"> /* GRLIB AMBA bus configuration (the LEON3 root bus configuration) */</span>
<span id="LC23" class="line" data-lang="diff"> struct grlib_config grlib_bus_config;</span>
<span id="LC24" class="line" data-lang="diff"> </span>
<span id="LC25" class="line" data-lang="diff"><span class="gd" style="margin-top: 0px; color: #000000; background-color: #ffdddd;">-void ambapp_grlib_root_initialize( void )</span></span>
<span id="LC26" class="line" data-lang="diff"><span class="gi" style="margin-top: 0px; color: #000000; background-color: #ddffdd;">+static void ambapp_grlib_root_initialize( void )</span></span>
<span id="LC27" class="line" data-lang="diff"> {</span>
<span id="LC28" class="line" data-lang="diff">   /* Register Root bus, Use GRLIB AMBA PnP bus as root bus for LEON3 */</span>
<span id="LC29" class="line" data-lang="diff">   grlib_bus_config.abus = ambapp_plb();</span>
<span id="LC30" class="line" data-lang="diff"><span class="p" style="margin-top: 0px;">@@ -127,6 +127,12 @@</span> void ambapp_grlib_root_initialize( void )</span>
<span id="LC31" class="line" data-lang="diff">   ambapp_grlib_root_register( &grlib_bus_config );</span>
<span id="LC32" class="line" data-lang="diff"> }</span>
<span id="LC33" class="line" data-lang="diff"> </span>
<span id="LC34" class="line" data-lang="diff"><span class="gi" style="margin-top: 0px; color: #000000; background-color: #ddffdd;">+RTEMS_SYSINIT_ITEM(</span></span>
<span id="LC35" class="line" data-lang="diff"><span class="gi" style="margin-top: 0px; color: #000000; background-color: #ddffdd;">+  ambapp_grlib_root_initialize,</span></span>
<span id="LC36" class="line" data-lang="diff"><span class="gi" style="margin-top: 0px; color: #000000; background-color: #ddffdd;">+  RTEMS_SYSINIT_BSP_START,</span></span>
<span id="LC37" class="line" data-lang="diff"><span class="gi" style="margin-top: 0px; color: #000000; background-color: #ddffdd;">+  RTEMS_SYSINIT_ORDER_SECOND</span></span>
<span id="LC38" class="line" data-lang="diff"><span class="gi" style="margin-top: 0px; color: #000000; background-color: #ddffdd;">+);</span></span>
<span id="LC39" class="line" data-lang="diff"><span class="gi" style="margin-top: 0px; color: #000000; background-color: #ddffdd;">+</span></span>
<span id="LC40" class="line" data-lang="diff"> #endif</span>
<span id="LC41" class="line" data-lang="diff"> </span>
<span id="LC42" class="line" data-lang="diff"> #if !defined( LEON3_IRQAMP_BASE )</span>
<span id="LC43" class="line" data-lang="diff"><span class="gh" style="margin-top: 0px; color: #800080; font-weight: 600;">diff --git a/cpukit/include/rtems/confdefs/drvmgr.h b/cpukit/include/rtems/confdefs/drvmgr.h</span></span>
<span id="LC44" class="line" data-lang="diff"><span class="gh" style="margin-top: 0px; color: #800080; font-weight: 600;">index 674d768b08..b1fefaa886 100644</span></span>
<span id="LC45" class="line" data-lang="diff"><span class="gd" style="margin-top: 0px; color: #000000; background-color: #ffdddd;">--- a/cpukit/include/rtems/confdefs/drvmgr.h</span></span>
<span id="LC46" class="line" data-lang="diff"><span class="gi" style="margin-top: 0px; color: #000000; background-color: #ddffdd;">+++ b/cpukit/include/rtems/confdefs/drvmgr.h</span></span>
<span id="LC47" class="line" data-lang="diff"><span class="p" style="margin-top: 0px;">@@ -147,21 +147,6 @@</span> RTEMS_SYSINIT_ITEM(</span>
<span id="LC48" class="line" data-lang="diff">   RTEMS_SYSINIT_ORDER_MIDDLE</span>
<span id="LC49" class="line" data-lang="diff"> );</span>
<span id="LC50" class="line" data-lang="diff"> </span>
<span id="LC51" class="line" data-lang="diff"><span class="gd" style="margin-top: 0px; color: #000000; background-color: #ffdddd;">-/*</span></span>
<span id="LC52" class="line" data-lang="diff"><span class="gd" style="margin-top: 0px; color: #000000; background-color: #ffdddd;">- * BSP-specific root bus registration for GRLIB AMBA Plug & Play systems.</span></span>
<span id="LC53" class="line" data-lang="diff"><span class="gd" style="margin-top: 0px; color: #000000; background-color: #ffdddd;">- * This pulls in the AMBA PnP bus scanning and root bus registration from</span></span>
<span id="LC54" class="line" data-lang="diff"><span class="gd" style="margin-top: 0px; color: #000000; background-color: #ffdddd;">- * the BSP library.</span></span>
<span id="LC55" class="line" data-lang="diff"><span class="gd" style="margin-top: 0px; color: #000000; background-color: #ffdddd;">- */</span></span>
<span id="LC56" class="line" data-lang="diff"><span class="gd" style="margin-top: 0px; color: #000000; background-color: #ffdddd;">-#if ( defined( LEON3 ) || defined( NOELV ) )</span></span>
<span id="LC57" class="line" data-lang="diff"><span class="gd" style="margin-top: 0px; color: #000000; background-color: #ffdddd;">-#include <grlib/ambapp_bus_grlib.h></span></span>
<span id="LC58" class="line" data-lang="diff"><span class="gd" style="margin-top: 0px; color: #000000; background-color: #ffdddd;">-</span></span>
<span id="LC59" class="line" data-lang="diff"><span class="gd" style="margin-top: 0px; color: #000000; background-color: #ffdddd;">-RTEMS_SYSINIT_ITEM(</span></span>
<span id="LC60" class="line" data-lang="diff"><span class="gd" style="margin-top: 0px; color: #000000; background-color: #ffdddd;">-  ambapp_grlib_root_initialize,</span></span>
<span id="LC61" class="line" data-lang="diff"><span class="gd" style="margin-top: 0px; color: #000000; background-color: #ffdddd;">-  RTEMS_SYSINIT_BSP_START,</span></span>
<span id="LC62" class="line" data-lang="diff"><span class="gd" style="margin-top: 0px; color: #000000; background-color: #ffdddd;">-  RTEMS_SYSINIT_ORDER_SECOND</span></span>
<span id="LC63" class="line" data-lang="diff"><span class="gd" style="margin-top: 0px; color: #000000; background-color: #ffdddd;">-);</span></span>
<span id="LC64" class="line" data-lang="diff"><span class="gd" style="margin-top: 0px; color: #000000; background-color: #ffdddd;">-#endif</span></span>
<span id="LC65" class="line" data-lang="diff"><span class="gd" style="margin-top: 0px; color: #000000; background-color: #ffdddd;">-</span></span>
<span id="LC66" class="line" data-lang="diff"> #ifdef __cplusplus</span>
<span id="LC67" class="line" data-lang="diff"> }</span>
<span id="LC68" class="line" data-lang="diff"> #endif</span>
<span id="LC69" class="line" data-lang="diff"></span></code></pre>
<copy-code></copy-code><insert-code-snippet></insert-code-snippet>
</div>
<p dir="auto" style="color: #3a383f; margin: 0px 0px 1rem;" align="initial">Gives the same result as before this MR:</p>
<div class="gl-relative markdown-code-block js-markdown-code">
<pre class="code highlight js-syntax-highlight language-plaintext" v-pre="true" style="display: block; font-size: 90%; color: #3a383f; line-height: 1.6em; overflow-x: auto; border-radius: .25rem; position: relative; font-family: monospace; font-variant-ligatures: none; word-break: break-all; word-wrap: break-word; background-color: #ffffff; -premailer-cellpadding: 0; -premailer-cellspacing: 0; -premailer-width: 100%; margin: 0px 0 1rem; padding: 12px; border: 1px solid #dcdcde;"><code style="font-size: inherit; color: inherit; word-wrap: normal; word-break: keep-all; background-color: inherit; border-radius: .25rem; white-space: pre; margin-top: 0px; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; overflow-wrap: normal; padding: unset;"><span id="LC1" class="line" data-lang="plaintext" style="margin-top: 0px;">Passed:        222</span>
<span id="LC2" class="line" data-lang="plaintext">Failed:        472</span>
<span id="LC3" class="line" data-lang="plaintext">User Input:      0</span>
<span id="LC4" class="line" data-lang="plaintext">Expected Fail:   0</span>
<span id="LC5" class="line" data-lang="plaintext">Indeterminate:   0</span>
<span id="LC6" class="line" data-lang="plaintext">Benchmark:       0</span>
<span id="LC7" class="line" data-lang="plaintext">Timeout:         2</span>
<span id="LC8" class="line" data-lang="plaintext">Test too long:   0</span>
<span id="LC9" class="line" data-lang="plaintext">Invalid:         1</span>
<span id="LC10" class="line" data-lang="plaintext">Wrong Version:   0</span>
<span id="LC11" class="line" data-lang="plaintext">Wrong Build:     0</span>
<span id="LC12" class="line" data-lang="plaintext">Wrong Tools:     0</span>
<span id="LC13" class="line" data-lang="plaintext">Wrong Header:    0</span>
<span id="LC14" class="line" data-lang="plaintext">------------------</span>
<span id="LC15" class="line" data-lang="plaintext">Total:         697</span>
<span id="LC16" class="line" data-lang="plaintext"></span>
<span id="LC17" class="line" data-lang="plaintext">Failures:</span>
<span id="LC18" class="line" data-lang="plaintext"> psxdevctl01.exe</span>
<span id="LC19" class="line" data-lang="plaintext"> termios02.exe</span>
<span id="LC20" class="line" data-lang="plaintext"> ts-fatal-idle-thread-create-failed.exe</span>
<span id="LC21" class="line" data-lang="plaintext"> ts-fatal-init-task-construct-failed.exe</span>
<span id="LC22" class="line" data-lang="plaintext"> ts-fatal-sparc-leon3-clock-initialization.exe</span>
<span id="LC23" class="line" data-lang="plaintext"> ts-performance-no-clock-0.exe</span>
<span id="LC24" class="line" data-lang="plaintext"> ts-validation-intr.exe</span>
<span id="LC25" class="line" data-lang="plaintext"> block05.exe</span>
<span id="LC26" class="line" data-lang="plaintext"> block06.exe</span>
<span id="LC27" class="line" data-lang="plaintext">[...]</span></code></pre>
<copy-code></copy-code><insert-code-snippet></insert-code-snippet>
</div>
<p dir="auto" style="color: #3a383f; margin: 0px;" align="initial">And no ambapp symbol is found in test binaries.</p>
</div>


</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #626168;">
—
<br>
<a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1498#note_159744">View it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.rtems.org">gitlab.rtems.org</a>. <a href="https://gitlab.rtems.org/-/namespace/49/sent_notifications/5-67r922xh6ij7s40llc8sb3yx4-1d/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.rtems.org/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.rtems.org/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<span style="color: transparent; font-size: 0; display: none; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0;">
Notification message regarding https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1498#note_159744 at 1790062867
</span>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1498#note_159744"}}</script>


</p>
</div>
</body>
</html>