<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style="--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;">
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<title>
GitLab
</title>

<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>

<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: hsla(0,0%,100%,.01) 0 0 1px;
}
body {
font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style="font-size: inherit; -webkit-text-shadow: hsla(0,0%,100%,.01) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";">
<div class="content">

<p style="color: #777777;">
<a href="https://gitlab.rtems.org/sebhub">Sebastian Huber</a>
commented on a
<a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1527#note_161047">discussion</a>:
</p>
<div class="md" style="position: relative; z-index: 1; color: #3a383f; word-wrap: break-word;">
<p dir="auto" style="color: #3a383f; margin: 0px 0px 1rem;" align="initial">Sorry, I overlooked your MR. I also really don't know why this generally useful change is blocked. <a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1043" title=".clang-format-ignore: add ignore file" class="gfm gfm-merge_request" data-original="!1043" data-link="false" data-link-reference="false" data-merge-request="2127" data-project="26" data-project-path="rtems/rtos/rtems" data-iid="1043" data-container="body" data-placement="top" data-reference-type="merge_request" style="margin-top: 0px;">!1043</a> and <a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1531" title="rtems: Add a clang-format ignore file" class="gfm gfm-merge_request" data-original="!1531" data-link="false" data-link-reference="false" data-merge-request="3081" data-project="26" data-project-path="rtems/rtos/rtems" data-iid="1531" data-container="body" data-placement="top" data-reference-type="merge_request">!1531</a> have the same goal. On main (<a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/commit/10e3cf67d6eb1a28769930e3e40488beb194a76f" title="score: Speed up the red-black tree rebalance" class="gfm gfm-commit has-tooltip" data-original="10e3cf67d6e" data-link="false" data-link-reference="false" data-commit="10e3cf67d6eb1a28769930e3e40488beb194a76f" data-project="26" data-project-path="rtems/rtos/rtems" data-container="body" data-placement="top" data-reference-type="commit" style="font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; font-size: 95%;">10e3cf67</a>) with clang-format 22.1.8, 454 sources outside the <a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1043" title=".clang-format-ignore: add ignore file" class="gfm gfm-merge_request" data-original="!1043" data-link="false" data-link-reference="false" data-merge-request="2127" data-project="26" data-project-path="rtems/rtos/rtems" data-iid="1043" data-container="body" data-placement="top" data-reference-type="merge_request">!1043</a> ignore list need a reformat. With <a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1531" title="rtems: Add a clang-format ignore file" class="gfm gfm-merge_request" data-original="!1531" data-link="false" data-link-reference="false" data-merge-request="3081" data-project="26" data-project-path="rtems/rtos/rtems" data-iid="1531" data-container="body" data-placement="top" data-reference-type="merge_request">!1531</a> the count is 293. The patterns <code style="font-size: 90%; color: #18171d; word-wrap: break-word; background-color: #ececef; border-radius: .25rem; font-weight: inherit; overflow-wrap: break-word; white-space: break-spaces; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; word-break: keep-all; padding: 0.125rem 0.25rem;">testsuites/ada</code> and <code style="font-size: 90%; color: #18171d; word-wrap: break-word; background-color: #ececef; border-radius: .25rem; font-weight: inherit; overflow-wrap: break-word; white-space: break-spaces; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; word-break: keep-all; padding: 0.125rem 0.25rem;">testsuites/benchmarks</code> in <a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1043" title=".clang-format-ignore: add ignore file" class="gfm gfm-merge_request" data-original="!1043" data-link="false" data-link-reference="false" data-merge-request="2127" data-project="26" data-project-path="rtems/rtos/rtems" data-iid="1043" data-container="body" data-placement="top" data-reference-type="merge_request">!1043</a> lack <code style="font-size: 90%; color: #18171d; word-wrap: break-word; background-color: #ececef; border-radius: .25rem; font-weight: inherit; overflow-wrap: break-word; white-space: break-spaces; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; word-break: keep-all; padding: 0.125rem 0.25rem;">/**</code> and match no file. <a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1043" title=".clang-format-ignore: add ignore file" class="gfm gfm-merge_request" data-original="!1043" data-link="false" data-link-reference="false" data-merge-request="2127" data-project="26" data-project-path="rtems/rtos/rtems" data-iid="1043" data-container="body" data-placement="top" data-reference-type="merge_request">!1043</a> also misses the generated image headers of fdt01 and fsdosfsname01, libi2c and the unformatted headers in cpukit/include/rtems. <a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1531" title="rtems: Add a clang-format ignore file" class="gfm gfm-merge_request" data-original="!1531" data-link="false" data-link-reference="false" data-merge-request="3081" data-project="26" data-project-path="rtems/rtos/rtems" data-iid="1531" data-container="body" data-placement="top" data-reference-type="merge_request">!1531</a> misses cpukit/libmisc/rtems-fdt. I will add it.</p>
<p dir="auto" style="color: #3a383f; margin: 0px 0px 1rem;" align="initial">The two merge requests treat the BSPs in opposite ways:</p>
<table dir="auto" style="border-spacing: 0; text-align: initial; color: #3a383f; width: auto; border-collapse: collapse; border-width: 0;">
<thead style="margin-top: 0px;">
<tr style="margin-top: 0px;">
<th style="line-height: 1.25rem; color: #18171d; margin-top: 0px; padding: 10px 16px; border-color: #dcdcde; border-style: solid; border-width: 1px 1px 0;" valign="top"></th>
<th style="line-height: 1.25rem; color: #18171d; padding: 10px 16px; border-color: #dcdcde; border-style: solid; border-width: 1px 1px 0;" valign="top"><a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1043" title=".clang-format-ignore: add ignore file" class="gfm gfm-merge_request" data-original="!1043" data-link="false" data-link-reference="false" data-merge-request="2127" data-project="26" data-project-path="rtems/rtos/rtems" data-iid="1043" data-container="body" data-placement="top" data-reference-type="merge_request" style="margin-top: 0px;">!1043</a></th>
<th style="line-height: 1.25rem; color: #18171d; padding: 10px 16px; border-color: #dcdcde; border-style: solid; border-width: 1px 1px 0;" valign="top"><a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1531" title="rtems: Add a clang-format ignore file" class="gfm gfm-merge_request" data-original="!1531" data-link="false" data-link-reference="false" data-merge-request="3081" data-project="26" data-project-path="rtems/rtos/rtems" data-iid="1531" data-container="body" data-placement="top" data-reference-type="merge_request" style="margin-top: 0px;">!1531</a></th>
</tr>
</thead>
<tbody>
<tr style="margin-top: 0px;">
<td style="line-height: 1.25rem; margin-top: 0px; padding: 10px 16px; border: 1px solid #dcdcde;" valign="top">Method</td>
<td style="line-height: 1.25rem; padding: 10px 16px; border: 1px solid #dcdcde;" valign="top">One line per ignored BSP directory</td>
<td style="line-height: 1.25rem; padding: 10px 16px; border: 1px solid #dcdcde;" valign="top">
<code style="font-size: 90%; color: #18171d; word-wrap: break-word; background-color: #ececef; border-radius: .25rem; margin-top: 0px; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; white-space: pre-wrap; overflow-wrap: break-word; word-break: keep-all; padding: 0.125rem 0.25rem;">bsps/**</code>, and an empty <code style="font-size: 90%; color: #18171d; word-wrap: break-word; background-color: #ececef; border-radius: .25rem; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; white-space: pre-wrap; overflow-wrap: break-word; word-break: keep-all; padding: 0.125rem 0.25rem;">.clang-format-ignore</code> in each formatted directory</td>
</tr>
<tr>
<td style="line-height: 1.25rem; margin-top: 0px; padding: 10px 16px; border: 1px solid #dcdcde;" valign="top">Default for a new BSP directory</td>
<td style="line-height: 1.25rem; padding: 10px 16px; border: 1px solid #dcdcde;" valign="top">Formatted</td>
<td style="line-height: 1.25rem; padding: 10px 16px; border: 1px solid #dcdcde;" valign="top">Ignored</td>
</tr>
<tr>
<td style="line-height: 1.25rem; margin-top: 0px; padding: 10px 16px; border: 1px solid #dcdcde;" valign="top">Turn on a formatted directory</td>
<td style="line-height: 1.25rem; padding: 10px 16px; border: 1px solid #dcdcde;" valign="top">Delete a line</td>
<td style="line-height: 1.25rem; padding: 10px 16px; border: 1px solid #dcdcde;" valign="top">Add a file in that directory</td>
</tr>
<tr>
<td style="line-height: 1.25rem; margin-top: 0px; padding: 10px 16px; border: 1px solid #dcdcde;" valign="top">Where to read the state</td>
<td style="line-height: 1.25rem; padding: 10px 16px; border: 1px solid #dcdcde;" valign="top">One file</td>
<td style="line-height: 1.25rem; padding: 10px 16px; border: 1px solid #dcdcde;" valign="top">The top file and the files below <code style="font-size: 90%; color: #18171d; word-wrap: break-word; background-color: #ececef; border-radius: .25rem; margin-top: 0px; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; white-space: pre-wrap; overflow-wrap: break-word; word-break: keep-all; padding: 0.125rem 0.25rem;">bsps/</code>
</td>
</tr>
<tr>
<td style="line-height: 1.25rem; margin-top: 0px; padding: 10px 16px; border: 1px solid #dcdcde;" valign="top">Patterns below a formatted directory</td>
<td style="line-height: 1.25rem; padding: 10px 16px; border: 1px solid #dcdcde;" valign="top">The top file applies</td>
<td style="line-height: 1.25rem; padding: 10px 16px; border: 1px solid #dcdcde;" valign="top">A file in a subdirectory replaces the top file. Every pattern needed below it must be repeated there.</td>
</tr>
<tr>
<td style="line-height: 1.25rem; margin-top: 0px; padding: 10px 16px; border: 1px solid #dcdcde;" valign="top"><code style="font-size: 90%; color: #18171d; word-wrap: break-word; background-color: #ececef; border-radius: .25rem; margin-top: 0px; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; white-space: pre-wrap; overflow-wrap: break-word; word-break: keep-all; padding: 0.125rem 0.25rem;">bsps/riscv/noel</code></td>
<td style="line-height: 1.25rem; padding: 10px 16px; border: 1px solid #dcdcde;" valign="top">Formatted. One of its 6 sources needs a reformat.</td>
<td style="line-height: 1.25rem; padding: 10px 16px; border: 1px solid #dcdcde;" valign="top">Ignored</td>
</tr>
<tr>
<td style="line-height: 1.25rem; margin-top: 0px; padding: 10px 16px; border: 1px solid #dcdcde;" valign="top"><code style="font-size: 90%; color: #18171d; word-wrap: break-word; background-color: #ececef; border-radius: .25rem; margin-top: 0px; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; white-space: pre-wrap; overflow-wrap: break-word; word-break: keep-all; padding: 0.125rem 0.25rem;">bsps/shared/grlib</code></td>
<td style="line-height: 1.25rem; padding: 10px 16px; border: 1px solid #dcdcde;" valign="top">Ignored</td>
<td style="line-height: 1.25rem; padding: 10px 16px; border: 1px solid #dcdcde;" valign="top">Formatted. One of its 67 sources needs a reformat.</td>
</tr>
</tbody>
</table>
<p dir="auto" style="color: #3a383f; margin: 0px 0px 1rem;" align="initial">In <a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1043" title=".clang-format-ignore: add ignore file" class="gfm gfm-merge_request" data-original="!1043" data-link="false" data-link-reference="false" data-merge-request="2127" data-project="26" data-project-path="rtems/rtos/rtems" data-iid="1043" data-container="body" data-placement="top" data-reference-type="merge_request" style="margin-top: 0px;">!1043</a>, a new BSP directory is formatted with no review of its code. In <a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1531" title="rtems: Add a clang-format ignore file" class="gfm gfm-merge_request" data-original="!1531" data-link="false" data-link-reference="false" data-merge-request="3081" data-project="26" data-project-path="rtems/rtos/rtems" data-iid="1531" data-container="body" data-placement="top" data-reference-type="merge_request">!1531</a>, nobody has to edit the ignore list for a new BSP until it follows the style. Today no <code style="font-size: 90%; color: #18171d; word-wrap: break-word; background-color: #ececef; border-radius: .25rem; font-weight: inherit; overflow-wrap: break-word; white-space: break-spaces; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; word-break: keep-all; padding: 0.125rem 0.25rem;">contrib</code> code lies below the three formatted directories of <a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1531" title="rtems: Add a clang-format ignore file" class="gfm gfm-merge_request" data-original="!1531" data-link="false" data-link-reference="false" data-merge-request="3081" data-project="26" data-project-path="rtems/rtos/rtems" data-iid="1531" data-container="body" data-placement="top" data-reference-type="merge_request">!1531</a>. So the replacement rule costs nothing for now.</p>
<p dir="auto" style="color: #3a383f; margin: 0px;" align="initial">I propose to continue with <a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1531" title="rtems: Add a clang-format ignore file" class="gfm gfm-merge_request" data-original="!1531" data-link="false" data-link-reference="false" data-merge-request="3081" data-project="26" data-project-path="rtems/rtos/rtems" data-iid="1531" data-container="body" data-placement="top" data-reference-type="merge_request" style="margin-top: 0px;">!1531</a> and to close <a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1043" title=".clang-format-ignore: add ignore file" class="gfm gfm-merge_request" data-original="!1043" data-link="false" data-link-reference="false" data-merge-request="2127" data-project="26" data-project-path="rtems/rtos/rtems" data-iid="1043" data-container="body" data-placement="top" data-reference-type="merge_request">!1043</a>, or the reverse if you prefer your layout.</p>
</div>


</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #626168;">
—
<br>
<a href="https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1527#note_161047">View it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.rtems.org">gitlab.rtems.org</a>. <a href="https://gitlab.rtems.org/-/namespace/49/sent_notifications/6-9mmvvh4a3ri83xbi5lc7pdmnb-1d/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.rtems.org/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.rtems.org/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<span style="color: transparent; font-size: 0; display: none; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0;">
Notification message regarding https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1527#note_161047 at 1791953340
</span>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1527#note_161047"}}</script>


</p>
</div>
</body>
</html>