Driver complaint to SD Host Controller Specification 3.0

Sebastian Huber sebastian.huber at embedded-brains.de
Wed Jun 1 05:35:37 UTC 2016


Hello Mudit,

On 30/05/16 10:13, Mudit Jain wrote:
> Hi all,
>
> I have ported the code from the present FreeBSD.
>
> Link : https://github.com/spark1729/rtems-libbsd/commits/rpi_sd_card

nice work.

>
> Kindly review the same and suggest changes.
>
> The commits are a bit unstructured, the second last one being a huge 
> one. I will be breaking it down into smaller and logical patches while 
> submitting.
>
> Files changed/added in the three commits are as follows :
>
> freebsd/sys/dev/ofw/ofw_bus.h
> freebsd/sys/dev/ofw/ofw_bus_if.c
> freebsd/sys/dev/ofw/ofw_bus_if.h
> freebsd/sys/dev/ofw/ofw_bus_subr.c
> freebsd/sys/dev/ofw/ofw_bus_subr.h
>
> freebsd/sys/sys/queue.h

https://github.com/spark1729/rtems-libbsd/commit/1ed59e1b24f80e41f44945286b3a4b35843421ac

Something is seriously wrong with you setup, if you need this change. 
Please update to the latest tool chain via RSB and use the latest RTEMS 
and libbsd master. Then rebase your work on to of the libbsd master and 
get rid of all unnecessary patches.  Once this is done, we can continue 
to review them. Please follow the guidelines of libbsd.txt on how to 
modify and import code from FreeBSD.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.



More information about the devel mailing list