[PATCH rtems-libbsd 1/4] rtemsbsd/arasan_sdhci: Stop masking capabilities

Kinsey Moore kinsey.moore at oarcorp.com
Wed Sep 28 20:59:40 UTC 2022


The initial version of this driver was masking the capabilities register
to hide 8 bit bus capability. This is not necessary since these devices
report that capability correctly and the masking affects performance
negatively on ZynqMP boards where the 8 bit bus is supported. This also
removes two quirks that were made necessary by the capabilities masking.
---
 rtemsbsd/sys/dev/sdhci/arasan_sdhci.c | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)

diff --git a/rtemsbsd/sys/dev/sdhci/arasan_sdhci.c b/rtemsbsd/sys/dev/sdhci/arasan_sdhci.c
index 6332260a..9dcab3b1 100644
--- a/rtemsbsd/sys/dev/sdhci/arasan_sdhci.c
+++ b/rtemsbsd/sys/dev/sdhci/arasan_sdhci.c
@@ -123,16 +123,8 @@ static uint32_t
 arasan_sdhci_read_4(device_t dev, struct sdhci_slot *slot, bus_size_t off)
 {
 	struct arasan_sdhci_softc *sc = device_get_softc(dev);
-	uint32_t val32, wrk32;
 
-	val32 = RD4(sc, off);
-
-	if (off == SDHCI_CAPABILITIES) {
-		val32 &= ~SDHCI_CAN_DO_8BITBUS;
-		return (val32);
-	}
-
-	return val32;
+	return (RD4(sc, off));
 }
 
 static void
@@ -287,9 +279,6 @@ arasan_sdhci_attach(device_t dev)
 		goto fail;
 	}
 
-	sc->slot.quirks |= SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK;
-	sc->slot.quirks |= SDHCI_QUIRK_BROKEN_AUTO_STOP;
-
 	/*
 	 * DMA is not really broken, it just isn't implemented yet.
 	 */
-- 
2.30.2



More information about the devel mailing list