[PATCH] bsps/arm: fix nested extern decl. warnings brought by CMSIS files update

Sebastian Huber sebastian.huber at embedded-brains.de
Tue Jul 25 13:32:33 UTC 2023



On 21.07.23 17:37, Karel Gardas wrote:
> ---
>   bsps/arm/include/cmsis_gcc.h | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/bsps/arm/include/cmsis_gcc.h b/bsps/arm/include/cmsis_gcc.h
> index 4f0762d6dc..9e867348d2 100644
> --- a/bsps/arm/include/cmsis_gcc.h
> +++ b/bsps/arm/include/cmsis_gcc.h
> @@ -30,7 +30,9 @@
>   #pragma GCC diagnostic ignored "-Wsign-conversion"
>   #pragma GCC diagnostic ignored "-Wconversion"
>   #pragma GCC diagnostic ignored "-Wunused-parameter"
> -
> +#ifdef __rtems__
> +#pragma GCC diagnostic ignored "-Wnested-externs"
> +#endif /* __rtems__ */
>   /* Fallback for __has_builtin */
>   #ifndef __has_builtin
>     #define __has_builtin(x) (0)

I would disable this warning only in __cmsis_start() with a push/pop pragma.

I think you have to add also a

  * Modifications Copyright (C) Karel Gardas

if you change the file, see also:

https://softwareengineering.stackexchange.com/questions/220068/file-with-apache-2-0-and-my-modifications

In general, some advice for dealing with Apache 2.0 files in the RTEMS 
Software Engineering manual would be nice.

-- 
embedded brains GmbH
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.huber at embedded-brains.de
phone: +49-89-18 94 741 - 16
fax:   +49-89-18 94 741 - 08

Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/


More information about the devel mailing list