[rtems commit] libdl: Add support to import base image TLS symbols

Sebastian Huber sebastian.huber at embedded-brains.de
Mon Sep 18 12:09:44 UTC 2023


On 17.09.23 00:58, Chris Johns wrote:
>> There are also no test cases for this function.
>> Without test cases it is easy to break something without knowing it.
> The libdl test cases have been updated to reference TLS newlib variables to test
> this. Is that enough? If not what would you like to see?

These higher level tests are all right, however, it would be nice to 
have also lower level tests which just check a particular function like 
rtems_rtl_tls_get_base(). This would improve the maintainability of this 
stuff. You would not have to debug a tool generated code to figure out 
what is wrong.

-- 
embedded brains GmbH
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.huber at embedded-brains.de
phone: +49-89-18 94 741 - 16
fax:   +49-89-18 94 741 - 08

Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/


More information about the devel mailing list