[PATCH 3/4] dev/io: Add a CRC-24Q implementation

Chris Johns chrisj at rtems.org
Mon Jan 22 21:11:50 UTC 2024


On 23/1/2024 8:01 am, Gedare Bloom wrote:
> On Mon, Jan 22, 2024 at 11:13 AM Sebastian Huber
> <sebastian.huber at embedded-brains.de> wrote:
>>
>> Hello Gedare,
>>
>> ----- Am 22. Jan 2024 um 17:49 schrieb Gedare Bloom gedare at rtems.org:
>>
>>> Similar to the other patch, this looks mostly useful.
>>>
>>> I think a lot of these kind of support code have been imported as
>>> libraries through cpukit/libmisc.
>>>
>>> I'd be fine if we have our own versions, to define a cpukit/lib**
>>>
>>> But cpukit/dev has so far been for device-specific frameworks and I
>>> would prefer keeping it that way.
>>
>> I already moved the base64 encoder from score to dev recently on Joels request. The base64 encoding/decoding and packet processing has something to do with input/output which is related to devices. So, the place is not completely wrong. Anyway I am happy to move it a third time, but then it would be great if you could suggest a concrete place and naming.
>>
> Yes, I understand the frustration and I recall this discussion.

Yes I also understand your frustration. I missed the move previously so my
apologises for being late to the discussion.

Chris


More information about the devel mailing list