<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=ISO-8859-1">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hi,<br>
<br>
I will fix this if someone can confirm what I think will resolve
this.<br>
<br>
I think this is due to a clean up change by Jennifer which<br>
rippled exposing incorrect prototypes embedded in C files.<br>
<br>
../../../../../../../rtems/c/src/lib/libcpu/arm/pxa255/clock/../../../../libbsp/shared/clockdrv_shell.h:60:11:
error: conflicting types for 'Clock_isr'<br>
../../../../../../../rtems/c/src/lib/libcpu/arm/pxa255/clock/clock.c:89:11:
note: previous declaration of 'Clock_isr' was here<br>
../../../../../../../rtems/c/src/lib/libcpu/arm/pxa255/clock/../../../../libbsp/shared/clockdrv_shell.h:61:11:
error: conflicting types for 'Clock_isr'<br>
../../../../../../../rtems/c/src/lib/libcpu/arm/pxa255/clock/clock.c:89:11:
note: previous declaration of 'Clock_isr' was here<br>
<br>
shared/clockdrv_shell.h now has this which means when <br>
BSP_FEATURE_IRQ_EXTENSION is defined, we use a different<br>
(and I hope correct) signature for Clock_isr.<br>
<br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<div class="add" style="color: green; font-family: monospace;
font-size: 13px; font-style: normal; font-variant: normal;
font-weight: normal; letter-spacing: normal; line-height: normal;
orphans: 2; text-align: -webkit-auto; text-indent: 0px;
text-transform: none; white-space: pre; widows: 2; word-spacing:
0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width:
0px; background-color: rgb(255, 255, 255); ">+#ifdef
BSP_FEATURE_IRQ_EXTENSION</div>
<div class="add" style="color: green; font-family: monospace;
font-size: 13px; font-style: normal; font-variant: normal;
font-weight: normal; letter-spacing: normal; line-height: normal;
orphans: 2; text-align: -webkit-auto; text-indent: 0px;
text-transform: none; white-space: pre; widows: 2; word-spacing:
0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width:
0px; background-color: rgb(255, 255, 255); ">+rtems_isr
Clock_isr(void *arg);</div>
<div class="add" style="color: green; font-family: monospace;
font-size: 13px; font-style: normal; font-variant: normal;
font-weight: normal; letter-spacing: normal; line-height: normal;
orphans: 2; text-align: -webkit-auto; text-indent: 0px;
text-transform: none; white-space: pre; widows: 2; word-spacing:
0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width:
0px; background-color: rgb(255, 255, 255); ">+rtems_isr
Clock_isr(void *arg)</div>
<div class="add" style="color: green; font-family: monospace;
font-size: 13px; font-style: normal; font-variant: normal;
font-weight: normal; letter-spacing: normal; line-height: normal;
orphans: 2; text-align: -webkit-auto; text-indent: 0px;
text-transform: none; white-space: pre; widows: 2; word-spacing:
0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width:
0px; background-color: rgb(255, 255, 255); ">+{</div>
<div class="add" style="color: green; font-family: monospace;
font-size: 13px; font-style: normal; font-variant: normal;
font-weight: normal; letter-spacing: normal; line-height: normal;
orphans: 2; text-align: -webkit-auto; text-indent: 0px;
text-transform: none; white-space: pre; widows: 2; word-spacing:
0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width:
0px; background-color: rgb(255, 255, 255); ">+#else </div>
<div class="add" style="color: green; font-family: monospace;
font-size: 13px; font-style: normal; font-variant: normal;
font-weight: normal; letter-spacing: normal; line-height: normal;
orphans: 2; text-align: -webkit-auto; text-indent: 0px;
text-transform: none; white-space: pre; widows: 2; word-spacing:
0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width:
0px; background-color: rgb(255, 255, 255); ">+rtems_isr
Clock_isr(rtems_vector_number vector);</div>
<div class="ctx" style="color: rgb(51, 51, 51); font-family:
monospace; font-size: 13px; font-style: normal; font-variant:
normal; font-weight: normal; letter-spacing: normal; line-height:
normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px;
text-transform: none; white-space: pre; widows: 2; word-spacing:
0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width:
0px; background-color: rgb(255, 255, 255); "> rtems_isr Clock_isr(</div>
<div class="ctx" style="color: rgb(51, 51, 51); font-family:
monospace; font-size: 13px; font-style: normal; font-variant:
normal; font-weight: normal; letter-spacing: normal; line-height:
normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px;
text-transform: none; white-space: pre; widows: 2; word-spacing:
0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width:
0px; background-color: rgb(255, 255, 255); "> rtems_vector_number
vector</div>
<div class="ctx" style="color: rgb(51, 51, 51); font-family:
monospace; font-size: 13px; font-style: normal; font-variant:
normal; font-weight: normal; letter-spacing: normal; line-height:
normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px;
text-transform: none; white-space: pre; widows: 2; word-spacing:
0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width:
0px; background-color: rgb(255, 255, 255); "> )</div>
<div class="ctx" style="color: rgb(51, 51, 51); font-family:
monospace; font-size: 13px; font-style: normal; font-variant:
normal; font-weight: normal; letter-spacing: normal; line-height:
normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px;
text-transform: none; white-space: pre; widows: 2; word-spacing:
0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width:
0px; background-color: rgb(255, 255, 255); "> {</div>
<div class="add" style="color: green; font-family: monospace;
font-size: 13px; font-style: normal; font-variant: normal;
font-weight: normal; letter-spacing: normal; line-height: normal;
orphans: 2; text-align: -webkit-auto; text-indent: 0px;
text-transform: none; white-space: pre; widows: 2; word-spacing:
0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width:
0px; background-color: rgb(255, 255, 255); ">+#endif</div>
<br>
But the clock drivers actually prototype Clock_isr<br>
like this which was OK because they cast it to<br>
something else.<br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<br>
rtems_isr Clock_isr(rtems_vector_number vector);<br>
<br>
I am not pretty sure that the "void *" version is correct <br>
for the BSP_FEATURE_IRQ_EXTENSION case but<br>
really should be:<br>
<br>
void Clock_isr( rtems_irq_hdl_param arg )<br>
<br>
Can someone confirm this before I sweep through the<br>
code?<br>
<br>
And since rtems_isr is a typedef for void for documentation<br>
purposes, wouldn't it make sense to use it in rtems/irq.h?<br>
<br>
<pre class="moz-signature" cols="72">--
Joel Sherrill, Ph.D. Director of Research& Development
<a class="moz-txt-link-abbreviated" href="mailto:joel.sherrill@OARcorp.com">joel.sherrill@OARcorp.com</a> On-Line Applications Research
Ask me about RTEMS: a free RTOS Huntsville AL 35805
Support Available (256) 722-9985
</pre>
</body>
</html>