<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=ISO-8859-1">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hi<br>
<br>
I am more that a little peeved this morning to see 52<br>
commits "Removing CVS Ids". I have multiple beefs<br>
with these patches.<br>
<br>
1) They were put in completely unreviewed. Per my local time,<br>
at 12:37pm yesterday I posted a patch for testsuites which <br>
removed all Ids in every file in that directory for review. That <br>
was after accidentally not getting the attachment<br>
through earlier. There were discussions after that. At 5:36pm<br>
yesterday I posted to the list asking for review of my <br>
CVS Id removal branch. I have permission to commit these changes<br>
myself but obviously felt changes of this type needed a review.<br>
Ralf's unreviewed changes were starting to be committed at 2:34am. <br>
<br>
Ralf posted to the list after my request for review of the<br>
branch, so he clearly was not locked in a room and <br>
unaware of my work.<br>
<br>
2) They "nibble" at the problem. Per Ralf's own words<br>
in
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<a
href="http://www.rtems.org/pipermail/rtems-devel/2012-May/000979.html">http://www.rtems.org/pipermail/rtems-devel/2012-May/000979.html</a><br>
<br>
"Please don't "nibble too much", otherwise it'll be hard to
generalize <br>
patterns to eliminate."<br>
<br>
These patches do indeed nibble at the problem. They only<br>
touch build infrastructure from what I can tell. My patches<br>
are a combination of scripts and a few manual edits which<br>
remove all Ids. I was working through the tree a "subsystem"<br>
at a time and was almost through. I was primarily down to<br>
the cpukit directories with third party code that needed<br>
more careful attention.<br>
<br>
3) Since he nibbled, I have no choice but to fight through<br>
100s of conflicts or redo my work to actually remove them<br>
in the rest of the tree. You know, the minor part of the<br>
source tree which includes the .c, .h, .S, .inl, README,<br>
.t, .texi, etc<br>
<br>
4) They all have the same commit message. There has<br>
to be something to distinguish these commits. If he had<br>
looked at my branch, he would have seen messages<br>
like "testsuites - Remove All CVS Id Strings" or <br>
"libbsp - Remove CVS Id Strings (manual edits).<br>
As bad as this is, this is actually the least of my complaints.<br>
<br>
Summary: It was very clear that the removal of CVS Id <br>
strings was intended for community review. These patches are<br>
incomplete, unreviewed, and by "nibbling" create conflicts<br>
with the patches on my branch which completely remove <br>
CVS Id strings per directory. The "nibbling" is especially <br>
frustrating as he asked me specifically not do nibble.<br>
<br>
I am asking what the community wants to do. There<br>
are only two options:<br>
<br>
+ revert these commits <br>
+ accept them<br>
<br>
If the community wants to accept them, I will suck up the impact.<br>
<br>
<pre class="moz-signature" cols="72">--
Joel Sherrill, Ph.D. Director of Research& Development
<a class="moz-txt-link-abbreviated" href="mailto:joel.sherrill@OARcorp.com">joel.sherrill@OARcorp.com</a> On-Line Applications Research
Ask me about RTEMS: a free RTOS Huntsville AL 35805
Support Available (256) 722-9985
</pre>
</body>
</html>