<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
I have a patch in testing which eliminates nearly<br>
all of the sparc pci.h. It started life as a copy of an<br>
older cpukit pci.h. :(<br>
<br>
I noticed some other PCI bus constants defined<br>
in C files which turned out to also be defined<br>
in C files on other BSPs. I normalized the name<br>
and modified all impacted BSPs. It will take some<br>
time to ensure it all builds.<br>
<br>
I will commit once this is tested and then we<br>
can re-evaluate the situation.<br>
<br>
--joel<br>
<br>
On 05/16/2012 12:13 PM, Joel Sherrill wrote:
<blockquote cite="mid:4FB3E045.6070101@oarcorp.com" type="cite">
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
Hi<br>
<br>
cc'ing Daniel since the biggest culprit is under sparc.<br>
<br>
In reviewing the changes for the patch, I chanced upon<br>
sparc/shared/include/pci.h which appears to duplicate a<br>
lot of what is in cpukit/include/rtems/pci.h.<br>
<br>
Searching for pci.h, I also spotted one in mvme5500 which<br>
has a few Ids and constants which should be in the cpukit<br>
pci.h<br>
<br>
This is just accidental over the years. The sparc file was<br>
introduced 5 years ago. <br>
<br>
The mvme5500 situation is only a handful of constants.<br>
I can easily move them to rtems/pci.h and it is fixed.<br>
But the sparc version does NOT include rtems/pci.h and thus<br>
is more work. It duplicates a lot rather than getting it via<br>
inclusion.<br>
<br>
There is also the fact that we don't have any defined process<br>
for incorporating updates from
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
one of the PCI Id sources. <br>
<br>
Any thoughts on how to get back to all the PCI bus constants<br>
and device ids being defined in the cpukit pci.h?<br>
<pre class="moz-signature" cols="72">--
Joel Sherrill, Ph.D. Director of Research& Development
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:joel.sherrill@OARcorp.com">joel.sherrill@OARcorp.com</a> On-Line Applications Research
Ask me about RTEMS: a free RTOS Huntsville AL 35805
Support Available (256) 722-9985
</pre>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Joel Sherrill, Ph.D. Director of Research& Development
<a class="moz-txt-link-abbreviated" href="mailto:joel.sherrill@OARcorp.com">joel.sherrill@OARcorp.com</a> On-Line Applications Research
Ask me about RTEMS: a free RTOS Huntsville AL 35805
Support Available (256) 722-9985
</pre>
</body>
</html>