<br><br><div class="gmail_quote">On Fri, Aug 17, 2012 at 9:02 AM, Joel Sherrill <span dir="ltr"><<a href="mailto:joel.sherrill@oarcorp.com" target="_blank">joel.sherrill@oarcorp.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5">On 8/17/2012 3:13 AM, Sebastian Huber wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On 08/17/2012 02:59 AM, Kevin Polulak wrote:<br>
[...]<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
diff --git a/c/src/lib/libbsp/m68k/<u></u>mcf52235/startup/linkcmds b/c/src/lib/libbsp/m68k/<u></u>mcf52235/startup/linkcmds<br>
index f5fe3d0..37b425f 100644<br>
--- a/c/src/lib/libbsp/m68k/<u></u>mcf52235/startup/linkcmds<br>
+++ b/c/src/lib/libbsp/m68k/<u></u>mcf52235/startup/linkcmds<br>
@@ -11,11 +11,13 @@<br>
*/<br>
<br>
/*<br>
- * Declare some sizes.<br>
+ * Memory segment sizes.<br>
+ *<br>
+ * A heap size of 0 means that all available memory is used for the heap.<br>
*/<br>
-RamBase = DEFINED(RamBase) ? RamBase : 0x20000000;<br>
-RamSize = DEFINED(RamSize) ? RamSize : 32K;<br>
-HeapSize = DEFINED(HeapSize) ? HeapSize : 0x0;<br>
+RamBase = DEFINED(RamBase) ? RamBase : 0x20000000;<br>
+RamSize = DEFINED(RamSize) ? RamSize : 32K;<br>
+HeapSize = DEFINED(HeapSize) ? HeapSize : 0x0;<br>
_StackSize = DEFINED(_StackSize) ? _StackSize : 0x400;<br>
_FlashBase = DEFINED(_FlashBase) ? _FlashBase : 0x00000000;<br>
</blockquote>
I don't like this format. Each time you change the length of one field in the<br>
columns you have to adjust other lines as well. This makes a review harder.<br>
<br>
[...]<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
- PROVIDE (_fini = .);<br>
+<br>
+ PROVIDE(_fini = .);<br>
</blockquote>
If you look at the default linker command file (e.g. m68k-rtems4.11-ld<br>
--verbose) then you will see that the previous format is used here (space<br>
before "(").<br>
<br>
[...]<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
diff --git a/c/src/lib/libbsp/m68k/<u></u>shared/startup/linkcmds.<u></u>robsdsets b/c/src/lib/libbsp/m68k/<u></u>shared/startup/linkcmds.<u></u>robsdsets<br>
new file mode 100644<br>
index 0000000..23a1d92<br>
--- /dev/null<br>
+++ b/c/src/lib/libbsp/m68k/<u></u>shared/startup/linkcmds.<u></u>robsdsets<br>
@@ -0,0 +1,29 @@<br>
+/*<br>
+ * This file contains directives for the GNU linker which are needed for<br>
+ * rtems-libbsd FreeBSD code.<br>
+ *<br>
+ * COPYRIGHT (c) 1989-1999.<br>
+ * On-Line Applications Research Corporation (OAR).<br>
+ *<br>
+ * The license and distribution terms for this file may be<br>
+ * found in the file LICENSE in this distribution or at<br>
+ *<a href="http://www.rtems.com/license/LICENSE.e" target="_blank">http://www.rtems.com/license/<u></u>LICENSE.e</a><br>
+ */<br>
+<br>
+__start_set_sysctl_set = .;<br>
+*(set_sysctl_*);<br>
+__stop_set_sysctl_set = .;<br>
+*(set_domain_*);<br>
+*(set_pseudo_*);<br>
+<br>
+_bsd__start_set_modmetadata_<u></u>set = .;<br>
+*(_bsd_set_modmetadata_set);<br>
+_bsd__stop_set_modmetadata_<u></u>set = .;<br>
+<br>
+_bsd__start_set_sysctl_set = .;<br>
+*(_bsd_set_sysctl_set);<br>
+_bsd__stop_set_sysctl_set = .;<br>
+<br>
+_bsd__start_set_sysinit_set = .;<br>
+*(_bsd_set_sysinit_*);<br>
+_bsd__stop_set_sysinit_set = .;<br>
</blockquote>
Why is this linkcmds.robsdsets and not linkcmds.rortems?<br>
<br>
Why do we have CPU specific variants of this? On ARM, PowerPC, etc. this file<br>
would look like identical.<br>
</blockquote></div></div>
Some targets place a leading underscore in front of symbols. If you have every<br>
symbol both with and without an extra _ prepended, then it will be Ok. For example,<br>
both _bsd__stop_set_sysinit_set and __bsd__stop_set_sysinit_set would have<br>
to be defined.<br>
<br></blockquote><div>Is appending the leading _ a choice RTEMS makes or is it forced on us?<br> </div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
This is all the targets I have tools installed for and whether or not they add a<br>
leading underscore.<br>
<br>
arm-rtems4.11 - no leading underscore<br>
avr-rtems4.11 - no leading underscore<br>
bfin-rtems4.11 - leading underscore<br>
h8300-rtems4.11 - leading underscore<br>
i386-rtems4.11 - no leading underscore<br>
lm32-rtems4.11 - no leading underscore<br>
m32c-rtems4.11 - leading underscore<br>
m32r-rtems4.11 - no leading underscore<br>
m68k-rtems4.11 - no leading underscore<br>
microblaze-rtems4.11 - no leading underscore<br>
mips-rtems4.11 - no leading underscore<br>
powerpc-rtems4.11 - no leading underscore<br>
sh-rtems4.11 - leading underscore<br>
sparc64-rtems4.11 - no leading underscore<br>
sparc-rtems4.11 - no leading underscore<br>
v850-rtems4.11 - leading underscore<div class="im HOEnZb"><br>
<br>
<br>
<br>
-- <br>
Joel Sherrill, Ph.D. Director of Research& Development<br>
joel.sherrill@OARcorp.com On-Line Applications Research<br>
Ask me about RTEMS: a free RTOS Huntsville AL 35805<br>
Support Available <a href="tel:%28256%29%20722-9985" value="+12567229985" target="_blank">(256) 722-9985</a><br>
<br></div><div class="HOEnZb"><div class="h5">
______________________________<u></u>_________________<br>
rtems-devel mailing list<br>
<a href="mailto:rtems-devel@rtems.org" target="_blank">rtems-devel@rtems.org</a><br>
<a href="http://www.rtems.org/mailman/listinfo/rtems-devel" target="_blank">http://www.rtems.org/mailman/<u></u>listinfo/rtems-devel</a><br>
</div></div></blockquote></div><br>