+1<br><br><div class="gmail_quote">On Sun, Aug 19, 2012 at 7:28 AM, Sebastian Huber <span dir="ltr"><<a href="mailto:sebastian.huber@embedded-brains.de" target="_blank">sebastian.huber@embedded-brains.de</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
it would be nice if the commits in the pull requests can be merged together (git rebase -i) to provide easy to review change sets. I am not interested in the details that lead to the end result. What I want to see is the set of changes that lead from the current RTEMS master branch to a state that implements feature X in a clean way. The single commits should cover a single change set. These commits should have a useful commit message. For example what I am supposed to do with such a commit in a pull request (this is only one random picked example):<br>
<br>
<a href="https://github.com/jolkaczad/rtems_hyper/commit/78731c40ca02ed3aac16ed29a9c53a6f43532281" target="_blank">https://github.com/jolkaczad/<u></u>rtems_hyper/commit/<u></u>78731c40ca02ed3aac16ed29a9c53a<u></u>6f43532281</a><br>
<br>
I don't know what the "broken" commit message means since I was not involved in the development process. I don't care about the development process. For the review before integration into the master branch I am only interested in the final results.<br>
<br>
-- <br>
Sebastian Huber, embedded brains GmbH<br>
<br>
Address : Obere Lagerstr. 30, D-82178 Puchheim, Germany<br>
Phone : <a href="tel:%2B49%2089%2018%2090%2080%2079-6" value="+4989189080796" target="_blank">+49 89 18 90 80 79-6</a><br>
Fax : <a href="tel:%2B49%2089%2018%2090%2080%2079-9" value="+4989189080799" target="_blank">+49 89 18 90 80 79-9</a><br>
E-Mail : <a href="mailto:sebastian.huber@embedded-brains.de" target="_blank">sebastian.huber@embedded-<u></u>brains.de</a><br>
PGP : Public key available on request.<br>
<br>
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.<br>
<br>
______________________________<u></u>_________________<br>
rtems-devel mailing list<br>
<a href="mailto:rtems-devel@rtems.org" target="_blank">rtems-devel@rtems.org</a><br>
<a href="http://www.rtems.org/mailman/listinfo/rtems-devel" target="_blank">http://www.rtems.org/mailman/<u></u>listinfo/rtems-devel</a><br>
</blockquote></div><br>