<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
On 01/11/2013 07:49 AM, Sebastian Huber wrote:
<blockquote cite="mid:50F01877.7060202@embedded-brains.de"
type="cite">
<pre wrap="">On 01/11/2013 12:02 AM, Joel Sherrill wrote:
</pre>
<blockquote type="cite">
<pre wrap="">diff --git a/cpukit/include/rtems/irq-extension.h b/cpukit/include/rtems/irq-extension.h
index 644091b..ff2c6da 100644
--- a/cpukit/include/rtems/irq-extension.h
+++ b/cpukit/include/rtems/irq-extension.h
@@ -38,9 +38,8 @@ extern "C" {
* In addition to the Classic API interrupt handler with a handle are
* supported. You can also install multiple shared handler for one interrupt
* vector.
- *
- * @{
*/
+/**@{**/
/**
* @brief Makes the interrupt handler unique. Prevents other handler from
</pre>
</blockquote>
<pre wrap="">
I think this change should be reversed. A single @{ without a preceding
@defgroup or @addtogroup makes no sense. Thus is should be also part of the
corresponding comment block.
</pre>
</blockquote>
The inclusion of the opening was inconsistent across the files.<br>
I saw three patterns and wasn't sure there were not more:<br>
<br>
/**@{*/<br>
<br>
* TEXT<br>
*<br>
* @{<br>
*/<br>
<br>
<br>
* TEXT<br>
* @{<br>
*/<br>
<br>
I thought it got lost in the comment block and that the single<br>
line by itself stood out more. Plus it matches the ending block<br>
marker. Plus it is what is documented in the Doxygen manual<br>
<br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<a
href="http://www.star.bnl.gov/public/comp/sofi/doxygen/grouping.html">http://www.star.bnl.gov/public/comp/sofi/doxygen/grouping.html</a><br>
<br>
FWIW the extern C, ending block and inclusion prevention<br>
stuff at the bottom of the files is also very inconsistent<br>
in precise formatting.<br>
<br>
<pre class="moz-signature" cols="72">--
Joel Sherrill, Ph.D. Director of Research& Development
<a class="moz-txt-link-abbreviated" href="mailto:joel.sherrill@OARcorp.com">joel.sherrill@OARcorp.com</a> On-Line Applications Research
Ask me about RTEMS: a free RTOS Huntsville AL 35806
Support Available (256) 722-9985</pre>
</body>
</html>