<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 5/5/2013 6:07 AM, Vipul Nayyar
wrote:<br>
</div>
<blockquote
cite="mid:1367752072.24059.YahooMailNeo@web194901.mail.sg3.yahoo.com"
type="cite">
<div style="color:#000; background-color:#fff; font-family:arial,
helvetica, sans-serif;font-size:10pt">
<div style="font-family: arial, helvetica, sans-serif;
font-size: 10pt;"><span><br>
</span></div>
<div style="font-family: arial, helvetica, sans-serif;
font-size: 10pt;"> Hello</div>
<div style="font-family: arial, helvetica, sans-serif;
font-size: 10pt;"><br>
</div>
<div><font size="2">As instructed, I've made a custom script</font><font
face="Arial, Helvetica Neue, Helvetica, sans-serif"><span
style="font-size: 12px; line-height: 19.1875px;"> </span><span
style="font-size: 12px; line-height: 19.1875px;">to
identify BSPs which use the PIC API but do not appear to
include the complete set of files.</span></font></div>
<div><font face="Arial, Helvetica Neue, Helvetica, sans-serif"><span
style="font-size: 12px; line-height: 19.1875px;">So taking
the example of the tru way of pc386 , it contained 4
relevant headers : irq.h , irq_asm.h , irq-generic.h
, irq-info.h . <br>
</span></font></div>
</div>
</blockquote>
<font face="Arial, Helvetica Neue, Helvetica, sans-serif">Looks
pretty good. <br>
<br>
I think libbsp/i386/shared/irq.h is </font>BSP specific and
equivalent <br>
to include/irq.h in other BSPs (looking at mips/malta).<br>
<br>
<font face="Arial, Helvetica Neue, Helvetica, sans-serif">I am
attaching my attempt at the same thing. See what it<br>
reports. I found some items you didn't. And it looks I <br>
missed checking irq.h. I thought it was BSP specific and<br>
it is but I wonder where this information is on other BSPs.<br>
Looks like an inconsistency. Do you see what's inconsistent?<br>
<br>
Note: That's a real question. And the point of this project.<br>
To identify rules, check for compliance, find inconsistencies <br>
and kill them. :)<br>
</font>
<blockquote
cite="mid:1367752072.24059.YahooMailNeo@web194901.mail.sg3.yahoo.com"
type="cite">
<div style="color:#000; background-color:#fff; font-family:arial,
helvetica, sans-serif;font-size:10pt">
<div><font face="Arial, Helvetica Neue, Helvetica, sans-serif"><span
style="font-size: 12px; line-height: 19.1875px;">But in
irq_asm.h it's stated that " </span></font><font
face="Arial, Helvetica Neue, Helvetica, sans-serif"><span
style="font-size: 12px; line-height: 19.1875px;">This
include file has definitions to represent some constants
used </span></font><span style="font-size: 12px;
line-height: 19.1875px; font-family: Arial, 'Helvetica
Neue', Helvetica, sans-serif;"> to program and manage the
Intel 8259 interrupt controller </span><span
style="font-size: 12px; line-height: 19.1875px; font-family:
Arial, 'Helvetica Neue', Helvetica, sans-serif;">". That
means this particular header should be irrelevant for other
BSPs. So my script checks the Makefile.am for all the BSPs
present in lib/libbsp and states whether the relevant irq
files are included or not. The bash script and it's output
is attached with the email.</span></div>
<div><span style="font-size: 12px; line-height: 19.1875px;
font-family: Arial, 'Helvetica Neue', Helvetica,
sans-serif;"><br>
</span></div>
</div>
</blockquote>
i386/shared/irq_asm.h is definitely i386 (really i8259 as on PC/AT)
specific<br>
and could? possibly be eliminated by being merged into either the .S
file<br>
(if only one) that uses it. Or merged into i386/shared/irq.h and
wrapped<br>
in "ifndef ASM" conditionals.<br>
<br>
This is a case where something could be done.<br>
<blockquote
cite="mid:1367752072.24059.YahooMailNeo@web194901.mail.sg3.yahoo.com"
type="cite">
<div style="color:#000; background-color:#fff; font-family:arial,
helvetica, sans-serif;font-size:10pt">
<div><span style="font-size: 12px; line-height: 19.1875px;
font-family: Arial, 'Helvetica Neue', Helvetica,
sans-serif;">I know I must've made some mistakes. But I'll
improve it and send another version of it after doing more
research on the BSPs.</span></div>
<div><br>
</div>
</div>
</blockquote>
I think we both likely made mistakes. Not really as wrong as just<br>
part of the discovery process.<br>
<br>
Hmm.. the gdbarmsim does not have interrupts in the simulator<br>
so I left out all irq code. Hmm... my script didn't flag this. I <br>
wonder what should be the rule? <br>
<br>
Looks good. Do you feel like you have a good enough handle on this<br>
project or do you want to delve further?<br>
<blockquote
cite="mid:1367752072.24059.YahooMailNeo@web194901.mail.sg3.yahoo.com"
type="cite">
<div style="color:#000; background-color:#fff; font-family:arial,
helvetica, sans-serif;font-size:10pt">
<div style="font-family: arial, helvetica, clean, sans-serif;
font-size: 13px; color: rgb(0, 0, 0); background-color:
transparent; font-style: normal;">Regards</div>
<div style="font-family: arial, helvetica, clean, sans-serif;
font-size: 13px; color: rgb(0, 0, 0); background-color:
transparent; font-style: normal;"><span
style="background-color:transparent;line-height:1.22;">Vipul
Nayyar </span></div>
<div style="font-family: arial, helvetica, clean, sans-serif;
font-size: 12.727272033691406px; color: rgb(0, 0, 0);
background-color: transparent; font-style: normal;"><br>
</div>
<div style="font-family: arial, helvetica, clean, sans-serif;
font-size: 13px; color: rgb(0, 0, 0); background-color:
transparent; font-style: normal;"><br>
</div>
</div>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Joel Sherrill, Ph.D. Director of Research & Development
<a class="moz-txt-link-abbreviated" href="mailto:joel.sherrill@OARcorp.com">joel.sherrill@OARcorp.com</a> On-Line Applications Research
Ask me about RTEMS: a free RTOS Huntsville AL 35805
Support Available (256) 722-9985 </pre>
</body>
</html>