<html><body><div style="color:#000; background-color:#fff; font-family:arial, helvetica, sans-serif;font-size:10pt"><div style="font-size: 10pt; font-family: arial, helvetica, sans-serif;"><span><br></span></div><div style="font-size: 13px; font-family: arial, helvetica, sans-serif; color: rgb(0, 0, 0); background-color: transparent; font-style: normal;"><span>Hello,</span></div><div style="font-size: 13px; font-family: arial, helvetica, sans-serif; color: rgb(0, 0, 0); background-color: transparent; font-style: normal;"><span><br></span></div><div style="font-size: 13px; color: rgb(0, 0, 0); background-color: transparent; font-style: normal; font-family: arial, helvetica, sans-serif;">For my GSOC Project Unified APIs, a public google doc has been setup ( <a
href="https://docs.google.com/document/d/1W9DMnpocXUKXiQMxHbbp0aG-ecuh94P-3N7hxEJmcgs/edit?usp=sharing">https://docs.google.com/document/d/1W9DMnpocXUKXiQMxHbbp0aG-ecuh94P-3N7hxEJmcgs/edit?usp=sharing</a>) for community viewing. In order to establish this unified pattern across all BSPs, I felt that deprecated methods stored in irq-legacy.c should be dealt with first. So, I'm attaching a very basic patch which removes the deprecated method BSP_install_rtems_irq_handler from arm csb336 and instead makes use of rtems_interrupt_handler_install, as suggested in irq-legacy.c. Please do give suggestions if I'm heading the right way, and any modifications that this patch may require.</div><div style="font-size: 13px; color: rgb(0, 0, 0); background-color: transparent; font-style: normal;" class="yui_3_7_2_28_1372259927266_89"><br></div><div style="background-color: transparent;" class="yui_3_7_2_28_1372259927266_89"><div style="background-color:
transparent;" class="yui_3_7_2_28_1372259927266_89"><span style="font-size: 13px;">commit aec52ad03481b46a95a451af207191251edb1512</span></div><div style="background-color: transparent;" class="yui_3_7_2_28_1372259927266_89"><span style="font-size: 13px;">Author: Vipul Nayyar <nayyar_vipul@yahoo.com></span></div><div style="background-color: transparent;" class="yui_3_7_2_28_1372259927266_89"><span style="font-size: 13px;">Date: Wed Jun 26 20:48:10 2013 +0530</span></div><div style="background-color: transparent;" class="yui_3_7_2_28_1372259927266_89"><span style="font-size: 13px;"><br></span></div><div style="background-color: transparent;" class="yui_3_7_2_28_1372259927266_89"><span style="font-size: 13px;"> removed legacy BSP_install_rtems_irq_handler from arm csb336</span></div><div style="background-color: transparent;" class="yui_3_7_2_28_1372259927266_89"><span style="font-size: 13px;"><br></span></div><div
style="background-color: transparent;" class="yui_3_7_2_28_1372259927266_89"><span style="font-size: 13px;">diff --git a/c/src/lib/libbsp/arm/csb336/console/uart.c b/c/src/lib/libbsp/arm/csb336/console/uart.c</span></div><div style="background-color: transparent;" class="yui_3_7_2_28_1372259927266_89"><span style="font-size: 13px;">index 4dc409b..0c4ab39 100644</span></div><div style="background-color: transparent;" class="yui_3_7_2_28_1372259927266_89"><span style="font-size: 13px;">--- a/c/src/lib/libbsp/arm/csb336/console/uart.c</span></div><div style="background-color: transparent;" class="yui_3_7_2_28_1372259927266_89"><span style="font-size: 13px;">+++ b/c/src/lib/libbsp/arm/csb336/console/uart.c</span></div><div style="background-color: transparent;" class="yui_3_7_2_28_1372259927266_89"><span style="font-size: 13px;">@@ -246,9 +246,13 @@ static int imx_uart_first_open(int major, int minor, void *arg)</span></div><div style="background-color:
transparent;" class="yui_3_7_2_28_1372259927266_89"><span style="font-size: 13px;"> </span></div><div style="background-color: transparent;" class="yui_3_7_2_28_1372259927266_89"><span style="font-size: 13px;"> imx_uart_data[minor].tty = args->iop->data1;</span></div><div style="background-color: transparent;" class="yui_3_7_2_28_1372259927266_89"><span style="font-size: 13px;"> </span></div><div style="background-color: transparent;" class="yui_3_7_2_28_1372259927266_89"><span style="font-size: 13px;">+ const rtems_irq_connect_data *uart_tx = &imx_uart_tx_isr_data[minor];</span></div><div style="background-color: transparent;" class="yui_3_7_2_28_1372259927266_89"><span style="font-size: 13px;">+ const rtems_irq_connect_data *uart_rx = &imx_uart_rx_isr_data[minor];</span></div><div style="background-color: transparent;" class="yui_3_7_2_28_1372259927266_89"><span
style="font-size: 13px;">+</span></div><div style="background-color: transparent;" class="yui_3_7_2_28_1372259927266_89"><span style="font-size: 13px;">+</span></div><div style="background-color: transparent;" class="yui_3_7_2_28_1372259927266_89"><span style="font-size: 13px;"> #if defined(USE_INTERRUPTS)</span></div><div style="background-color: transparent;" class="yui_3_7_2_28_1372259927266_89"><span style="font-size: 13px;">- BSP_install_rtems_irq_handler(&imx_uart_tx_isr_data[minor]);</span></div><div style="background-color: transparent;" class="yui_3_7_2_28_1372259927266_89"><span style="font-size: 13px;">- BSP_install_rtems_irq_handler(&imx_uart_rx_isr_data[minor]);</span></div><div style="background-color: transparent;" class="yui_3_7_2_28_1372259927266_89"><span style="font-size: 13px;">+ rtems_interrupt_handler_install(uart_tx->name,"LEGACY
REMOVED",RTEMS_INTERRUPT_UNIQUE,uart_tx->hdl,uart_tx->handle);</span></div><div style="background-color: transparent;" class="yui_3_7_2_28_1372259927266_89"><span style="font-size: 13px;">+ rtems_interrupt_handler_install(uart_rx->name,"LEGACY REMOVED",RTEMS_INTERRUPT_UNIQUE,uart_rx->hdl,uart_rx->handle);</span></div><div style="background-color: transparent;" class="yui_3_7_2_28_1372259927266_89"><span style="font-size: 13px;"> </span></div><div style="background-color: transparent;" class="yui_3_7_2_28_1372259927266_89"><span style="font-size: 13px;"> imx_uart_data[minor].regs->cr1 |= MC9328MXL_UART_CR1_RRDYEN;</span></div><div style="background-color: transparent;" class="yui_3_7_2_28_1372259927266_89"><span style="font-size: 13px;"> #endif</span></div><div style="background-color: transparent;" class="yui_3_7_2_28_1372259927266_89"><span style="font-size: 13px;">diff --git
a/c/src/lib/libbsp/arm/csb336/network/network.c b/c/src/lib/libbsp/arm/csb336/network/network.c</span></div><div style="background-color: transparent;" class="yui_3_7_2_28_1372259927266_89"><span style="font-size: 13px;">index e513595..7f54230 100644</span></div><div style="background-color: transparent;" class="yui_3_7_2_28_1372259927266_89"><span style="font-size: 13px;">--- a/c/src/lib/libbsp/arm/csb336/network/network.c</span></div><div style="background-color: transparent;" class="yui_3_7_2_28_1372259927266_89"><span style="font-size: 13px;">+++ b/c/src/lib/libbsp/arm/csb336/network/network.c</span></div><div style="background-color: transparent;" class="yui_3_7_2_28_1372259927266_89"><span style="font-size: 13px;">@@ -334,7 +334,7 @@ void mc9328mxl_enet_init_hw(mc9328mxl_enet_softc_t *sc)</span></div><div style="background-color: transparent;" class="yui_3_7_2_28_1372259927266_89"><span style="font-size: 13px;">
MC9328MXL_GPIOA_IMR |= bit(3);</span></div><div style="background-color: transparent;" class="yui_3_7_2_28_1372259927266_89"><span style="font-size: 13px;"> </span></div><div style="background-color: transparent;" class="yui_3_7_2_28_1372259927266_89"><span style="font-size: 13px;"> /* Install the interrupt handler */</span></div><div style="background-color: transparent;" class="yui_3_7_2_28_1372259927266_89"><span style="font-size: 13px;">- BSP_install_rtems_irq_handler(&mc9328mxl_enet_isr_data);</span></div><div style="background-color: transparent;" class="yui_3_7_2_28_1372259927266_89"><span style="font-size: 13px;">+ rtems_interrupt_handler_install(mc9328mxl_enet_isr_data.name,"LEGACY REMOVED",RTEMS_INTERRUPT_UNIQUE,mc9328mxl_enet_isr_data.hdl,mc9328mxl_enet_isr_data.handle);</span></div><div style="background-color: transparent;" class="yui_3_7_2_28_1372259927266_89"><span
style="font-size: 13px;"> </span></div><div style="background-color: transparent;" class="yui_3_7_2_28_1372259927266_89"><span style="font-size: 13px;"> } /* mc9328mxl_enet_init_hw() */</span></div></div><div style="font-size: 10pt; font-family: arial, helvetica, sans-serif;"><br></div><div style="font-size: 13px; font-family: arial, helvetica, clean, sans-serif; color: rgb(0, 0, 0); background-color: transparent; font-style: normal;"><br></div><div style="font-size: 13px; font-family: arial, helvetica, clean, sans-serif; color: rgb(0, 0, 0); background-color: transparent; font-style: normal;"><br></div><div style="font-size: 13px; font-family: arial, helvetica, clean, sans-serif; color: rgb(0, 0, 0); background-color: transparent; font-style: normal;">Regards</div><div style="font-size: 13px; font-family: arial, helvetica, clean, sans-serif; color: rgb(0, 0, 0); background-color: transparent; font-style: normal;"><span
style="background-color:transparent;line-height:1.22;">Vipul Nayyar </span></div><div style="font-size: 12.727272033691406px; font-family: arial, helvetica, clean, sans-serif; color: rgb(0, 0, 0); background-color: transparent; font-style: normal;"><br></div></div></body></html>