<html><body><div style="color:#000; background-color:#fff; font-family:arial, helvetica, sans-serif;font-size:10pt"><div><span>Hello,</span></div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: arial, helvetica, sans-serif; background-color: transparent; font-style: normal;"><span><br></span></div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: arial, helvetica, sans-serif; background-color: transparent; font-style: normal;"><span>Thanks for accepting this patch. I'll work on the guidelines given by you.</span></div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: arial, helvetica, sans-serif; background-color: transparent; font-style: normal;"><span><br></span></div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: arial, helvetica, sans-serif; background-color: transparent; font-style: normal;"><span>Before modifying the csb336 patch, and moving further with other bsps, Can I consider the work
for this bsp closed ?</span></div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: arial, helvetica, sans-serif; background-color: transparent; font-style: normal;"><br></div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: arial, helvetica, clean, sans-serif; background-color: transparent; font-style: normal;">Regards</div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: arial, helvetica, clean, sans-serif; background-color: transparent; font-style: normal;"><span style="background-color:transparent;line-height:1.22;">Vipul Nayyar </span></div><div style="color: rgb(0, 0, 0); font-size: 12.727272033691406px; font-family: arial, helvetica, clean, sans-serif; background-color: transparent; font-style: normal;"><br></div><div><br></div> <div style="font-family: arial, helvetica, sans-serif; font-size: 10pt;"> <div style="font-family: 'times new roman', 'new york', times, serif; font-size: 12pt;"> <div
dir="ltr"> <hr size="1"> <font size="2" face="Arial"> <b><span style="font-weight:bold;">From:</span></b> Sebastian Huber <sebastian.huber@embedded-brains.de><br> <b><span style="font-weight: bold;">To:</span></b> Vipul Nayyar <nayyar_vipul@yahoo.com> <br><b><span style="font-weight: bold;">Cc:</span></b> Joel Sherrill <joel.sherrill@oarcorp.com>; "rtems-devel@rtems.org" <rtems-devel@rtems.org> <br> <b><span style="font-weight: bold;">Sent:</span></b> Sunday, 7 July 2013 6:39 PM<br> <b><span style="font-weight: bold;">Subject:</span></b> Re: [Patch] Removing legacy method from arm csb337<br> </font> </div> <div class="y_msg_container"><br>Hello,<br><br>I checked in a slightly modified version:<br><br><a href="http://git.rtems.org/rtems/commit/?id=6886a485301330b1347b89432b2c49287dc41010" target="_blank">http://git.rtems.org/rtems/commit/?id=6886a485301330b1347b89432b2c49287dc41010</a><br><br>Some remarks:<br><br>1. Please don't
use<br><br>type func()<br><br>in C, use<br><br>type func(void)<br><br>instead.<br><br>2. Don't introduce trailing white space. You can use<br><br>git config --global --add diff.color auto<br>git config --global color.ui auto<br><br>to instruct Git to highlight this in "git diff" for you.<br><br>3. Use "git format-patch" to produce patches. You can use "git send-email" to send this to the list. Example configuration:<br><br>git config --global --add sendemail.to <a ymailto="mailto:rtems-devel@rtems.org" href="mailto:rtems-devel@rtems.org">rtems-devel@rtems.org</a><br>git config --global --add sendemail.smtpserver your.server<br>git config --global --add sendemail.from 'Your Name <<a ymailto="mailto:your.name@x.y" href="mailto:your.name@x.y">your.name@x.y</a>>'<br>git config --global --add sendemail.suppresscc all<br><br>On 06/07/13 19:06, Vipul Nayyar wrote:<br>> Thanks for the advice. In fact I removed most of the warnings
with the help of Google only in my earlier patch.<br>> I've checked and removed functions at91rm9200_emac_isr_off() & at91rm9200_emac_isr_is_on() since they're defined but not used.<br>> I've made phywrite() & phyread() static since they're not used anywhere else.<br>> <br>> But still I'm getting a warning saying : 'phyread' defined but not used [-Wunused-function] . Although it is used a couple of times in the file, but still I'm getting this warning. Maybe it has something to do with being a static function. Please try this patch.<br><br>It was used only if csb637 was defined.<br><br>-- Sebastian Huber, embedded brains GmbH<br><br>Address : Dornierstr. 4, D-82178 Puchheim, Germany<br>Phone : +49 89 189 47 41-16<br>Fax : +49 89 189 47 41-09<br>E-Mail : <a ymailto="mailto:sebastian.huber@embedded-brains.de" href="mailto:sebastian.huber@embedded-brains.de">sebastian.huber@embedded-brains.de</a><br>PGP
: Public key available on request.<br><br>Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.<br><br><br><br></div> </div> </div> </div></body></html>