<html><body><div style="color:#000; background-color:#fff; font-family:arial, helvetica, sans-serif;font-size:10pt"><div><span>Hello,</span></div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: arial, helvetica, sans-serif; background-color: transparent; font-style: normal;"><span><br></span></div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: arial, helvetica, sans-serif; background-color: transparent; font-style: normal;"><span>Some points on which I needed clarification :</span></div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: arial, helvetica, sans-serif; background-color: transparent; font-style: normal;"><span>1) I've used </span><span style="font-family: 'times new roman', 'new york', times, serif; font-size: 16px;">rtems_irq_hdl to pass handle to </span><span style="font-family: 'times new roman', 'new york', times, serif; font-size: 16px;">ne_interrupt_on() function. Is that correct or
should I use some other data type.</span></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: 'times new roman', 'new york', times, serif; background-color: transparent; font-style: normal;"><span style="font-family: 'times new roman', 'new york', times, serif; font-size: 16px;">2) Functions like ne_interrupt_off() & ne_interrupt_is_on() are not used anywhere, but still I didn't get any warnings. Should I remove them ?</span></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: 'times new roman', 'new york', times, serif; background-color: transparent; font-style: normal;"><br></div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: arial, helvetica, clean, sans-serif; background-color: transparent; font-style: normal;">Regards</div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: arial, helvetica, clean, sans-serif; background-color: transparent; font-style: normal;"><span
style="background-color:transparent;line-height:1.22;">Vipul Nayyar </span></div><div style="color: rgb(0, 0, 0); font-size: 12.727272033691406px; font-family: arial, helvetica, clean, sans-serif; background-color: transparent; font-style: normal;"><br></div><div><br></div> <div style="font-family: arial, helvetica, sans-serif; font-size: 10pt;"> <div style="font-family: 'times new roman', 'new york', times, serif; font-size: 12pt;"> <div dir="ltr"> <hr size="1"> <font size="2" face="Arial"> <b><span style="font-weight:bold;">From:</span></b> Vipul Nayyar <nayyar_vipul@yahoo.com><br> <b><span style="font-weight: bold;">To:</span></b> rtems-devel@rtems.org <br> <b><span style="font-weight: bold;">Sent:</span></b> Tuesday, 9 July 2013 8:16 PM<br> <b><span style="font-weight: bold;">Subject:</span></b> [PATCH] Updated Legacy code in arm gumstix<br> </font> </div> <div class="y_msg_container"><br>---<br>
c/src/lib/libbsp/arm/gumstix/rtl8019/rtl8019.c | 33 +++++++++++++-------------<br> 1 file changed, 16 insertions(+), 17 deletions(-)<br><br>diff --git a/c/src/lib/libbsp/arm/gumstix/rtl8019/rtl8019.c b/c/src/lib/libbsp/arm/gumstix/rtl8019/rtl8019.c<br>index 5db0433..bef6560 100644<br>--- a/c/src/lib/libbsp/arm/gumstix/rtl8019/rtl8019.c<br>+++ b/c/src/lib/libbsp/arm/gumstix/rtl8019/rtl8019.c<br>@@ -350,9 +350,9 @@ ne_interrupt_handler (rtems_irq_hdl_param handle)<br> /* Turn NE2000 interrupts on. */<br> <br> static void<br>-ne_interrupt_on (const rtems_irq_connect_data *irq)<br>+ne_interrupt_on (const rtems_irq_hdl handle)<br> {<br>- struct ne_softc *sc = irq->handle;<br>+ struct ne_softc *sc = handle;<br> <br> #ifdef DEBUG_NE<br> printk ("ne_interrupt_on()\n");<br>@@ -364,9 +364,9 @@ ne_interrupt_on (const rtems_irq_connect_data *irq)<br> /* Turn NE2000 interrupts off. See ne_interrupt_on. */<br> <br> static
void<br>-ne_interrupt_off (const rtems_irq_connect_data *irq)<br>+ne_interrupt_off (const rtems_irq_hdl handle)<br> {<br>- struct ne_softc *sc = irq->handle;<br>+ struct ne_softc *sc = handle;<br> <br> #ifdef DEBUG_NE<br> printk ("ne_interrupt_off()\n");<br>@@ -380,9 +380,9 @@ ne_interrupt_off (const rtems_irq_connect_data *irq)<br> *If it is eanbled, return 1<br> */<br> static int<br>-ne_interrupt_is_on (const rtems_irq_connect_data *irq)<br>+ne_interrupt_is_on (const rtems_irq_hdl handle)<br> {<br>- struct ne_softc *sc = irq->handle;<br>+ struct ne_softc *sc = handle;<br> unsigned char imr;<br> #ifdef DEBUG_NE<br> printk("ne_interrupt_is_on()\n");<br>@@ -479,21 +479,20 @@ ne_init_hardware (struct ne_softc *sc)<br> static void<br> ne_init_irq_handler(struct ne_softc *sc)<br> {<br>- rtems_irq_connect_data irq;<br>+ rtems_status_code status = RTEMS_SUCCESSFUL;<br> <br> #ifdef
DEBUG_NE<br> printk("ne_init_irq_handler(%d)\n", sc->irno);<br> #endif<br>- irq.name = sc->irno;<br>- irq.hdl = ne_interrupt_handler;<br>- irq.handle = sc;<br>- irq.on = ne_interrupt_on;<br>- irq.off = ne_interrupt_off;<br>- irq.isOn = ne_interrupt_is_on;<br>-<br>- if (!BSP_install_rtems_irq_handler (&irq))<br>- rtems_panic ("Can't attach NE interrupt handler for irq %d\n", sc->irno);<br>-}<br>+ status = rtems_interrupt_handler_install(<br>+ sc->irno,<br>+ "RTL8019",<br>+ RTEMS_INTERRUPT_UNIQUE,<br>+ ne_interrupt_handler,<br>+ sc<br>+ ); <br>+ assert(status == RTEMS_SUCCESSFUL);<br>+ ne_interrupt_on(sc);<br> <br> /* The NE2000 packet receive daemon. This task is started when the<br>
NE2000 driver is initialized. */<br>-- <br>1.7.11.7<br><br>_______________________________________________<br>rtems-devel mailing list<br><a ymailto="mailto:rtems-devel@rtems.org" href="mailto:rtems-devel@rtems.org">rtems-devel@rtems.org</a><br><a href="http://www.rtems.org/mailman/listinfo/rtems-devel" target="_blank">http://www.rtems.org/mailman/listinfo/rtems-devel</a><br><br><br></div> </div> </div> </div></body></html>