<html><body><div style="color:#000; background-color:#fff; font-family:arial, helvetica, sans-serif;font-size:10pt"><div style="font-family: arial, helvetica, sans-serif; font-size: 10pt;"><span>Hello,</span></div><div style="font-family: arial, helvetica, sans-serif; font-size: 13px; color: rgb(0, 0, 0); background-color: transparent; font-style: normal;"><span><br></span></div><div style="font-family: arial, helvetica, sans-serif; font-size: 13px; color: rgb(0, 0, 0); background-color: transparent; font-style: normal;"><span>Frankly speaking, I agree & tend to disagree at the same time.</span></div><div style="font-family: arial, helvetica, sans-serif; font-size: 13px; color: rgb(0, 0, 0); background-color: transparent; font-style: normal;"><span><br></span></div><div style="background-color: transparent; color: rgb(0, 0, 0); font-style: normal; font-size: 13px;"><ul style="font-family: arial, helvetica, sans-serif; font-size: 13px;"><li><span
style="font-size: 13px;"> I agree that </span><span style="font-family: 'times new roman', 'new york', times, serif; font-size: 16px;">cs8900_isr() should be a static function, as it should not be accessed outside this file.</span></li><li><span style="font-family: 'times new roman', 'new york', times, serif; font-size: 16px;">The declarations for global functions should not be present in source file, because their prototypes should be present in a header file.</span></li></ul><div style="font-family: arial, helvetica, sans-serif;"><span style="font-family: 'times new roman', 'new york', times, serif;"><br></span></div><div><span style="font-family: 'times new roman', 'new york', times, serif;">I don't understand, why </span><span style="font-family: 'times new roman', 'new york', times, serif; font-size: 16px; background-color: transparent;">cs8900_isr() cannot be made to pass </span><span style="font-family: 'times new roman', 'new
york', times, serif; font-size: 16px; background-color: transparent;"> </span><span style="font-family: 'times new roman', 'new york', times, serif; font-size: 16px; background-color: transparent;">cs8900_device *cs like I did in my patch. From where is this function is called ?</span></div></div><div style="font-family: arial, helvetica, clean, sans-serif; font-size: 13px; color: rgb(0, 0, 0); background-color: transparent; font-style: normal;"><br></div><div style="font-family: arial, helvetica, clean, sans-serif; font-size: 13px; color: rgb(0, 0, 0); background-color: transparent; font-style: normal;">Regards</div><div style="font-family: arial, helvetica, clean, sans-serif; font-size: 13px; color: rgb(0, 0, 0); background-color: transparent; font-style: normal;"><span style="background-color:transparent;line-height:1.22;">Vipul Nayyar </span></div><div style="font-family: arial, helvetica, clean, sans-serif; font-size:
12.727272033691406px; color: rgb(0, 0, 0); background-color: transparent; font-style: normal;"><br></div><div style="font-family: arial, helvetica, sans-serif; font-size: 10pt;"><br></div> <div style="font-family: arial, helvetica, sans-serif; font-size: 10pt;"> <div style="font-family: 'times new roman', 'new york', times, serif; font-size: 12pt;"> <div dir="ltr"> <hr size="1"> <font size="2" face="Arial"> <b><span style="font-weight:bold;">From:</span></b> Sebastian Huber <sebastian.huber@embedded-brains.de><br> <b><span style="font-weight: bold;">To:</span></b> Vipul Nayyar <nayyar_vipul@yahoo.com> <br><b><span style="font-weight: bold;">Cc:</span></b> "rtems-devel@rtems.org" <rtems-devel@rtems.org> <br> <b><span style="font-weight: bold;">Sent:</span></b> Friday, 12 July 2013 5:40 PM<br> <b><span style="font-weight: bold;">Subject:</span></b> Re: [PATCH] Updated Legacy code in arm rtl22xx<br> </font> </div> <div
class="y_msg_container"><br>On 07/12/2013 02:01 PM, Vipul Nayyar wrote:<br>> You want this : (rtems_interrupt_handler)cs8900_isr ?<br><br>No, I want this<br><br>static void cs8900_isr(void *arg)<br>{<br> cs8900_device *cs = arg;<br><br> ...<br>}<br><br>Please remember that declarations of global functions in a source file are not <br>acceptable.<br><br>Do you know why this is a problem?<br><br>><br>> Plus, Do I need to put 0 instead of NULL ? I don't know right now if I'm aware<br>> of the answer or I'm just overlooking it .<br><br>How does the interrupt handler function cs8900_isr() get its argument value?<br><br>[...]<br><br>-- <br>Sebastian Huber, embedded brains GmbH<br><br>Address : Dornierstr. 4, D-82178 Puchheim, Germany<br>Phone : +49 89 189 47 41-16<br>Fax : +49 89 189 47 41-09<br>E-Mail : <a ymailto="mailto:sebastian.huber@embedded-brains.de"
href="mailto:sebastian.huber@embedded-brains.de">sebastian.huber@embedded-brains.de</a><br>PGP : Public key available on request.<br><br>Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.<br><br><br></div> </div> </div> </div></body></html>