<html><body><div style="color:#000; background-color:#fff; font-family:arial, helvetica, sans-serif;font-size:10pt"><div><span>If I don't need that intermediate variable, then my previous patch containing</span></div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: arial, helvetica, sans-serif; background-color: transparent; font-style: normal;"><span style="color: rgb(34, 34, 34); font-family: arial, sans-serif; font-size: 10pt;">void cs8900_isr(cs8900_device *cs){</span></div><div style="color: rgb(34, 34, 34); font-size: 10pt; font-family: arial, sans-serif; background-color: transparent; font-style: normal;"><span style="color: rgb(34, 34, 34); font-family: arial, sans-serif; font-size: 10pt;"> </span><span style="font-size: 10pt; color: rgb(34, 34, 34); font-family: arial, sans-serif;">cs8900_interrupt(LPC22xx_</span><wbr style="font-size: 10pt; color: rgb(34, 34, 34); font-family: arial, sans-serif;"><span style="font-size: 10pt;
color: rgb(34, 34, 34); font-family: arial, sans-serif;">INTERRUPT_EINT2, cs); </span></div><div style="color: rgb(34, 34, 34); font-size: 10pt; font-family: arial, sans-serif; background-color: transparent; font-style: normal;"><span style="font-size: 10pt; color: rgb(34, 34, 34); font-family: arial, sans-serif;">}</span></div><div style="color: rgb(34, 34, 34); font-size: 10pt; font-family: arial, sans-serif; background-color: transparent; font-style: normal;"><span style="color: rgb(34, 34, 34); font-family: arial, sans-serif; font-size: 10pt;">,should be correct right ? </span></div><div style="color: rgb(34, 34, 34); font-size: 10pt; font-family: arial, sans-serif; background-color: transparent; font-style: normal;"><span style="color: rgb(34, 34, 34); font-family: arial, sans-serif; font-size: 10pt;"><br></span></div><div style="color: rgb(34, 34, 34); font-size: 13px; font-family: arial, sans-serif; background-color: transparent;
font-style: normal;">I followed the flow of <span style="font-size: 10pt;">bsp_interrupt_handler_</span><u style="font-size: 10pt;"></u><span style="font-size: 10pt;">dispatch() & where it leads, but couldn't figure out much. Will try again tomorrow.</span></div><div style="color: rgb(34, 34, 34); font-size: 10pt; font-family: arial, sans-serif; background-color: transparent; font-style: normal;"><span style="font-size: 10pt;"><br></span></div><div style="color: rgb(34, 34, 34); font-size: 13px; font-family: arial, sans-serif; background-color: transparent; font-style: normal;"><span style="font-size: 10pt;">I still don't understand what mistake I'm doing regarding removing superfluous entities from the code. :-(</span></div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: arial, helvetica, clean, sans-serif; background-color: transparent; font-style: normal;"><br></div><div style="color: rgb(0, 0, 0); font-size: 13px;
font-family: arial, helvetica, clean, sans-serif; background-color: transparent; font-style: normal;">Regards</div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: arial, helvetica, clean, sans-serif; background-color: transparent; font-style: normal;"><span style="background-color:transparent;line-height:1.22;">Vipul Nayyar </span></div><div style="color: rgb(0, 0, 0); font-size: 12.727272033691406px; font-family: arial, helvetica, clean, sans-serif; background-color: transparent; font-style: normal;"><br></div><div><br></div> <div style="font-family: arial, helvetica, sans-serif; font-size: 10pt;"> <div style="font-family: 'times new roman', 'new york', times, serif; font-size: 12pt;"> <div dir="ltr"> <hr size="1"> <font size="2" face="Arial"> <b><span style="font-weight:bold;">From:</span></b> Sebastian Huber <sebastian.huber@embedded-brains.de><br> <b><span style="font-weight: bold;">To:</span></b> Vipul Nayyar
<nayyar_vipul@yahoo.com> <br><b><span style="font-weight: bold;">Cc:</span></b> "rtems-devel@rtems.org" <rtems-devel@rtems.org> <br> <b><span style="font-weight: bold;">Sent:</span></b> Saturday, 13 July 2013 1:00 AM<br> <b><span style="font-weight: bold;">Subject:</span></b> Re: [PATCH] Updated Legacy code in arm rtl22xx<br> </font> </div> <div class="y_msg_container"><br>On 12/07/13 17:30, Vipul Nayyar wrote:<br>> Ok, So before sending the updated patch I'll list in advance what I'm gonna change, so that we don't have to go through this again.<br>><br>> 1) Change cs8900_isr to static. The sample code would be:<br>> static void cs8900_isr(void *arg)<br>> {<br>> cs8900_device *cs = arg;<br>> cs8900_interrupt(LPC22xx_INTERRUPT_EINT2, cs);<br>> }<br><br>This is all right in principle, but you don't need the intermediate <br>variable.<br><br>Now the questions are:<br><br>1. Who
will call this function?<br><br>2. Where does the actual arg argument value come from?<br><br>-- <br>Sebastian Huber, embedded brains GmbH<br><br>Address : Dornierstr. 4, D-82178 Puchheim, Germany<br>Phone : +49 89 189 47 41-16<br>Fax : +49 89 189 47 41-09<br>E-Mail : <a ymailto="mailto:sebastian.huber@embedded-brains.de" href="mailto:sebastian.huber@embedded-brains.de">sebastian.huber@embedded-brains.de</a><br>PGP : Public key available on request.<br><br>Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.<br><br><br><br></div> </div> </div> </div></body></html>