<html><body><div style="color:#000; background-color:#fff; font-family:arial, helvetica, sans-serif;font-size:10pt"><div><span>Hello,</span></div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: arial, helvetica, sans-serif; background-color: transparent; font-style: normal;"><br></div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: arial, helvetica, sans-serif; background-color: transparent; font-style: normal;">I fail to see which part is superfluous, since the pointer cs is now used directly by the dispatch function to call the interrupt handler with parameter arg. The role of g_cs is completely removed.</div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: arial, helvetica, clean, sans-serif; background-color: transparent; font-style: normal;"><br></div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: arial, helvetica, clean, sans-serif; background-color: transparent; font-style:
normal;">Regards</div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: arial, helvetica, clean, sans-serif; background-color: transparent; font-style: normal;"><span style="background-color:transparent;line-height:1.22;">Vipul Nayyar </span></div><div style="color: rgb(0, 0, 0); font-size: 12.727272033691406px; font-family: arial, helvetica, clean, sans-serif; background-color: transparent; font-style: normal;"><br></div><div><br></div> <div style="font-family: arial, helvetica, sans-serif; font-size: 10pt;"> <div style="font-family: 'times new roman', 'new york', times, serif; font-size: 12pt;"> <div dir="ltr"> <hr size="1"> <font size="2" face="Arial"> <b><span style="font-weight:bold;">From:</span></b> Sebastian Huber <sebastian.huber@embedded-brains.de><br> <b><span style="font-weight: bold;">To:</span></b> Vipul Nayyar <nayyar_vipul@yahoo.com> <br><b><span style="font-weight: bold;">Cc:</span></b>
"rtems-devel@rtems.org" <rtems-devel@rtems.org> <br> <b><span style="font-weight: bold;">Sent:</span></b> Monday, 15 July 2013 1:57 PM<br> <b><span style="font-weight: bold;">Subject:</span></b> Re: [PATCH] Updated Legacy code in arm rtl22xx<br> </font> </div> <div class="y_msg_container"><br>On 07/13/2013 10:18 AM, Vipul Nayyar wrote:<br>> @@ -69,13 +63,26 @@ unsigned short cs8900_mem_get_reg (cs8900_device *cs,<br>> unsigned long reg)<br>><br>> void cs8900_attach_interrupt (cs8900_device *cs)<br>> {<br>> - g_cs = cs;<br>> - BSP_install_rtems_irq_handler(&cs8900_isr_data);<br>> + rtems_status_code status = RTEMS_SUCCESSFUL;<br>> + status = rtems_interrupt_handler_install(<br>> + LPC22xx_INTERRUPT_EINT2,<br>> + "Network",<br>> + RTEMS_INTERRUPT_UNIQUE,<br>> +
(rtems_interrupt_handler)cs8900_isr,<br><br>Since you fixed the cs8900_isr(), this case is now superfluous.<br><br>-- <br>Sebastian Huber, embedded brains GmbH<br><br>Address : Dornierstr. 4, D-82178 Puchheim, Germany<br>Phone : +49 89 189 47 41-16<br>Fax : +49 89 189 47 41-09<br>E-Mail : <a ymailto="mailto:sebastian.huber@embedded-brains.de" href="mailto:sebastian.huber@embedded-brains.de">sebastian.huber@embedded-brains.de</a><br>PGP : Public key available on request.<br><br>Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.<br><br><br></div> </div> </div> </div></body></html>