<html><body><div style="color:#000; background-color:#fff; font-family:arial, helvetica, sans-serif;font-size:10pt"><div style="font-family: arial, helvetica, sans-serif; font-size: 10pt;"><span>Hello,</span></div><div style="font-family: arial, helvetica, sans-serif; font-size: 13px; color: rgb(0, 0, 0); background-color: transparent; font-style: normal;"><span><br></span></div><div style="font-family: arial, helvetica, sans-serif; font-size: 13px; color: rgb(0, 0, 0); background-color: transparent; font-style: normal;"><span>BTW, Just wanted to clarify, that I always compile & check for warnings before submitting. In the case of gumstix, I've compiled it now again & earlier also when this thread was active. I haven't faced any errors or warnings related to the files that I edited. Just a couple of warnings in bspstart.c & abort.c . Rest warnings are from cpukit & libcpu.</span></div><div style="font-family: arial, helvetica, sans-serif;
font-size: 13px; color: rgb(0, 0, 0); background-color: transparent; font-style: normal;"><span><br></span></div><div style="background-color: transparent;"><span><div style="background-color: transparent;"><font size="2">../../../../../../../../rtems/c/src/lib/libbsp/arm/gumstix/startup/bspstart.c:32:6: warning: no previous prototype for 'bsp_start_default' [-Wmissing-prototypes]</font></div><div style="background-color: transparent;"><font size="2"> void bsp_start_default( void )</font></div><div style="background-color: transparent;"><font size="2"> ^</font></div><div style="background-color: transparent;"><font size="2">../../../../../../../../rtems/c/src/lib/libbsp/arm/gumstix/startup/bspstart.c:47:6: warning: no previous prototype for 'bsp_reset' [-Wmissing-prototypes]</font></div><div style="background-color: transparent;"><font size="2"> void bsp_reset( void )</font></div><div style="background-color:
transparent;"><font size="2"> ^</font></div><div style="background-color: transparent;"><font size="2">../../../../../../../../rtems/c/src/lib/libbsp/arm/gumstix/../shared/abort/abort.c:63:6: warning: no previous prototype for '_print_full_context' [-Wmissing-prototypes]</font></div><div style="background-color: transparent;"><font size="2"> void _print_full_context(uint32_t spsr)</font></div><div style="background-color: transparent;"><font size="2"> ^</font></div><div style="background-color: transparent;"><font size="2">../../../../../../../../rtems/c/src/lib/libbsp/arm/gumstix/../shared/abort/abort.c:105:6: warning: no previous prototype for 'do_data_abort' [-Wmissing-prototypes]</font></div><div style="background-color: transparent;"><font size="2"> void do_data_abort(uint32_t insn, uint32_t spsr,</font></div><div style="background-color: transparent;"><font size="2">
^</font></div><div style="background-color: transparent;"><font size="2">../../../../../../../../rtems/c/src/lib/libbsp/arm/gumstix/../shared/abort/abort.c: In function 'do_data_abort':</font></div><div style="background-color: transparent;"><font size="2">../../../../../../../../rtems/c/src/lib/libbsp/arm/gumstix/../shared/abort/abort.c:111:27: warning: variable 'level' set but not used [-Wunused-but-set-variable]</font></div><div style="background-color: transparent;"><font size="2"> rtems_interrupt_level level;</font></div><div style="background-color: transparent;"><font size="2"> ^</font></div><div style="background-color: transparent; color: rgb(0, 0, 0); font-size: 13px; font-family: arial, helvetica, sans-serif; font-style: normal;"><font size="2"><br></font></div><div style="background-color: transparent; color: rgb(0, 0,
0); font-size: 13px; font-family: arial, helvetica, sans-serif; font-style: normal;"><font size="2">I really appreciate your efforts, in criticizing my patches & helping me improve them. </font></div><div style="color: rgb(0, 0, 0); font-family: arial, helvetica, sans-serif; font-size: 13px; font-style: normal;"><br></div></span></div><div style="font-family: arial, helvetica, clean, sans-serif; font-size: 13px; color: rgb(0, 0, 0); background-color: transparent; font-style: normal;">Regards</div><div style="font-family: arial, helvetica, clean, sans-serif; font-size: 13px; color: rgb(0, 0, 0); background-color: transparent; font-style: normal;"><span style="background-color:transparent;line-height:1.22;">Vipul Nayyar </span></div><div style="font-family: arial, helvetica, clean, sans-serif; font-size: 12.727272033691406px; color: rgb(0, 0, 0); background-color: transparent; font-style: normal;"><br></div><div style="font-family: arial,
helvetica, sans-serif; font-size: 10pt;"><br></div> <div style="font-family: arial, helvetica, sans-serif; font-size: 10pt;"> <div style="font-family: 'times new roman', 'new york', times, serif; font-size: 12pt;"> <div dir="ltr"> <hr size="1"> <font size="2" face="Arial"> <b><span style="font-weight:bold;">From:</span></b> Sebastian Huber <sebastian.huber@embedded-brains.de><br> <b><span style="font-weight: bold;">To:</span></b> rtems-devel@rtems.org <br> <b><span style="font-weight: bold;">Sent:</span></b> Saturday, 13 July 2013 1:29 AM<br> <b><span style="font-weight: bold;">Subject:</span></b> Re: [PATCH] Updated legacy code on arm gumstix<br> </font> </div> <div class="y_msg_container"><br>I got this:<br><br>arm-rtems4.11-gcc --pipe -B../../../../../.././lib/ <br>-B../../../../../.././gumstix/lib/ -specs bsp_specs -qrtems <br>-DHAVE_CONFIG_H -isystem ../../../../../.././gumstix/lib/include <br>-D__INSIDE_RTEMS_BSD_TCPIP_STACK__
-mstructure-size-boundary=8 <br>-mcpu=xscale -mfpu=vfp -mfloat-abi=soft -O2 -g -Wall <br>-Wmissing-prototypes -Wimplicit-function-declaration -Wstrict-prototypes <br>-Wnested-externs -MT rtl8019_rel-rtl8019.o -MD -MP -MF <br>.deps/rtl8019_rel-rtl8019.Tpo -c -o rtl8019_rel-rtl8019.o `test -f <br>'rtl8019/rtl8019.c' || echo <br>'/home/sh/rtems-4.11/c/src/lib/libbsp/arm/gumstix/'`rtl8019/rtl8019.c<br>/home/sh/rtems-4.11/c/src/lib/libbsp/arm/gumstix/rtl8019/rtl8019.c: In <br>function 'ne_init_irq_handler':<br>/home/sh/rtems-4.11/c/src/lib/libbsp/arm/gumstix/rtl8019/rtl8019.c:486:5: warning: <br>passing argument 4 of 'rtems_interrupt_handler_install' from <br>incompatible pointer type [enabled by default]<br> );<br> ^<br>In file included from <br>../../../../../.././gumstix/lib/include/bsp/irq.h:19:0,<br> from
<br>/home/sh/rtems-4.11/c/src/lib/libbsp/arm/gumstix/rtl8019/rtl8019.c:12:<br>../../../../../.././gumstix/lib/include/rtems/irq-extension.h:114:19: <br>note: expected 'rtems_interrupt_handler' but argument is of type 'void <br>(*)(struct ne_softc *)'<br> rtems_status_code rtems_interrupt_handler_install(<br><br>Didn't we agree, that you compile the code and eliminate all warnings?<br><br><a href="http://git.rtems.org/rtems/commit/?id=163e88a8c36815dad65a0342a2d6f851f1f5ed9f" target="_blank">http://git.rtems.org/rtems/commit/?id=163e88a8c36815dad65a0342a2d6f851f1f5ed9f</a><br><br>On 12/07/13 19:03, Vipul Nayyar wrote:<br>> ---<br>> c/src/lib/libbsp/arm/gumstix/rtl8019/rtl8019.c | 15 ++++-----------<br>> 1 file changed, 4 insertions(+), 11 deletions(-)<br>><br>> diff --git a/c/src/lib/libbsp/arm/gumstix/rtl8019/rtl8019.c b/c/src/lib/libbsp/arm/gumstix/rtl8019/rtl8019.c<br>> index ef8ae4e..d419eac 100644<br>> ---
a/c/src/lib/libbsp/arm/gumstix/rtl8019/rtl8019.c<br>> +++ b/c/src/lib/libbsp/arm/gumstix/rtl8019/rtl8019.c<br>> @@ -332,10 +332,8 @@ ne_check_status (struct ne_softc *sc, int from_irq_handler)<br>> /* Handle an NE2000 interrupt. */<br>> <br>> static void<br>> -ne_interrupt_handler (rtems_irq_hdl_param handle)<br>> +ne_interrupt_handler (struct ne_softc *sc)<br>> {<br>> - struct ne_softc *sc = handle;<br>> -<br>> if (sc == NULL)<br>> return;<br>> <br>> @@ -350,10 +348,8 @@ ne_interrupt_handler (rtems_irq_hdl_param handle)<br>> /* Turn NE2000 interrupts on. */<br>> <br>> static void<br>> -ne_interrupt_on (const void * handle)<br>> +ne_interrupt_on (struct ne_softc *sc)<br>> {<br>> - struct ne_softc *sc = handle;<br>> -<br>> #ifdef DEBUG_NE<br>>
printk ("ne_interrupt_on()\n");<br>> #endif<br>> @@ -364,10 +360,8 @@ ne_interrupt_on (const void * handle)<br>> /* Turn NE2000 interrupts off. See ne_interrupt_on. */<br>> <br>> static void<br>> -ne_interrupt_off (const void * handle)<br>> +ne_interrupt_off (struct ne_softc *sc)<br>> {<br>> - struct ne_softc *sc = handle;<br>> -<br>> #ifdef DEBUG_NE<br>> printk ("ne_interrupt_off()\n");<br>> #endif<br>> @@ -380,9 +374,8 @@ ne_interrupt_off (const void * handle)<br>> *If it is eanbled, return 1<br>> */<br>> static int<br>> -ne_interrupt_is_on (const void * handle)<br>> +ne_interrupt_is_on (struct ne_softc *sc)<br>> {<br>> - struct ne_softc *sc = handle;<br>> unsigned char imr;<br>> #ifdef DEBUG_NE<br>>
printk("ne_interrupt_is_on()\n");<br><br><br>-- <br>Sebastian Huber, embedded brains GmbH<br><br>Address : Dornierstr. 4, D-82178 Puchheim, Germany<br>Phone : +49 89 189 47 41-16<br>Fax : +49 89 189 47 41-09<br>E-Mail : <a ymailto="mailto:sebastian.huber@embedded-brains.de" href="mailto:sebastian.huber@embedded-brains.de">sebastian.huber@embedded-brains.de</a><br>PGP : Public key available on request.<br><br>Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.<br><br>_______________________________________________<br>rtems-devel mailing list<br><a ymailto="mailto:rtems-devel@rtems.org" href="mailto:rtems-devel@rtems.org">rtems-devel@rtems.org</a><br><a href="http://www.rtems.org/mailman/listinfo/rtems-devel" target="_blank">http://www.rtems.org/mailman/listinfo/rtems-devel</a><br><br></div> </div> </div> </div></body></html>