<html><body><div style="color:#000; background-color:#fff; font-family:arial, helvetica, sans-serif;font-size:10pt"><div><span><br></span></div><div></div><div>Hello,</div><div><br></div><div>I put <span style="font-family: 'times new roman', 'new york', times, serif; font-size: 16px;">(rtems_interrupt_handler) casts because I was getting warnings. After I removed them now, I think it's working fine. Don't know how.</span></div><div><span style="font-family: 'times new roman', 'new york', times, serif; font-size: 16px;"><br></span></div><div><span style="font-family: 'times new roman', 'new york', times, serif; font-size: 16px;">The indentation around line 684 in 3c509.c is surely correct. It's following the same indentation as above line 'resend = 0;' Have a look.</span></div><div><span style="font-family: 'times new roman', 'new york', times, serif; font-size: 16px;"><br></span></div><div><span style="font-family: 'times new roman', 'new york',
times, serif; font-size: 16px;">I removed the </span><span style="font-family: 'times new roman', 'new york', times, serif; font-size: 16px;">Clock_driver_support_at_tick_empty function because it was empty. So I think my current edit should suffice . Right ?</span></div><div><span style="font-family: 'times new roman', 'new york', times, serif; font-size: 16px;"><br></span></div><div><span style="font-family: 'times new roman', 'new york', times, serif; font-size: 16px;">Passed sc directly to interrupt handler.</span></div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: arial, helvetica, clean, sans-serif; background-color: transparent; font-style: normal;"><br></div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: arial, helvetica, clean, sans-serif; background-color: transparent; font-style: normal;">Regards</div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: arial, helvetica, clean, sans-serif;
background-color: transparent; font-style: normal;"><span style="background-color:transparent;line-height:1.22;">Vipul Nayyar </span></div><div style="color: rgb(0, 0, 0); font-size: 12.727272033691406px; font-family: arial, helvetica, clean, sans-serif; background-color: transparent; font-style: normal;"><br></div><div><br></div> <div style="font-family: arial, helvetica, sans-serif; font-size: 10pt;"> <div style="font-family: 'times new roman', 'new york', times, serif; font-size: 12pt;"> <div dir="ltr"> <hr size="1"> <font size="2" face="Arial"> <b><span style="font-weight:bold;">From:</span></b> Sebastian Huber <sebastian.huber@embedded-brains.de><br> <b><span style="font-weight: bold;">To:</span></b> rtems-devel@rtems.org <br> <b><span style="font-weight: bold;">Sent:</span></b> Wednesday, 24 July 2013 1:06 PM<br> <b><span style="font-weight: bold;">Subject:</span></b> Re: [PATCH] Updated Legacy code in i386 pc386<br> </font> </div>
<div class="y_msg_container"><br>Hello Vipul,<br><br>can you please remove all the (rtems_interrupt_handler) casts.<br><br>On 2013-07-23 17:03, Vipul Nayyar wrote:<br>[...]<br>> @@ -746,8 +681,8 @@ int rtems_3c509_driver_attach (struct rtems_bsdnet_ifconfig *config )<br>> */<br>> overrun = 0;<br>> resend = 0;<br>> - ep_unit = 0;<br>> - ep_boards = 0;<br>> + ep_unit = 0;<br>> + ep_boards = 0;<br><br>Here the indentation is wrong, please check other parts of the patch as well.<br><br>[...]<br>> @@ -326,7 +309,7 @@ void Clock_driver_support_initialize_hardware(void)<br>><br>> if ( use_8254 ) {<br>> /* printk( "Use 8254\n" ); */<br>> - Clock_driver_support_at_tick = Clock_driver_support_at_tick_empty;<br>> + Clock_driver_support_at_tick =
NULL;<br><br>What is the reason for this change?<br><br>[...]<br>> @@ -381,7 +381,7 @@ ne_check_status (struct ne_softc *sc, int from_irq_handler)<br>> /* Handle an NE2000 interrupt. */<br>><br>> static void<br>> -ne_interrupt_handler (rtems_irq_hdl_param cdata)<br>> +ne_interrupt_handler (void * cdata)<br>> {<br>> rtems_vector_number v = (rtems_vector_number) cdata;<br>> struct ne_softc *sc;<br><br>I think you can get rid of ne_device_for_irno if you use the right cdata value <br>(e.g. pass directly sc).<br><br>[...]<br><br>-- <br>Sebastian Huber, embedded brains GmbH<br><br>Address : Dornierstr. 4, D-82178 Puchheim, Germany<br>Phone : +49 89 189 47 41-16<br>Fax : +49 89 189 47 41-09<br>E-Mail : <a ymailto="mailto:sebastian.huber@embedded-brains.de"
href="mailto:sebastian.huber@embedded-brains.de">sebastian.huber@embedded-brains.de</a><br>PGP : Public key available on request.<br><br>Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.<br>_______________________________________________<br>rtems-devel mailing list<br><a ymailto="mailto:rtems-devel@rtems.org" href="mailto:rtems-devel@rtems.org">rtems-devel@rtems.org</a><br><a href="http://www.rtems.org/mailman/listinfo/rtems-devel" target="_blank">http://www.rtems.org/mailman/listinfo/rtems-devel</a><br><br></div> </div> </div> </div></body></html>