<div dir="ltr">Here is the patch created by git format-patch.<br><br>Cheers,<br>Zhongwei<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sun, Aug 4, 2013 at 2:24 PM, Ashi <span dir="ltr"><<a href="mailto:ashi08104@gmail.com" target="_blank">ashi08104@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi, All. The patch is updated according to Sebastian's comments.<br><br>Cheers,<br>Zhongwei<br></div>
<div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Aug 2, 2013 at 7:01 PM, Ashi <span dir="ltr"><<a href="mailto:ashi08104@gmail.com" target="_blank">ashi08104@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote"><div><div>On Fri, Aug 2, 2013 at 2:38 PM, Sebastian Huber <span dir="ltr"><<a href="mailto:sebastian.huber@embedded-brains.de" target="_blank">sebastian.huber@embedded-brains.de</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>On 2013-08-02 03:03, Ashi wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
+ /** This field points to parent freechain node */<br>
+ POSIX_Keys_Freechain_node *fc_node_ptr;<br>
<br>
<br>
I don't think we need this fc_node_ptr.<br>
<br>
Do you mean use a 'Container' macro instead?<br>
</blockquote>
<br></div>
Not necessarily, see below.<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>
<br>
<br>
+ /** This field is the POSIX key used as an rbtree key */<br>
+ pthread_key_t key;<br>
+ /** This field is the Thread id also used as an rbtree key */<br>
+ Objects_Id thread_id;<br>
+ /** This field points to the POSIX key value of specific thread */<br>
+ void *value;<br>
+} POSIX_Keys_Rbtree_node;<br>
<br>
<br>
I would call this POSIX_Keys_Key_value_pair.<br>
<br>
+<br>
+/**<br>
+ * @brief POSIX_Keys_Freechain is used in Freechain structure<br>
+ */<br>
+typedef struct {<br>
+ Freechain_Control super_fc;<br>
+ size_t bump_count;<br>
+} POSIX_Keys_Freechain;<br>
+<br>
+/**<br>
+ * @brief POSIX_Keys_Freechain_node is freechain node<br>
+ */<br></div>
+struct POSIX_Keys_Freechain_node___<u></u>struct {<div><br>
+ Chain_Node ch_node;<br>
+ POSIX_Keys_Rbtree_node rb_node;<br>
+};<br>
<br>
<br>
Why not use POSIX_Keys_Rbtree_node directly?<br>
<br>
Since every freechain node needs a Chain_Node in its first field. There is a<br>
Chain_Node in POSIX_Keys_Rbtree_node, but it is used in each thread's key<br>
value chain. So I add a Chain_Node to POSIX_Keys_Rbtree_node.<br>
</div></blockquote>
<br>
The key value pairs on the free chain are unused, thus not part of other data structures. So basically you can cast an unused object to any type provided it has enough storage.</blockquote></div></div><div>Cool! I see. I didn't realise the whole key value pairs is actually unused until it moves from Freechain to POSIX key value pair.<br>
</div><div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><br>
<br>
-- <br>
Sebastian Huber, embedded brains GmbH<br>
<br>
Address : Dornierstr. 4, D-82178 Puchheim, Germany<br>
Phone : +49 89 189 47 41-16<br>
Fax : +49 89 189 47 41-09<br>
E-Mail : <a href="mailto:sebastian.huber@embedded-brains.de" target="_blank">sebastian.huber@embedded-<u></u>brains.de</a><br>
PGP : Public key available on request.<br>
<br>
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.<br>
</div></div></blockquote></div></div><br></div></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>