<div dir="ltr">Hello,<div><br></div><div>After applying the patch that Joel has sent out, there is a new bug that is occuring in smpatomic tests.</div><div><br></div><div>The bug is shown below,</div><div><br></div><div><div style="font-family:arial,sans-serif;font-size:13px">
gmake[6]: Entering directory `/home/harsha/rtems/4.11/pc386/i386-rtems4.11/c/pc386/testsuites/smptests/smpatomic02'</div><div style="font-family:arial,sans-serif;font-size:13px">i386-rtems4.11-gcc -B../../../../../pc386/lib/ -specs bsp_specs -qrtems -DHAVE_CONFIG_H -I. -I../../../../../../../rtems/c/src/../../testsuites/smptests/smpatomic02 -I.. -I../../../../../../../rtems/c/src/../../testsuites/smptests/../support/include -mtune=i386 -O2 -g -Wall -Wmissing-prototypes -Wimplicit-function-declaration -Wstrict-prototypes -Wnested-externs -MT tasks.o -MD -MP -MF .deps/tasks.Tpo -c -o tasks.o ../../../../../../../rtems/c/src/../../testsuites/smptests/smpatomic02/tasks.c</div>
<div style="font-family:arial,sans-serif;font-size:13px">In file included from ../../../../../pc386/lib/include/rtems/score/cpuatomic.h:29:0,</div><div style="font-family:arial,sans-serif;font-size:13px"> from ../../../../../pc386/lib/include/rtems/score/atomic.h:21,</div>
<div style="font-family:arial,sans-serif;font-size:13px"> from ../../../../../pc386/lib/include/rtems/rtems/atomic.h:26,</div><div style="font-family:arial,sans-serif;font-size:13px"> from ../../../../../../../rtems/c/src/../../testsuites/smptests/smpatomic02/tasks.c:19:</div>
<div style="font-family:arial,sans-serif;font-size:13px">../../../../../pc386/lib/include/rtems/score/cpustdatomic.h: In function 'Test_task':</div><div style="font-family:arial,sans-serif;font-size:13px">../../../../../pc386/lib/include/rtems/score/cpustdatomic.h:83:3: error: invalid memory model for '__atomic_load'</div>
<div style="font-family:arial,sans-serif;font-size:13px"> return atomic_load_explicit( object, order );</div><div style="font-family:arial,sans-serif;font-size:13px"> ^</div><div style="font-family:arial,sans-serif;font-size:13px">
../../../../../pc386/lib/include/rtems/score/cpustdatomic.h:91:3: error: invalid memory model for '__atomic_load'</div><div style="font-family:arial,sans-serif;font-size:13px"> return atomic_load_explicit( object, order );</div>
<div style="font-family:arial,sans-serif;font-size:13px"> ^</div><div style="font-family:arial,sans-serif;font-size:13px">gmake[6]: *** [tasks.o] Error 1</div><div style="font-family:arial,sans-serif;font-size:13px">gmake[6]: Leaving directory `/home/harsha/rtems/4.11/pc386/i386-rtems4.11/c/pc386/testsuites/smptests/smpatomic02'</div>
<div class="im" style="font-family:arial,sans-serif;font-size:13px">gmake[5]: *** [all-recursive] Error 1</div></div><div class="im" style="font-family:arial,sans-serif;font-size:13px"><br></div><div class="im" style="font-family:arial,sans-serif;font-size:13px">
Thanks,</div><div class="im" style="font-family:arial,sans-serif;font-size:13px">Sree</div><div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Aug 16, 2013 at 4:57 PM, Joel Sherrill <span dir="ltr"><<a href="mailto:joel.sherrill@oarcorp.com" target="_blank">joel.sherrill@oarcorp.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I think the change from #ifdef to #if changed this.<br>
pc386 set CLOCK_DRIVER_ISRS_PER_TICK to a<br>
string rather than a numeric value. I added<br>
CLOCK_DRIVER_ISRS_PER_TICK_<u></u>VALUE and<br>
did some other clean up on the driver.<br>
<br>
With the attached patch, it compiles again and<br>
ticker runs.<br>
<br>
Please review and let me know if OK to commit.<div class="HOEnZb"><div class="h5"><br>
<br>
On 8/16/2013 11:03 AM, Gedare Bloom wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
OK. If you find the bug in the modified clockdrv_shell.h think about<br>
how it might be fixed.<br>
<br>
On Fri, Aug 16, 2013 at 11:49 AM, Vipul Nayyar <<a href="mailto:nayyar_vipul@yahoo.com" target="_blank">nayyar_vipul@yahoo.com</a>> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hello,<br>
<br>
Will look more closely into the matter.<br>
<br>
FWIW, I compiled the pc386 bsp giving the same configure statement as Sree<br>
gave, in my personal fork of rtems from github which is about 18 or so<br>
commits behind the master( that means my fork does not contain Sebastian &<br>
Chris' #define -> #if patches).<br>
<br>
And it compiled successfully, without giving any errors.<br>
<br>
What I feel, is that the following two patches that modified<br>
clockdrv_shell.h need to be checked again..<br>
<a href="http://git.rtems.org/rtems/commit/?id=b7f206097313f794dbe53202542b5894aad6a117" target="_blank">http://git.rtems.org/rtems/<u></u>commit/?id=<u></u>b7f206097313f794dbe53202542b58<u></u>94aad6a117</a><br>
<a href="http://git.rtems.org/rtems/commit/?id=d473dc0b22d3276130f893a51350c8bfb8beaac8" target="_blank">http://git.rtems.org/rtems/<u></u>commit/?id=<u></u>d473dc0b22d3276130f893a51350c8<u></u>bfb8beaac8</a><br>
<br>
My patches for pc386 were checked carefully by Sebastian, but will have to<br>
look more closely to find any bug caused due to my patches.<br>
<br>
Regards<br>
Vipul Nayyar<br>
</blockquote></blockquote>
<br>
<br></div></div><div class="HOEnZb"><div class="h5">
-- <br>
Joel Sherrill, Ph.D. Director of Research & Development<br>
joel.sherrill@OARcorp.com On-Line Applications Research<br>
Ask me about RTEMS: a free RTOS Huntsville AL 35805<br>
Support Available <a href="tel:%28256%29%20722-9985" value="+12567229985" target="_blank">(256) 722-9985</a><br>
<br>
</div></div></blockquote></div><br></div>