<html><body><div style="color:#000; background-color:#fff; font-family:arial, helvetica, sans-serif;font-size:10pt"><div><span>Hello,</span></div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: arial, helvetica, sans-serif; background-color: transparent; font-style: normal;"><span><br></span></div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: arial, helvetica, sans-serif; background-color: transparent; font-style: normal;">I also encountered the first error of command not found. Actually the real name of the function defined is <span style="font-family: 'times new roman', 'new york', times, serif; font-size: 16px;">test_its_NOT_there. I corrected this mistake but maybe didn't submit it in the patch. Will correct it.</span></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: 'times new roman', 'new york', times, serif; background-color: transparent; font-style: normal;"><span style="font-family:
'times new roman', 'new york', times, serif; font-size: 16px;"><br></span></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: 'times new roman', 'new york', times, serif; background-color: transparent; font-style: normal;"><span style="font-family: 'times new roman', 'new york', times, serif; font-size: 16px;">BTW, the older code is written for evaluating a single bsp & mine for multiple but I've integrated the previous code in my file in the function which evaluates only a single bsp. I don't evaluate all bsps for a single issue. Each bsp is evaluated completely in its own order for different issues. So, the previous code should work properly. And I think it is.</span></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: 'times new roman', 'new york', times, serif; background-color: transparent; font-style: normal;"><span style="font-family: 'times new roman', 'new york', times, serif; font-size:
16px;"><br></span></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: 'times new roman', 'new york', times, serif; background-color: transparent; font-style: normal;"><span style="font-family: 'times new roman', 'new york', times, serif; font-size: 16px;">Can you please tell me for which bsp you're getting the errors of </span>RTEMS_BSP_CLEANUP_OPTIONS is NOT in ./configure.ac & grep ?</div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: 'times new roman', 'new york', times, serif; background-color: transparent; font-style: normal;">I checked the script without giving any extra options. And I'm not getting any problems in arm bsps.</div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: 'times new roman', 'new york', times, serif; background-color: transparent; font-style: normal;"><br></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: 'times new roman', 'new york', times, serif;
background-color: transparent; font-style: normal;">The results that I mentioned were found in </div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: 'times new roman', 'new york', times, serif; background-color: transparent; font-style: normal;"><div style="color: rgb(102, 102, 102); font-size: 13px; line-height: 18px; font-family: arial, helvetica, sans-serif;"><ul style="padding: 0px 2.5em; margin: 0.5em 0px; line-height: 1.4;"><li style="padding: 0px; margin: 0px 0px 0.25em;">arm/gumstix : bspreset.c not compiled </li><li style="padding: 0px; margin: 0px 0px 0.25em;">arm/gumstix : <b>bsp_reset() present in file startup/bspstart.c</b></li></ul></div><div style="color: rgb(102, 102, 102); font-size: 13px; line-height: 18px; font-family: arial, helvetica, sans-serif;"><ul style="padding: 0px 2.5em; margin: 0.5em 0px; line-height: 1.4;"><li style="padding: 0px; margin: 0px 0px 0.25em;">powerpc/beatnik : bspreset.c not
compiled </li><li style="padding: 0px; margin: 0px 0px 0.25em;">powerpc/beatnik : <b>bsp_reset() present in file include/bsp.h startup/reboot.c</b></li></ul></div><div style="color: rgb(102, 102, 102); font-size: 13px; line-height: 18px; font-family: arial, helvetica, sans-serif;"><ul style="padding: 0px 2.5em; margin: 0.5em 0px; line-height: 1.4;"><li style="padding: 0px; margin: 0px 0px 0.25em;">powerpc/mpc55xxevb : <b>start.S not present in correct path </b></li><li style="padding: 0px; margin: 0px 0px 0.25em;">powerpc/mpc55xxevb : bspreset.c not compiled </li><li style="padding: 0px; margin: 0px 0px 0.25em;">powerpc/mpc55xxevb :<b> bsp_reset() present in file startup/reset.c</b> </li></ul></div><div style="color: rgb(102, 102, 102); font-size: 13px; line-height: 18px; font-family: arial, helvetica, sans-serif;"><ul style="padding: 0px 2.5em; margin: 0.5em 0px; line-height: 1.4;"><li style="padding: 0px; margin: 0px
0px 0.25em;">powerpc/mpc55xxevb :<b> bspgetworkarea.c not compiled </b></li><li style="padding: 0px; margin: 0px 0px 0.25em;">powerpc/mpc55xxevb :<b> bsp_work_area_initialize() present in file startup/bspworkareainit.c</b></li></ul></div></div><div></div><div> </div><div>Either you can check them manually or the script is also giving me the same output with these warnings.</div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: arial, helvetica, clean, sans-serif; background-color: transparent; font-style: normal;"><br></div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: arial, helvetica, clean, sans-serif; background-color: transparent; font-style: normal;"><br></div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: arial, helvetica, clean, sans-serif; background-color: transparent; font-style: normal;">Regards</div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: arial,
helvetica, clean, sans-serif; background-color: transparent; font-style: normal;"><span style="background-color:transparent;line-height:1.22;">Vipul Nayyar </span></div><div style="color: rgb(0, 0, 0); font-size: 12.727272033691406px; font-family: arial, helvetica, clean, sans-serif; background-color: transparent; font-style: normal;"><br></div><div><br></div> <div style="font-family: arial, helvetica, sans-serif; font-size: 10pt;"> <div style="font-family: 'times new roman', 'new york', times, serif; font-size: 12pt;"> <div dir="ltr"> <hr size="1"> <font size="2" face="Arial"> <b><span style="font-weight:bold;">From:</span></b> Joel Sherrill <joel.sherrill@oarcorp.com><br> <b><span style="font-weight: bold;">To:</span></b> Vipul Nayyar <nayyar_vipul@yahoo.com>; "rtems-devel@rtems.org" <rtems-devel@rtems.org> <br> <b><span style="font-weight: bold;">Sent:</span></b> Wednesday, 18 September 2013 11:37 PM<br> <b><span
style="font-weight: bold;">Subject:</span></b> Feedback on Bash script to review BSP File Organization<br> </font> </div> <div class="y_msg_container"><br><br>Hi<br><br>I wanted to run the script and see how I could break it. :)<br><br>I ran it from libbsp/arm and got a few oddities and error<br>messages.<br><br>=== Checking for RTEMS_BSP_BOOTCARD_OPTIONS in BSP configure.ac<br>/home/joel/rtems-4.11-work/rtems-testing/merge-helpers/check_submission:<br>line 232: test_its_not_there: command not found<br><br>The above is clearly an integration issue from merging the<br>scripts.<br><br>=== Checking for RTEMS_BSP_CLEANUP_OPTIONS in BSP configure.ac<br>RTEMS_BSP_CLEANUP_OPTIONS is NOT in ./configure.ac<br><br>The above appears to be from the older code being setup<br>to be inside a single BSP directory while the newer code<br>scans all BSPs for a single issue.<br><br>=== Checking for not using -O2<br>grep: make/custom/*.cfg: No such file or directory<br>===
Checking for turning on extra GCC warning checks<br>grep: make/custom/*.cfg: No such file or directory<br><br>Same issue as previous but manifested differently.<br><br>=== Checking for timing information<br>Please run the timing tests and include the results.<br><br>Ditto.<br><br>I think the older tests need to be adjusted. Each may<br>need to be wrapped in a loop to cycle over each BSP<br>and invoke the test in the right subdirectory. Or the<br>test itself modified.<br><br>Also please point me to a case where a required method<br>is in the wrong file. I recall one in your previous output<br>but am missing it now.<br><br>A little clean up or a check that you are in a single BSP<br>directory is needed. I am not sure which is the right<br>solution. I was leaning to it working on a single BSP directory<br>since that is likely how someone will use it.<br><br>But supporting both modes correctly is useful.<br><br>-- <br>Joel Sherrill, Ph.D.
Director of Research & Development<br><a ymailto="mailto:joel.sherrill@OARcorp.com" href="mailto:joel.sherrill@OARcorp.com">joel.sherrill@OARcorp.com</a> On-Line Applications Research<br>Ask me about RTEMS: a free RTOS Huntsville AL 35805<br>Support Available (256) 722-9985<br><br><br></div> </div> </div> </div></body></html>