<div dir="ltr">Hi Sebastian, <div><br></div><div>I am sending the new git patch attached.</div><div><br></div><div>Best regards.</div></div><div class="gmail_extra"><br clear="all"><div><div dir="ltr"><div><br><img src="http://www.tallertechnologies.com/templates/tallertechnologies/images/signature.png" height="77" width="200"><br>
</div><div><br></div><div><span style="color:rgb(0,0,0);font-family:Verdana;background-color:transparent;vertical-align:baseline"><font size="4">Martin Boretto</font><br></span><span style="color:rgb(0,0,0);font-family:Verdana;background-color:transparent;vertical-align:baseline">Software Engineer</span><br>
</div><div><span style="color:rgb(0,0,0);font-family:Verdana;background-color:transparent;vertical-align:baseline"><br></span></div><div><span style="color:rgb(0,0,0);font-family:Verdana;background-color:transparent;vertical-align:baseline"><div style="color:rgb(34,34,34);font-family:arial,sans-serif">
<span style="font-size:11px;font-family:Verdana;color:rgb(0,0,0);background-color:transparent;vertical-align:baseline"><span style="font-size:13px;background-color:transparent;vertical-align:baseline">Taller Technologies - Argentina<br>
</span></span></div><span style="font-size:11px;background-color:transparent;vertical-align:baseline"><span style="font-size:13px;background-color:transparent;vertical-align:baseline"><font size="1"><font face="arial, helvetica, sans-serif" size="1"><span style="vertical-align:baseline;white-space:pre-wrap;background-color:transparent">San Lorenzo 47, 3rd Floor, Office 5</span><br>
<span style="vertical-align:baseline;white-space:pre-wrap;background-color:transparent">Córdoba, Argentina</span></font></font></span></span></span></div><div><span style="background-color:transparent;vertical-align:baseline"><font color="#000000" face="arial, helvetica, sans-serif" size="1"><span style="white-space:pre-wrap"><br>
</span></font><div style="color:rgb(34,34,34);font-family:arial,sans-serif"><span style="font-size:11px;font-family:Verdana;color:rgb(0,0,0);background-color:transparent;vertical-align:baseline"><span style="font-size:13px;background-color:transparent;vertical-align:baseline"></span><b>Mobile:</b></span><b><span style="font-size:11px;font-family:Verdana;color:rgb(0,0,0);background-color:transparent;vertical-align:baseline"></span></b><span style="font-size:11px;font-family:Verdana;color:rgb(0,0,0);background-color:transparent;vertical-align:baseline"> [+54 358 4206995 (ARG)]<br>
</span><span style="font-size:11px;font-family:Verdana;color:rgb(0,0,0);background-color:transparent;vertical-align:baseline"><span style="background-color:transparent;vertical-align:baseline"><b>Skype:</b> tinacho_b</span></span></div>
</span></div></div></div>
<br><br><div class="gmail_quote">2014-06-05 11:49 GMT-03:00 Sebastian Huber <span dir="ltr"><<a href="mailto:sebastian.huber@embedded-brains.de" target="_blank">sebastian.huber@embedded-brains.de</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5">On 2014-06-05 16:14, Daniel Gutson wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Sebastian,<br>
<br>
On Thu, Jun 5, 2014 at 10:49 AM, Sebastian Huber<br>
<<a href="mailto:sebastian.huber@embedded-brains.de" target="_blank">sebastian.huber@embedded-<u></u>brains.de</a>> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
>On 2014-06-05 15:20, Marcos Díaz wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
>><br>
>>At first we started developing this bsp inside that folder. Although<br>
>>it has many similarities with the lpc1778, it has other differences:<br>
>>There isn't an external memory controller for our bsp.<br>
>>The pinselect is very different for our board (it has more<br>
>>similarities with the one for the lpc24xx). Also the GPIO<br>
>>The start configuration for the main clock and the pll is quite<br>
>>different. And other things<br>
>><br>
>>The macros used for the differentiation of those boards referred to<br>
>>the CPU architecture (ARM_MULTILIB_ARCH_V4 ARM_MULTILIB_ARCH_V7M) and<br>
>>in some cases we could use the functions for the lpc 24xx,in others<br>
>>for the lpc1778, and in others new code.<br>
</blockquote>
><br>
><br>
>We had this problem also on the Freescale MPC5500 and MPC5600 chips. This<br>
>ARM_MULTILIB_ARCH_V4 and ARM_MULTILIB_ARCH_V7M could be replaced with<br>
>something else. For example<br>
><br>
><a href="http://git.rtems.org/rtems/tree/c/src/lib/libbsp/powerpc/mpc55xxevb/configure.ac" target="_blank">http://git.rtems.org/rtems/<u></u>tree/c/src/lib/libbsp/powerpc/<u></u>mpc55xxevb/configure.ac</a><br>
><br>
><a href="http://git.rtems.org/rtems/tree/c/src/lib/libcpu/powerpc/mpc55xx/include/regs.h" target="_blank">http://git.rtems.org/rtems/<u></u>tree/c/src/lib/libcpu/powerpc/<u></u>mpc55xx/include/regs.h</a><br>
><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
>>We created a macro for our<br>
>>bsp, but we should have changed many other macros already placed. Our<br>
>>Idea was to not break any existing code, since we can't test for the<br>
>>other boards.<br>
>>Is it still preferred to merge this new bsp with others?<br>
</blockquote>
><br>
><br>
>I think there is a considerable amount of copy and paste involved here, but<br>
>I didn't review it very closely.<br>
</blockquote>
We are aware of the copy-paste and agree that it is excessive, but also<br>
think that the best solution would involve a refactor in the other 2 BSPs<br>
to re-arrange common code of the three BSPs so it can be reused.<br>
Since this is our first contribution, and we did need this BSP working,<br>
we thought that it was better to do this in a two stages asking for<br>
agreement: first, a "self-contained" BSP in the form we are submitting it now,<br>
and a second stage, discussions in the middle, of refactor involving the<br>
three BSPs.<br>
<br>
Would you agree under these terms? We need to keep working in this BSP<br>
by adding more drivers; we are more than willing to do the refactor of the three<br>
BSPs as part of our development.<br>
<br>
So in case you think it is infeasible to<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
>integrate this BSP into standard the LPC2400 and LPC1700 directory, then we<br>
>can add your specialized BSP. My feeling is that this will generate more<br>
>work in the long run though.<br>
</blockquote>
Agree, please see above.<br>
</blockquote>
<br></div></div>
Ok, can you please re-send this BSP as a proper Git patch with author and commit message.<br>
<br>
In the long run we have to get rid of the BSP centric approach in RTEMS. This is what leads to this mass of copy and paste. Drivers should be independent of the BSP. Only the low-level startup and driver configurations should be part of the BSP (probably using some sort of a flattened device tree).<div class="HOEnZb">
<div class="h5"><br>
<br>
-- <br>
Sebastian Huber, embedded brains GmbH<br>
<br>
Address : Dornierstr. 4, D-82178 Puchheim, Germany<br>
Phone : +49 89 189 47 41-16<br>
Fax : +49 89 189 47 41-09<br>
E-Mail : <a href="mailto:sebastian.huber@embedded-brains.de" target="_blank">sebastian.huber@embedded-<u></u>brains.de</a><br>
PGP : Public key available on request.<br>
<br>
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.<br>
______________________________<u></u>_________________<br>
rtems-devel mailing list<br>
<a href="mailto:rtems-devel@rtems.org" target="_blank">rtems-devel@rtems.org</a><br>
<a href="http://www.rtems.org/mailman/listinfo/rtems-devel" target="_blank">http://www.rtems.org/mailman/<u></u>listinfo/rtems-devel</a><br>
</div></div></blockquote></div><br></div>